From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CC8E9A0588; Tue, 7 Apr 2020 14:20:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2CA2E1BE80; Tue, 7 Apr 2020 14:20:38 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id A6F532BE2 for ; Tue, 7 Apr 2020 14:20:36 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 15CA55C0260; Tue, 7 Apr 2020 08:20:36 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Tue, 07 Apr 2020 08:20:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=IZQDBRtiylhv6gfbYuUWyN2Y+hyWTtD+oJeXEOD5A5Q=; b=FMof5NVZc8VH eqWbiBA1Ikdo/a0Po0yzrIyjEIXjkbsiFeFbzUTkSDnTFY5OufZBcPVitLQcWPbE PkpfYaQOnIta394OuyNWHiulzVXVyLDtSHwt+gY6yV2JB3qBJgMssDn73SsRaKN7 uGgdmkmaNI8O6XCkNkVgIwZ1M5oCnqM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=IZQDBRtiylhv6gfbYuUWyN2Y+hyWTtD+oJeXEOD5A 5Q=; b=ApcJ0RQaGhE+xnLVNNARMEIOL+/YEz5ONlYWO0OWm99HlCUsIP03SkDsa MrB1idt9I1aH+Ytf5ohR6saeoxJf0L0Zi5HU0mTUnlX7D08PocYIXvlkT5qERqI6 QeOiDCxX0IeG9LCv04AXuOaLMJaOF0jvAErklU2jA4mfA3u1RLfotkjZ2xaKfX6W Z9gZLZPEMGG2O9BBi8kerJsyLnZWuFV0HRM7aStCZttPVLWvLFB7NyphwKLU87KV CR+U2Zip3CEWNGdcXH4n8lV8qdpJ7OT9W7xGd1aBZR8isLIxCosIXOQnrO4wG1XA QAKzUEgXPLWBZjrD1zlAjfN5A/QOg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudehgdehvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucffoh hmrghinhepohhuthhlohhokhdrtghomhdpughpughkrdhorhhgpdegtdhngihprdgtohhm necukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 2CF5C328005E; Tue, 7 Apr 2020 08:20:34 -0400 (EDT) From: Thomas Monjalon To: "Hemant Agrawal (OSS)" , Hemant Agrawal Cc: Dodji Seketeli , David Marchand , dev@dpdk.org, "Yigit, Ferruh" , dev , Neil Horman Date: Tue, 07 Apr 2020 14:20:32 +0200 Message-ID: <122022178.ldxATCOdZn@thomas> In-Reply-To: References: <20200302145829.27808-1-hemant.agrawal@nxp.com> <877dzscx97.fsf@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 00/16] NXP DPAAx fixes and enhancements X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 07/04/2020 12:25, Hemant Agrawal: > > In the mean time, the tooling can be tought to ignore changes to these ELF > > symbols, as you you guys all know already. > > > [Hemant] will you please help me about adding entry to libagigail.abignore > I tried doing following, but it is not helping > > --- a/devtools/libabigail.abignore > +++ b/devtools/libabigail.abignore > @@ -2,10 +2,15 @@ > symbol_version = EXPERIMENTAL > [suppress_variable] > symbol_version = EXPERIMENTAL > + name = per_lcore__dpaa2_io > + name = dpaa2_io_portal > > ; Explicit ignore for driver-only ABI > [suppress_type] > name = rte_cryptodev_ops > + name = dpaa2_io_portal_t > > > > > Anyway, all of those symbols in dpaa are part of the driver ABI. > > > We are still missing a way to mark internal symbols. > > > Neil had posted a framework for this > > > > > https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatchwo > > rk.dpdk.org%2Fproject%2Fdpdk%2Flist%2F%3Fseries%3D5004&data=02 > > %7C01%7Chemant.agrawal%40nxp.com%7C91a3230cfd334c28bbdb08d7c4d > > ee590%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6371943339 > > 20186005&sdata=1Is%2BqQwP%2Bn0QVJ2HYK2%2Bx7TJooEvry1sNUUN > > fWMygkM%3D&reserved=0. > > > > > > In order to get this series passing the checks, I recommend NXP > > > rebasing Neil scripts (I will help reviewing this part), then mark all > > > those symbols as internal in its drivers. > > > Other vendor will convert their drivers later, as there is no need at > > > the moment. > > > > [Hemant] I have commented on Neil's series. > It needs more changes in existing code. > An approach like __rte_experimental will work better. I guess you mean __rte_internal? Please Hemant don't wait for someone else filling the gap. If __rte_internal is the right approach, please complete and use it.