From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com [209.85.212.172]) by dpdk.org (Postfix) with ESMTP id E0E8FADBE for ; Wed, 25 Jun 2014 10:32:49 +0200 (CEST) Received: by mail-wi0-f172.google.com with SMTP id hi2so7394345wib.5 for ; Wed, 25 Jun 2014 01:33:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=1SleMWv7YmnGfY1cfKVUSGlSd5shKsgopYUNdr5D7kA=; b=Tk5bH9esifTQHK+U/40d9gAtramzYJJ3gfnOLPW5OmO3iU7H3kHZqftyXjvtAXrOG7 oYCfuAusFyKyhr4dSSLTnq2rkIUaH3MQfOdbQVUb3k2kAZbVvvfDmAD04ZXzq+lFSAh+ vDWpuJrALhbWt60KapobNyod+CBpKv9xtNCRGBCqF+8N70IoUqj64G4DwWP1w4UKBlzi MG4BxdSERbT7QdOCsIglBpyx5e/C7yAAv+qmV2zukiP/Ke+/C9KqSpyF1dH4EqqwhHjw xgqy9qtQ0Wz0BK22y1xT4V+NfaqohyNJHGOhuQJ0ePsRWxxDd+wzaY88O3XBxya7Nqil VSFw== X-Gm-Message-State: ALoCoQmpTfjsKw30EH5utOU1If2J428UPXC9Ao5g86OvTChVvtqCYUQ/qHkNDPqAdTgpjQy4mo6L X-Received: by 10.180.79.38 with SMTP id g6mr8388326wix.61.1403685188287; Wed, 25 Jun 2014 01:33:08 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id wz3sm5955571wjc.39.2014.06.25.01.33.06 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Jun 2014 01:33:07 -0700 (PDT) From: Thomas Monjalon To: "Richardson, Bruce" Date: Wed, 25 Jun 2014 10:33:04 +0200 Message-ID: <12214985.ClK2CaJOyY@xps13> Organization: 6WIND User-Agent: KMail/4.13.1 (Linux/3.14.6-1-ARCH; KDE/4.13.1; x86_64; ; ) In-Reply-To: <59AF69C657FD0841A61C55336867B5B02CEE3359@IRSMSX103.ger.corp.intel.com> References: <20140624090253.140206a7@nehalam.linuxnetplumber.net> <59AF69C657FD0841A61C55336867B5B02CEE3359@IRSMSX103.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 1/3] stringfns: remove rte_snprintf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Jun 2014 08:32:50 -0000 2014-06-24 17:39, Richardson, Bruce: > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen Hemminger > > The function rte_snprintf serves no useful purpose. It is the > > same as snprintf() for all valid inputs. Just remove it and > > replace all uses in current code. > > NAK to this as is. > Approve of replacing all instance of the rte_snprintf function with the > standard version in all our code and libraries. However, rather than just > removing the function completely, I think we should just flag the function > as deprecated initially, and then later on look to remove it completely. I agree we should try to use the "deprecated" attribute when possible. So application porting effort will be smoother. But in this case, there is something different: as Stephen wrote, rte_snprintf is useless. It's useless inside the DPDK so it's even more useless for user applications. As it's really useless, it has no sense to keep it as deprecated. Please, let's simply remove it. -- Thomas