* [dpdk-dev] [PATCH] mk: fix default rule of test subdirectory
@ 2016-07-12 10:22 Thomas Monjalon
2016-07-12 11:16 ` Pattan, Reshma
2016-07-15 10:45 ` Pattan, Reshma
0 siblings, 2 replies; 6+ messages in thread
From: Thomas Monjalon @ 2016-07-12 10:22 UTC (permalink / raw)
To: dev
When using "make -C app/test" (with RTE_SDK/RTE_TARGET adjusted)
without specifying the rule (all), the build is not done.
Indeed the default rule is not "all" anymore since there are some
rules added for external resources link.
It is fixed by adding a reference to "all" at the top of the file
which makes it the default rule.
Note that make app/test_sub (without environment variable) is preffered.
Fixes: ab64f5df8004 ("app/test: support resources externally linked")
Reported-by: Reshma Pattan <reshma.pattan@intel.com>
Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
---
app/test/Makefile | 3 +++
1 file changed, 3 insertions(+)
diff --git a/app/test/Makefile b/app/test/Makefile
index 2de8c7a..6015b19 100644
--- a/app/test/Makefile
+++ b/app/test/Makefile
@@ -33,6 +33,9 @@ include $(RTE_SDK)/mk/rte.vars.mk
ifeq ($(CONFIG_RTE_APP_TEST),y)
+# default rule
+all:
+
# Define an externally linked resource. A linked resource is an arbitrary
# file that is linked into the test binary. The application refers to this
# resource by name. The linked generates identifiers beg_<name> and end_<name>
--
2.7.0
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] mk: fix default rule of test subdirectory
2016-07-12 10:22 [dpdk-dev] [PATCH] mk: fix default rule of test subdirectory Thomas Monjalon
@ 2016-07-12 11:16 ` Pattan, Reshma
2016-07-12 11:38 ` Thomas Monjalon
2016-07-15 10:45 ` Pattan, Reshma
1 sibling, 1 reply; 6+ messages in thread
From: Pattan, Reshma @ 2016-07-12 11:16 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev
Hi,
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Tuesday, July 12, 2016 11:22 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] mk: fix default rule of test subdirectory
>
> When using "make -C app/test" (with RTE_SDK/RTE_TARGET adjusted) without
> specifying the rule (all), the build is not done.
> Indeed the default rule is not "all" anymore since there are some rules added for
> external resources link.
>
> It is fixed by adding a reference to "all" at the top of the file which makes it the
> default rule.
>
> Note that make app/test_sub (without environment variable) is preffered.
>
What is test_sub here? I could not execute the command make app/test_sub(without environment variable) .
Thanks,
Reshma
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] mk: fix default rule of test subdirectory
2016-07-12 10:22 [dpdk-dev] [PATCH] mk: fix default rule of test subdirectory Thomas Monjalon
2016-07-12 11:16 ` Pattan, Reshma
@ 2016-07-15 10:45 ` Pattan, Reshma
2016-07-15 15:24 ` Thomas Monjalon
1 sibling, 1 reply; 6+ messages in thread
From: Pattan, Reshma @ 2016-07-15 10:45 UTC (permalink / raw)
To: Thomas Monjalon, dev
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Tuesday, July 12, 2016 11:22 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] mk: fix default rule of test subdirectory
>
> When using "make -C app/test" (with RTE_SDK/RTE_TARGET adjusted) without
> specifying the rule (all), the build is not done.
> Indeed the default rule is not "all" anymore since there are some rules added for
> external resources link.
>
> It is fixed by adding a reference to "all" at the top of the file which makes it the
> default rule.
>
> Note that make app/test_sub (without environment variable) is preffered.
>
> Fixes: ab64f5df8004 ("app/test: support resources externally linked")
>
> Reported-by: Reshma Pattan <reshma.pattan@intel.com>
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
Acked-by: Reshma Pattan <reshma.pattan@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] mk: fix default rule of test subdirectory
2016-07-15 10:45 ` Pattan, Reshma
@ 2016-07-15 15:24 ` Thomas Monjalon
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2016-07-15 15:24 UTC (permalink / raw)
To: Pattan, Reshma; +Cc: dev
> > When using "make -C app/test" (with RTE_SDK/RTE_TARGET adjusted) without
> > specifying the rule (all), the build is not done.
> > Indeed the default rule is not "all" anymore since there are some rules added for
> > external resources link.
> >
> > It is fixed by adding a reference to "all" at the top of the file which makes it the
> > default rule.
> >
> > Note that make app/test_sub (without environment variable) is preffered.
> >
> > Fixes: ab64f5df8004 ("app/test: support resources externally linked")
> >
> > Reported-by: Reshma Pattan <reshma.pattan@intel.com>
> > Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
>
> Acked-by: Reshma Pattan <reshma.pattan@intel.com>
Applied
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-07-15 15:24 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-12 10:22 [dpdk-dev] [PATCH] mk: fix default rule of test subdirectory Thomas Monjalon
2016-07-12 11:16 ` Pattan, Reshma
2016-07-12 11:38 ` Thomas Monjalon
2016-07-12 11:40 ` Thomas Monjalon
2016-07-15 10:45 ` Pattan, Reshma
2016-07-15 15:24 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).