From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D28FAA0579; Thu, 8 Apr 2021 16:51:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5FC501410C2; Thu, 8 Apr 2021 16:51:41 +0200 (CEST) Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by mails.dpdk.org (Postfix) with ESMTP id 918234068B for ; Thu, 8 Apr 2021 16:51:40 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id 3AA4158096C; Thu, 8 Apr 2021 10:51:38 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 08 Apr 2021 10:51:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= yllbjNqLKbT21z9fBTob+InHn0yIXc1gqRnj089KfXw=; b=MKPm4onKgqejZ6JV BTBfbb00BBqjeP6YEfPRXQXMgk4ykCEE0VktftVfBr0PcoAl5wnH9Z2TQTKqt9mD 25gmwxmt9lHbeGSUrRscOPaNLeyYi4R9sKrQFjog7N+ENW45Tt0CORXPJ5MeLEaz VYT/MPl4q284Znrg3M5UYJldZJrST2zB0ivA3sfgfMxW0y3kQbN/nndzVqWLNW/k E8e1DR4zu2QGmzfZSO3Vbld/HfrbLScXrPE5+6+epbg/Azol3LJ1RN1qRKjnY8GF LMq6CkrxFHuXZsrj9F8e3d4ueN7wYD9a73U1VsXXEr9rlXupfCkSs+RyqM091nmD nDtb5g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=yllbjNqLKbT21z9fBTob+InHn0yIXc1gqRnj089Kf Xw=; b=fC/R0Rij7Fz9HoTXkXXfoks12lWxuFbGhHXUjVV78lLyKqnqkxlXmq2oX gHKqhDh233cWG/qnrjWiKDSUunG7NMeDGkE1u3rBo101+BfwHc9LI7YOcxxjDkVT uUbQFWFOsvAwMlp3yruJZA45LtgIVm0iaZ96tMH0s8plxbBGGti/1UD95BAATmME rUW1c24mfTcotj3/ij0keXtYpUWmpahs3K3TtXaIuCkaKNjYUXXGCHCZJcxwLhqN e3hmLqa+Vuc6GJESWNoR7dqzdAkmXMHx6b/HOc63sA662FyAmHtPIvs+qhhhWJTo /kKG59llmc5di3J7Bks7p8R3a3ZuA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudejledgkeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id F17FE24005C; Thu, 8 Apr 2021 10:51:35 -0400 (EDT) From: Thomas Monjalon To: David Marchand Cc: dev@dpdk.org, bruce.richardson@intel.com, Dmitry Kozlyuk , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam , Ray Kinsella , Neil Horman , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko Date: Thu, 08 Apr 2021 16:51:33 +0200 Message-ID: <12258047.gmOuj8lSv5@thomas> In-Reply-To: <20210406175910.24450-1-david.marchand@redhat.com> References: <20210406163231.19663-1-david.marchand@redhat.com> <20210406175910.24450-1-david.marchand@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] build: list symbols exports in a single file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 06/04/2021 19:59, David Marchand: > Rather than have two files that keeps getting out of sync, let's > annotate the version.map to generate the Windows export file. > > Note: Existing version.map annotation achieved with: > $ for dir in lib/librte_eal drivers/common/mlx5; do > ./buildtools/map-list-symbol.sh $dir/*.map | > while read file version sym; do > ! git grep -qw $sym $dir/*.def || continue; > sed -i -e "s/$sym;/$sym; # WINDOWS_NO_EXPORT/" $dir/*.map; > done; > done > > Signed-off-by: David Marchand Acked-by: Thomas Monjalon That's a nice improvement. Fixes to remove WINDOWS_NO_EXPORT annotations would be great to see from the original authors of the concerned symbols. I think we should merge this patch quickly to avoid having more discrepancies with the coming EAL patches.