From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id 1C65A2BAA for ; Wed, 23 Mar 2016 11:01:46 +0100 (CET) Received: by mail-wm0-f47.google.com with SMTP id l68so16386209wml.1 for ; Wed, 23 Mar 2016 03:01:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=wPUQtq8Z/7xYPUxHw+R9WasPg9m1KhOUlhlb7CuI/qk=; b=s/iTU1isxTUZLPyc14pAnx+x4fY9hNWTDLE18/4O3qcY+hbhml0ba4q5Hpv3CqN0IE QkrK+u6cu7suOsXwFbaeZUsb6A3i26CIchZDod1hgPhcaukyB1i8WrbJ/FqsMKwMEO6n gYsIIYQpBQ5qLt9KSD2OU5UJxFZNzsdhZdFfY8N/i6bTQwITRrdIAGNWzv9l41DNfhT7 i4oR5/TvZ8oCN4sX9CORcFnYvNrb39Gc7ERGY7aPLHL8qguBk1QlUYM5zMSuPtnYti9W HWJDT5l3nCvSSFk8KAcHdBkwmo2QnqD/J1XM8bsRAZmDO5C+gEsmTmn0BVSGuT3ApFKy kVzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=wPUQtq8Z/7xYPUxHw+R9WasPg9m1KhOUlhlb7CuI/qk=; b=I6ug8m6kqmXwgP9yq2FL0G0aRaXuak5dzq2BJc50evlB2YtHwNAPYEYxA4q/pYuCLM t2k/oWpumWbFFOCtn0qXcoz2WMj0G7DmI38L9KmbMYozsDgciBcjS1KGhDB+L4n38Qxd 9pxwTNBXdT/ohc6W9clrscj17K1wt9nNZoiSug75qXJx/cY+Y/6P+t666z6IJh8txqi3 IXe47NcmdySWcA2mfkYHmVK+vCiqfThUUZpx5fmVCH9P0JyolYd4togVqb6x0aRES85B Q0d00P4Y9P1QORQ9ddoqT+tFvWnYQoWsvrTvs3Unw0cfKet6jOhrgLZRkxD4KO/sASDF b0Lg== X-Gm-Message-State: AD7BkJLxKqFlf2y6QqTzZqs/E2Q64CpgK8HbK0IGpwzkGrKmro0Sr39iER+OUuUirM8GEQgt X-Received: by 10.28.34.69 with SMTP id i66mr25855375wmi.91.1458727305941; Wed, 23 Mar 2016 03:01:45 -0700 (PDT) Received: from xps13.localnet (91.111.75.86.rev.sfr.net. [86.75.111.91]) by smtp.gmail.com with ESMTPSA id et11sm1740693wjc.30.2016.03.23.03.01.44 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 23 Mar 2016 03:01:45 -0700 (PDT) From: Thomas Monjalon To: Markos Chandras Cc: dev@dpdk.org Date: Wed, 23 Mar 2016 11:00:03 +0100 Message-ID: <12259482.yKfMHTRKXF@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1458666816-29778-1-git-send-email-mchandras@suse.de> References: <1458666816-29778-1-git-send-email-mchandras@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] mk: toolchain: gcc: query the compiler macros to obtain the gcc version X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Mar 2016 10:01:46 -0000 2016-03-22 17:13, Markos Chandras: > This is similar to what's being used in the Linux kernel. Querying the > GCC macros directly gives more accurate results compared to -dumpversion > which could vary across distributions. > > Signed-off-by: Markos Chandras > --- > In openSUSE Tumbleweed (and in any other SUSE distribution which > uses (or will use) gcc >= 5), gcc -dumpversion returns '5'. This is on > purpose as discussed in https://bugzilla.opensuse.org/show_bug.cgi?id=941428 > As a result of which, the gcc-4.x comparison (40 against 5) does not > work leading to tons of warnings and failures during build. This patch > aims to change the way the gcc version is obtained by using the gcc macros > directly. > --- Acked-by: Thomas Monjalon Applied, thanks