From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6E64342D8B; Thu, 29 Jun 2023 13:13:35 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4414B40EDB; Thu, 29 Jun 2023 13:13:35 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2075.outbound.protection.outlook.com [40.107.220.75]) by mails.dpdk.org (Postfix) with ESMTP id 67EB5406B7 for ; Thu, 29 Jun 2023 13:13:33 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kwIU5VNZRdCZXtVRjUooFstxB6LHbXJ3HYAtSbxLygE+04dOmkXzCB+MiO0k7JfwXxt4KuCqcTl+kovbEwxKUKkeZ/ciW1eJCwlxnQIjt98n8PDGppfoddeoMKoiWH7mixyre3BtuJykyoYBGxHgIkv1i4iu5i1y5s886gx3in0yCBEsKyeU8ihViO8OSJv6pk3uBA/h5rNjWMU8b1JrAp1vg+PiTYY3psUtRNU6KQwsjEGNwdjZSeWNRZCWE8fv+Q/5a1u3kTrU0js+KHbhnUMyF3V68enV6Q1ERFBLEAM/WLUKyoNyWsDgevLO1GJctmtDrxeB6s3LD/lg/+u/iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=11FTvhH9Sea1bJJpEqr9B8kbl0MIL5YOTKM8J/zsF7Y=; b=Rxe9W2g0ZNYbmtGQGKpRG5LiBHnr4BFMJQVaY3AJBSSFsAXYpcQk7j58UShLcrMsHLs0mJBLzXm8lX6T6SnLU+PFlfTHxyyckA6XPOO5BYHSuDJBr0T9U2L1pdFhU4Fcbvzbl6vSOTGX4Hk2Cp6FSkxnkk7LHhlrGzozRE5zihYo/cZflOxwOcpHuaIoSFdFodj7YQumc9wUp/VuVKYgnVrc7SrPDD1ydTOVtIy2pWj31e3ReuEpt8YR9J5IWg98FdOuE/iXV/DH9LMVSRnki2N9SwLL/oA6eOAVV76ARjF7evFkid5EcTYsiHS51wzdEeytmfsRGJHwav4A7VTy4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=11FTvhH9Sea1bJJpEqr9B8kbl0MIL5YOTKM8J/zsF7Y=; b=G36oPNYuSW4VyNG+iaZLXwQhcT7baVez2XEKArk2UwaLXLV+ppu6k3cYvo04/ouRZ3Txp0JljSck3ZF9jEDwmkDCqCFx/7aZ7UVq7xY4SV4JmkmO3QLCvsP6bTW4WzmKS65Cd2NbroaxHtDRiO08mwNEeLuMwUoBBVRxNaZsMDo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by MN0PR12MB6367.namprd12.prod.outlook.com (2603:10b6:208:3d3::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.26; Thu, 29 Jun 2023 11:13:30 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42%3]) with mapi id 15.20.6544.012; Thu, 29 Jun 2023 11:13:30 +0000 Message-ID: <1225cef1-f080-193a-4c1f-324267e27566@amd.com> Date: Thu, 29 Jun 2023 12:13:23 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] net/netvsc: fix bogus sizeof calculation Content-Language: en-US To: longli@microsoft.com, Andrew Rybchenko Cc: dev@dpdk.org, stable.dpdk.org@linux.microsoft.com, Stephen Hemminger References: <1687998597-11972-1-git-send-email-longli@linuxonhyperv.com> From: Ferruh Yigit In-Reply-To: <1687998597-11972-1-git-send-email-longli@linuxonhyperv.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR2P264CA0024.FRAP264.PROD.OUTLOOK.COM (2603:10a6:101::36) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|MN0PR12MB6367:EE_ X-MS-Office365-Filtering-Correlation-Id: 0ddb1203-75bd-472c-a0db-08db7891dec9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EdTj/gq/k75m3hEQmVtz8rYUUt8pTj3kz6uPRC3FbgIOs7DaPDPHzyhJMEVH5eM2tyVdCSOTLLdOquvQQeEaf09cRLVbMcH+rinLb9nCKz+XjtZFKk0PCI34ToXY4XdN3Qt/zX1ksJuO3AQ4c3owQP7MmGdK/do3mD5ZD5nMa2JkrpScvNlWZ6T3GtBe196R6eTre9FHrbB04280dDBfFymnT9ilTuZOHbWJy1CnjyqpqQN8DXA4SSJxfJXIKn9GNz/0hxpGEM9ASCoaoJ9V4e5N7+sYkEaMTcuLbtQA3b7SGHfIfACKev+FBqudishmsIDlBhE3H8APFv3H4F7nAcUcoN3cSaHTgFqJkiolMlkz9H1zjX/4DZjhRmk8TExXyTKmFhaIJHD+8msQwY6ST6FWfxUQ72l48ZqW5ITBElTf4RJ/8LFI6YHkixXPXGFgLxm7nAjuoY5wVocmZSUhea8zUNgd90LDYidOWO836xcVzbC1P0nBvLA00ZqjhBhetZooBj9wNXSsGd0wIDtoyXI49SM8nAxnSLOlPOMIIC+AJd+Y5vVqS4dNGQcj6JUgyfbVpCb8Ebuamz5cqgN86lRHYSwYXD7lsVb3A2Fm5BhT60Y+CSl5u0RMhf0qYcFlxPMy4i63VXP1djJfBYIj0g== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(376002)(346002)(136003)(39860400002)(396003)(366004)(451199021)(83380400001)(6666004)(45080400002)(478600001)(6486002)(4744005)(53546011)(2906002)(66946007)(186003)(26005)(66476007)(6506007)(66556008)(6512007)(5660300002)(316002)(44832011)(41300700001)(38100700002)(8676002)(6916009)(8936002)(36756003)(4326008)(31696002)(86362001)(2616005)(31686004)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UW5IZE9RSFZ6Q204b0RyMHNFeUtDZjQ5OHVKTG92SU0vaU5kVnArTis3OXpB?= =?utf-8?B?ZXZkcDJxODZSV01EK00zdjdINXpnb1hEWlRMYlU1bFkzY2tSR2V0R3oyVTVx?= =?utf-8?B?QUR3Tkc5OGRHQjYreXpnRXdLdWpkS2JPeWZYSXFiQ0xiNkNma1NHWmZnV0pS?= =?utf-8?B?Nk16Y0Mxb3NBTXJIcDNlOHR0ZVhXM3JYY3lKa2w5V1lDRzNvajBnTyt2NFdF?= =?utf-8?B?VERlUStvemJqKzVmN1Vob0tBRDBxUHFJMjNxdzhSdXR5Tk1YZjUzcXdocFRE?= =?utf-8?B?czNkcnRzNGZLVUhrbExlaWZERXpPK09xVzlxMjJFQVpnelBMWVB0L3hzc2JK?= =?utf-8?B?bm91WlRMT3hGK2w1TW1ieE5UNFNWSG1uWXppV01jOWNUREY2MkZ6NEN3Rit2?= =?utf-8?B?ejhISnE3bGVsTVJBb2pPbTVoWHFmdjRRbFpCdFVuUjh3M3YwU09rMVJ6cXdW?= =?utf-8?B?L295SzBNbzI2YmJveGE4TkdPQUFINHRnWlN5WnY5bWp0bEM2QTcxdmhQR0hF?= =?utf-8?B?Y21kSW5pQVlSMUZHYzVSSVdObElndnNUK3FYRmhTdHVoTWd1SmhhMk8ydjJH?= =?utf-8?B?WlNFK2Z5eDVvL0VEd240NFJ6WDFmcTM3SjBVc1NxbG01Z3htMHZUeEVFL2gz?= =?utf-8?B?RUtDYVMrbWdoOWZiWnlaN3BmVnZNQ0xuS1dxZU5FbTdWM05BcTAvWG9ueW1Y?= =?utf-8?B?ZUEwMmRsQ2ZXU3FVbDNBRkQwTnNsRUF3VTY0amRXL3pyTzAxcnNucm1XZlNu?= =?utf-8?B?eGFueEJOdTVRZ1djakk5UDg4ZmVPbzFnTWx4WFJWWnpPZlZqd2lsZWVBMk1O?= =?utf-8?B?dTl5ekFPQk1NYkNIN0M5TXAyV2dyc2N5WUFCUXdaN3drN243dWJtVXJNTFox?= =?utf-8?B?MTZ4aGUreXpUMmdHV0pjMXlhOHl0Vno0M3U2dlVBQW1adXpPcFBYWEZOL1hR?= =?utf-8?B?MnJ6cVBUclJvdVpwbEk5TjBnQmhmaVdxM3hiaWU3SldUcVJoZWhXM2F3UkQz?= =?utf-8?B?TjRpektEZXU4azg4K05kNEowVkQ5MThpU3p3K2Z0ZXVhUTEyTno2SXV5TGVr?= =?utf-8?B?T3VMT3h3S21rQ1ZpeHM4U2E5cDY0ZjJHTGlhbFVpd3lxbnRETEJoUXV3cGxI?= =?utf-8?B?UXRvWFlqTUliYUJIMk5tbHpPOSt0UzJNVDljaGN4NXA1dmxrdWxteWZoS0tB?= =?utf-8?B?NW0wd1JNWGNVY1BkUXVsUFlpVU1RUSs1cWNGcjY1dmFRWDhETFdtdnZSNGpE?= =?utf-8?B?NE0wRVFOZ29kSDBRTjJOcnlpWnIxUU1LTXRwOGRiWktpM1dlUTVTL3ZsMW5J?= =?utf-8?B?UHc5cjB0ZVRuaTlBcnFMTjFhRWpmODF3N2x4YWp3Qi9YbEhnZ2pBT1hTdFhH?= =?utf-8?B?SUFxUlVvWEZhVks1NmdRMkVtcGw1WUZyb1E1RmR4OVJreEdaQWZPbXdQV0t6?= =?utf-8?B?Z0ZPMnBlbUR6d2RRY2NBdFVJUTVYNUMwQ21ZTVp5eVcxSTJFTFJnc1hoV0J3?= =?utf-8?B?Q3kxVklpeGJqczFxOEkzdisvekRLSGNERUZ5RUJoUExzb1VxYWpwV3FtSG1q?= =?utf-8?B?M1pDdElPQWUySGZiakVXSTJ2RnZITnlLL2c2TmF4akNzSlMvVHpNMG8wVC9I?= =?utf-8?B?UEhBSFBYdG1ueFpXV1pIMFYzS0lnTE5MMmJMM0ptbjk1RmlITXRZZXNUditu?= =?utf-8?B?SEJiN1I5MzVSRy94em9PQzhINUNpN3dQd0QraGFMODdMZlZmQnhHMVdLTisw?= =?utf-8?B?R3NCMG9IcVRHVnU4bDBtUVNxM3BIV2dMa1JhWEdSNXhHU1Y0ejVJdXdpa0t5?= =?utf-8?B?VzNFSVIwM2ZFWWRjL09aWWNXejRzb1FNczFWaTdtd253MlRNOEdYdWRGUGZE?= =?utf-8?B?NEpkVzh0c3oyK1RkOXZLUEI4S3V6azZWYW1GWFMza25HYlZ2RFpwSDFLcVM4?= =?utf-8?B?T3BLS1NVcXByejMxYWNsQURIdDdkOEFZNDVCNWdDaHNES09WbXVGUGRoSjZl?= =?utf-8?B?dkFZemFabW84U0VKWmRXWGpHOEM2Q0lmSVNGZG4yRU5ZM1lpZUV2M25NYThE?= =?utf-8?B?dDBrNFkxdkFnc0llV2FZcTlGZmR6NTZIeC93SXJneG0vYjBINmQrSVg0aW5L?= =?utf-8?Q?iVh9hyUENjBhdNuLahOL2Y2vz?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0ddb1203-75bd-472c-a0db-08db7891dec9 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2023 11:13:30.8640 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vZDTzjI/WgH8fn2JnFHNshpMb8ECgxlKPuk4816CsJS2/vBMQRwbnnPFIhK9YBYx X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6367 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/29/2023 1:29 AM, longli@linuxonhyperv.com wrote: > From: Stephen Hemminger > > Found by cppcheck. > > drivers/net/netvsc/hn_rndis.c:332:21: warning: Found calculation inside sizeof(). [sizeofCalculation] if (len < sizeof(3 * sizeof(uint32_t))) { > > Fixes: 4e9c73e96e83 ("net/netvsc: add Hyper-V network device") > Signed-off-by: Stephen Hemminger > Signed-off-by: Long Li > Applied to dpdk-next-net/main, thanks.