From: Thomas Monjalon <thomas@monjalon.net>
To: Tiwei Bie <tiwei.bie@intel.com>
Cc: dev@dpdk.org, jingjing.wu@intel.com, wenzhuo.lu@intel.com
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: always build VF and MACsec functions
Date: Tue, 20 Jun 2017 09:31:56 +0200 [thread overview]
Message-ID: <12382784.Ehh86DCXep@xps> (raw)
In-Reply-To: <20170620065322.GA12786@debian-ZGViaWFuCg>
20/06/2017 08:53, Tiwei Bie:
> On Thu, Jun 15, 2017 at 01:02:21PM +0200, Thomas Monjalon wrote:
> > These functions are supported only on ixgbe.
> [...]
> > @@ -3013,15 +3013,21 @@ set_vf_traffic(portid_t port_id, uint8_t is_rx, uint16_t vf, uint8_t on)
> >
> > if (diag == 0)
> > return;
> > - if(is_rx)
> > + if(is_rx) {
>
> It's better to also fix this coding style issue.
Yes you're right.
Will fix it when applying, thanks.
prev parent reply other threads:[~2017-06-20 7:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-15 11:02 Thomas Monjalon
2017-06-20 1:01 ` Wu, Jingjing
2017-06-20 7:32 ` Thomas Monjalon
2017-06-20 6:53 ` Tiwei Bie
2017-06-20 7:31 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12382784.Ehh86DCXep@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=tiwei.bie@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).