From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 8B694374
 for <dev@dpdk.org>; Tue, 20 Jun 2017 09:31:57 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 2C8A620888;
 Tue, 20 Jun 2017 03:31:57 -0400 (EDT)
Received: from frontend2 ([10.202.2.161])
 by compute1.internal (MEProxy); Tue, 20 Jun 2017 03:31:57 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=lh6OPq8rHPTo+Xy
 R4vM/1NMhY3H6tpaF6u8Se1bJ3dE=; b=TZBjYRyqh/xF/XXMOtkewcraAEin26F
 l9GB+h0dkaKlqHLL4j4+RFJ681xa/4cFIUI3UpKCeCKdi2PSwGjVSLjO2sOfOkWF
 O8zL09ovcEl8EJVJmevx5wtcXo5dsd3Yj6lmuaFvJU3mRbmb+X+76T/WDtipHMtm
 d6TPSd7LoQqc=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=
 fm1; bh=lh6OPq8rHPTo+XyR4vM/1NMhY3H6tpaF6u8Se1bJ3dE=; b=o0FG/xwO
 RSZZ0VAVQ5eNC7AlXcxbDVdFkcSgwu08PmFfcbUUVdatyNRB4PE7aZDj95e9FJTa
 7+nSCe9SZ6kWNfyqdR4i36phIZYfIUicOPKY1pElkt7iUO34rWZllE74wX29wyiE
 GhV4Y/Qisca1AGMWsM+dyluCb/x1nhhLgV4XLYR/TF2I2J+Ng831VWqUQC20nNRu
 BIEeRfFkTAOpyAuBs7IxgZdBMsdVkaDwSZPs3nXNkm06NH5LSA1b8s4CZFi0l7fH
 kzMX65DHi8MAResJb6A3wz50WZNkEvclFXM7E74F/eTPbe35GdAGRP55gepJz+hy
 uJBNmn2uNIj7wg==
X-ME-Sender: <xms:bc9IWdcx90VJyBaGi0azDvcFEnX_qOFt5dERulbUBjWVg3bpTAQ52Q>
X-Sasl-enc: yWKd+n6KthqEseJqjoni6gdcJL0Aruw8CSNGdjKT6ZJ/ 1497943916
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id D6AB024606;
 Tue, 20 Jun 2017 03:31:56 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Tiwei Bie <tiwei.bie@intel.com>
Cc: dev@dpdk.org, jingjing.wu@intel.com, wenzhuo.lu@intel.com
Date: Tue, 20 Jun 2017 09:31:56 +0200
Message-ID: <12382784.Ehh86DCXep@xps>
In-Reply-To: <20170620065322.GA12786@debian-ZGViaWFuCg>
References: <20170615110221.1395-1-thomas@monjalon.net>
 <20170620065322.GA12786@debian-ZGViaWFuCg>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: always build VF and MACsec
	functions
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Jun 2017 07:31:57 -0000

20/06/2017 08:53, Tiwei Bie:
> On Thu, Jun 15, 2017 at 01:02:21PM +0200, Thomas Monjalon wrote:
> > These functions are supported only on ixgbe.
> [...]
> > @@ -3013,15 +3013,21 @@ set_vf_traffic(portid_t port_id, uint8_t is_rx, uint16_t vf, uint8_t on)
> >  
> >  	if (diag == 0)
> >  		return;
> > -	if(is_rx)
> > +	if(is_rx) {
> 
> It's better to also fix this coding style issue.

Yes you're right.
Will fix it when applying, thanks.