* [dpdk-dev] [PATCH] ethdev: remove device-specific comments from VLAN API
@ 2020-08-04 9:41 Thomas Monjalon
2020-08-04 9:48 ` [dpdk-dev] [PATCH v2] " Thomas Monjalon
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Monjalon @ 2020-08-04 9:41 UTC (permalink / raw)
To: dev; +Cc: Ferruh Yigit, Andrew Rybchenko
Some confusing comments were still present from old days,
when most drivers were from Intel.
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
lib/librte_ethdev/rte_ethdev.h | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
index 57e4a6ca58..2df4d34d0d 100644
--- a/lib/librte_ethdev/rte_ethdev.h
+++ b/lib/librte_ethdev/rte_ethdev.h
@@ -2846,7 +2846,6 @@ int rte_eth_dev_vlan_filter(uint16_t port_id, uint16_t vlan_id, int on);
/**
* Enable/Disable hardware VLAN Strip by a rx queue of an Ethernet device.
- * 82599/X540/X550 can support VLAN stripping at the rx queue level
*
* @param port_id
* The port identifier of the Ethernet device.
@@ -2868,8 +2867,7 @@ int rte_eth_dev_set_vlan_strip_on_queue(uint16_t port_id, uint16_t rx_queue_id,
/**
* Set the Outer VLAN Ether Type by an Ethernet device, it can be inserted to
- * the VLAN Header. This is a register setup available on some Intel NIC, not
- * but all, please check the data sheet for availability.
+ * the VLAN header.
*
* @param port_id
* The port identifier of the Ethernet device.
@@ -2888,12 +2886,7 @@ int rte_eth_dev_set_vlan_ether_type(uint16_t port_id,
uint16_t tag_type);
/**
- * Set VLAN offload configuration on an Ethernet device
- * Enable/Disable Extended VLAN by an Ethernet device, This is a register setup
- * available on some Intel NIC, not but all, please check the data sheet for
- * availability.
- * Enable/Disable VLAN Strip can be done on rx queue for certain NIC, but here
- * the configuration is applied on the port level.
+ * Set VLAN offload configuration on an Ethernet device.
*
* @param port_id
* The port identifier of the Ethernet device.
--
2.27.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-dev] [PATCH v2] ethdev: remove device-specific comments from VLAN API
2020-08-04 9:41 [dpdk-dev] [PATCH] ethdev: remove device-specific comments from VLAN API Thomas Monjalon
@ 2020-08-04 9:48 ` Thomas Monjalon
2020-08-05 9:19 ` David Marchand
2020-08-05 11:27 ` Andrew Rybchenko
0 siblings, 2 replies; 6+ messages in thread
From: Thomas Monjalon @ 2020-08-04 9:48 UTC (permalink / raw)
To: dev; +Cc: Ferruh Yigit, Andrew Rybchenko
Some confusing comments were still present from old days,
when most drivers were from Intel.
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
v2: remove i40e comment for pvid field
---
lib/librte_ethdev/rte_ethdev.h | 12 ++----------
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
index 57e4a6ca58..d29930fd84 100644
--- a/lib/librte_ethdev/rte_ethdev.h
+++ b/lib/librte_ethdev/rte_ethdev.h
@@ -924,7 +924,6 @@ struct rte_eth_txmode {
*/
uint64_t offloads;
- /* For i40e specifically */
uint16_t pvid;
__extension__
uint8_t hw_vlan_reject_tagged : 1,
@@ -2846,7 +2845,6 @@ int rte_eth_dev_vlan_filter(uint16_t port_id, uint16_t vlan_id, int on);
/**
* Enable/Disable hardware VLAN Strip by a rx queue of an Ethernet device.
- * 82599/X540/X550 can support VLAN stripping at the rx queue level
*
* @param port_id
* The port identifier of the Ethernet device.
@@ -2868,8 +2866,7 @@ int rte_eth_dev_set_vlan_strip_on_queue(uint16_t port_id, uint16_t rx_queue_id,
/**
* Set the Outer VLAN Ether Type by an Ethernet device, it can be inserted to
- * the VLAN Header. This is a register setup available on some Intel NIC, not
- * but all, please check the data sheet for availability.
+ * the VLAN header.
*
* @param port_id
* The port identifier of the Ethernet device.
@@ -2888,12 +2885,7 @@ int rte_eth_dev_set_vlan_ether_type(uint16_t port_id,
uint16_t tag_type);
/**
- * Set VLAN offload configuration on an Ethernet device
- * Enable/Disable Extended VLAN by an Ethernet device, This is a register setup
- * available on some Intel NIC, not but all, please check the data sheet for
- * availability.
- * Enable/Disable VLAN Strip can be done on rx queue for certain NIC, but here
- * the configuration is applied on the port level.
+ * Set VLAN offload configuration on an Ethernet device.
*
* @param port_id
* The port identifier of the Ethernet device.
--
2.27.0
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH v2] ethdev: remove device-specific comments from VLAN API
2020-08-04 9:48 ` [dpdk-dev] [PATCH v2] " Thomas Monjalon
@ 2020-08-05 9:19 ` David Marchand
2020-08-05 11:27 ` Andrew Rybchenko
1 sibling, 0 replies; 6+ messages in thread
From: David Marchand @ 2020-08-05 9:19 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev, Ferruh Yigit, Andrew Rybchenko
On Tue, Aug 4, 2020 at 11:48 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> Some confusing comments were still present from old days,
> when most drivers were from Intel.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> v2: remove i40e comment for pvid field
> ---
> lib/librte_ethdev/rte_ethdev.h | 12 ++----------
> 1 file changed, 2 insertions(+), 10 deletions(-)
>
> diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
> index 57e4a6ca58..d29930fd84 100644
> --- a/lib/librte_ethdev/rte_ethdev.h
> +++ b/lib/librte_ethdev/rte_ethdev.h
> @@ -924,7 +924,6 @@ struct rte_eth_txmode {
> */
> uint64_t offloads;
>
> - /* For i40e specifically */
> uint16_t pvid;
> __extension__
> uint8_t hw_vlan_reject_tagged : 1,
> @@ -2846,7 +2845,6 @@ int rte_eth_dev_vlan_filter(uint16_t port_id, uint16_t vlan_id, int on);
>
> /**
> * Enable/Disable hardware VLAN Strip by a rx queue of an Ethernet device.
> - * 82599/X540/X550 can support VLAN stripping at the rx queue level
> *
> * @param port_id
> * The port identifier of the Ethernet device.
> @@ -2868,8 +2866,7 @@ int rte_eth_dev_set_vlan_strip_on_queue(uint16_t port_id, uint16_t rx_queue_id,
>
> /**
> * Set the Outer VLAN Ether Type by an Ethernet device, it can be inserted to
> - * the VLAN Header. This is a register setup available on some Intel NIC, not
> - * but all, please check the data sheet for availability.
> + * the VLAN header.
> *
> * @param port_id
> * The port identifier of the Ethernet device.
> @@ -2888,12 +2885,7 @@ int rte_eth_dev_set_vlan_ether_type(uint16_t port_id,
> uint16_t tag_type);
>
> /**
> - * Set VLAN offload configuration on an Ethernet device
> - * Enable/Disable Extended VLAN by an Ethernet device, This is a register setup
> - * available on some Intel NIC, not but all, please check the data sheet for
> - * availability.
> - * Enable/Disable VLAN Strip can be done on rx queue for certain NIC, but here
> - * the configuration is applied on the port level.
> + * Set VLAN offload configuration on an Ethernet device.
> *
> * @param port_id
> * The port identifier of the Ethernet device.
Reviewed-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH v2] ethdev: remove device-specific comments from VLAN API
2020-08-04 9:48 ` [dpdk-dev] [PATCH v2] " Thomas Monjalon
2020-08-05 9:19 ` David Marchand
@ 2020-08-05 11:27 ` Andrew Rybchenko
2020-08-05 16:57 ` Ferruh Yigit
1 sibling, 1 reply; 6+ messages in thread
From: Andrew Rybchenko @ 2020-08-05 11:27 UTC (permalink / raw)
To: Thomas Monjalon, dev; +Cc: Ferruh Yigit
On 8/4/20 12:48 PM, Thomas Monjalon wrote:
> Some confusing comments were still present from old days,
> when most drivers were from Intel.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH v2] ethdev: remove device-specific comments from VLAN API
2020-08-05 11:27 ` Andrew Rybchenko
@ 2020-08-05 16:57 ` Ferruh Yigit
2020-08-05 18:02 ` Thomas Monjalon
0 siblings, 1 reply; 6+ messages in thread
From: Ferruh Yigit @ 2020-08-05 16:57 UTC (permalink / raw)
To: Andrew Rybchenko, Thomas Monjalon, dev
On 8/5/2020 12:27 PM, Andrew Rybchenko wrote:
> On 8/4/20 12:48 PM, Thomas Monjalon wrote:
>> Some confusing comments were still present from old days,
>> when most drivers were from Intel.
>>
>> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>
> Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH v2] ethdev: remove device-specific comments from VLAN API
2020-08-05 16:57 ` Ferruh Yigit
@ 2020-08-05 18:02 ` Thomas Monjalon
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2020-08-05 18:02 UTC (permalink / raw)
To: dev; +Cc: Andrew Rybchenko, Ferruh Yigit, david.marchand
05/08/2020 18:57, Ferruh Yigit:
> On 8/5/2020 12:27 PM, Andrew Rybchenko wrote:
> > On 8/4/20 12:48 PM, Thomas Monjalon wrote:
> >> Some confusing comments were still present from old days,
> >> when most drivers were from Intel.
> >>
> >> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-08-05 18:02 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-04 9:41 [dpdk-dev] [PATCH] ethdev: remove device-specific comments from VLAN API Thomas Monjalon
2020-08-04 9:48 ` [dpdk-dev] [PATCH v2] " Thomas Monjalon
2020-08-05 9:19 ` David Marchand
2020-08-05 11:27 ` Andrew Rybchenko
2020-08-05 16:57 ` Ferruh Yigit
2020-08-05 18:02 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).