From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F2DB3A0350; Wed, 1 Jul 2020 16:30:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 63F021C23C; Wed, 1 Jul 2020 16:30:11 +0200 (CEST) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by dpdk.org (Postfix) with ESMTP id 863901C22E for ; Wed, 1 Jul 2020 16:30:10 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 45AB29F7; Wed, 1 Jul 2020 10:30:09 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Wed, 01 Jul 2020 10:30:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= yHmjtzlTMY8TxcjkSRJDbx5WfowRBXLPnNhpPRfE2XQ=; b=VtuOH9KBXgVNC5/1 iIhKAhxZqjxnft9GOybYS5d2yaftIlEX26JMfEWtxUpgkjsOKzWNkNds5wuNHL3r /C0zKmnyAoaoaB7TCu8qaxjDnlpVRkPtSYZ0lukuHmJM3Aw61T2KvuK8+GJfahMc 9r8uKJPCz1GQTUI0nWe1ghUUF1g0Q1MBiYVsAcMSxVx0bVxiOblP6Q1fX1iJHJL+ R4VA6JlxFPrC7VD60nmCrFbP6GABxuysMJMh9Z/0o6KYI5bA+c0euOdUvzT6+Gy0 JGkL4t+lbJOPoHV/z6VAv+Rn8yR9LpgqKdyKtNNHSTLbAv22cHJTnJM5+9s1ftdp dF2ChQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=yHmjtzlTMY8TxcjkSRJDbx5WfowRBXLPnNhpPRfE2 XQ=; b=SJ2W1kS9eGo9eM2+gPP2FkHQWCLO2zKv9NkozIgWsPz93YbC8RkeafWsu n7LFWbw1eJTBe5xB1k227SZ1J/ZqiU4xEPCr3RIbgD3eWB3q006ZUXT+4iNFcQ6Y 7BOeEjVE1dXdAQqNxzciekabYMYIu9SNtI4Ot7aXmLvwJflNen6FX3MX4d7jb86C KTuuKS6L3RA8E6mooxYjTmkSwTx/Wyp2J9b4lqidQQxP7aaG6oUgC1x7YUxNQvwI qoUvL+MqyyOXRBLEzyZ9B4DxdA6o3BegaZVLz2DubYvk4GcPB8s4oDv42OHiFyJp BRG6e/9piTSuD0c1jqHxV/uVohb3Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrtddvgdejkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 8F1AD3060064; Wed, 1 Jul 2020 10:30:07 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, david.marchand@redhat.com, ktraynor@redhat.com, bluca@debian.org, sunil.pai.g@intel.com Date: Wed, 01 Jul 2020 16:30:05 +0200 Message-ID: <12416796.FDjNEWGfuk@thomas> In-Reply-To: <20200630141433.818517-7-bruce.richardson@intel.com> References: <20200429100831.398-1-bruce.richardson@intel.com> <20200630141433.818517-1-bruce.richardson@intel.com> <20200630141433.818517-7-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 6/7] build/pkg-config: improve static linking flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 30/06/2020 16:14, Bruce Richardson: > Rather than setting -Bstatic in the linker flags when doing a static link, > and then having to explicitly set -Bdynamic again afterwards, we can update > the pkg-config file to use -l:libfoo.a syntax to explicitly refer to the > static library in question. Since this syntax is not supported by meson's > pkg-config module directly, we can post-process the .pc files instead to > adjust them. > > Once done, we can simplify the examples' makefiles and the docs by removing > the explicit static flag. > > Signed-off-by: Bruce Richardson > Acked-by: Luca Boccassi > Acked-by: Sunil Pai G > --- > --- a/buildtools/pkg-config/meson.build > +++ b/buildtools/pkg-config/meson.build > +# the pkg-config file generated is not best tuned for static linking so > +# use a script to adjust the linker flags > +run_command(py3, 'set-static-linker-flags.py', check: true) The comment could be made more precise: # For static linking with dependencies as shared libraries, # the static libraries must be flagged explicitly. For the rest, Acked-by: Thomas Monjalon