* [dpdk-dev] [PATCH] common/octeontx2: cleanup void returns
@ 2019-07-08 12:18 kkanas
2019-07-08 13:29 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: kkanas @ 2019-07-08 12:18 UTC (permalink / raw)
To: dev, Jerin Jacob, Nithin Dabilpuram, Vamsi Attunuru; +Cc: Krzysztof Kanas
From: Krzysztof Kanas <kkanas@marvell.com>
mbox_unregister_vf_irq and mbox_unregister_pf_irq returns void value.
mbox_unregister_irq also returns void.
Clang with flags '-Wall -Wextra -pedantic' complains about:
void function should not return void expression
Signed-off-by: Krzysztof Kanas <kkanas@marvell.com>
---
drivers/common/octeontx2/otx2_dev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/common/octeontx2/otx2_dev.c b/drivers/common/octeontx2/otx2_dev.c
index 53a0c6efbcbc..3b51fa93ad29 100644
--- a/drivers/common/octeontx2/otx2_dev.c
+++ b/drivers/common/octeontx2/otx2_dev.c
@@ -744,9 +744,9 @@ static void
mbox_unregister_irq(struct rte_pci_device *pci_dev, struct otx2_dev *dev)
{
if (otx2_dev_is_vf(dev))
- return mbox_unregister_vf_irq(pci_dev, dev);
+ mbox_unregister_vf_irq(pci_dev, dev);
else
- return mbox_unregister_pf_irq(pci_dev, dev);
+ mbox_unregister_pf_irq(pci_dev, dev);
}
static int
--
2.21.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] common/octeontx2: cleanup void returns
2019-07-08 12:18 [dpdk-dev] [PATCH] common/octeontx2: cleanup void returns kkanas
@ 2019-07-08 13:29 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2019-07-08 13:29 UTC (permalink / raw)
To: kkanas; +Cc: dev, Jerin Jacob, Nithin Dabilpuram, Vamsi Attunuru
08/07/2019 14:18, kkanas@marvell.com:
> From: Krzysztof Kanas <kkanas@marvell.com>
>
> mbox_unregister_vf_irq and mbox_unregister_pf_irq returns void value.
> mbox_unregister_irq also returns void.
>
> Clang with flags '-Wall -Wextra -pedantic' complains about:
> void function should not return void expression
>
> Signed-off-by: Krzysztof Kanas <kkanas@marvell.com>
Applied, thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-08 13:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-08 12:18 [dpdk-dev] [PATCH] common/octeontx2: cleanup void returns kkanas
2019-07-08 13:29 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).