From: Thomas Monjalon <thomas@monjalon.net>
To: Andrius Sirvys <andrius.sirvys@intel.com>
Cc: dev@dpdk.org, Kevin Laatz <kevin.laatz@intel.com>,
stable@dpdk.org, harry.van.haaren@intel.com,
cian.ferriter@intel.com, herakliusz.lipiec@intel.com
Subject: Re: [dpdk-dev] [PATCH v3] usertools: fix input handling in telemetry script
Date: Thu, 08 Aug 2019 17:32:42 +0200 [thread overview]
Message-ID: <12433889.H1ufI3jC0d@xps> (raw)
In-Reply-To: <20190808143753.16788-1-andrius.sirvys@intel.com>
08/08/2019 16:37, Andrius Sirvys:
> This commit removes the unnecesarry ast.literal_eval() function call
> from the input handling, which now relies just on raw_input() to get
> its input.
>
> Fixes: 53f293c9a783 ("usertools: replace unsafe input function")
> Cc: andrius.sirvys@intel.com
>
> Signed-off-by: Andrius Sirvys <andrius.sirvys@intel.com>
> ---
> v2: Removed unnecessary comments
> v3: Reduced scope of changes only to required Python 2 fix
>
> Please note that the dpdk-telemetry-client.py script has a number of
> issues with Python3 support. Fixing Python3 support is being deferred
> to DPDK 19.11 release.
OK, hope it will be good enough for 19.08.
Applied, thanks
prev parent reply other threads:[~2019-08-08 15:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-07 13:04 [dpdk-dev] [PATCH v2] usertools: dpdk-telemetry-client.py run into looping status Andrius Sirvys
2019-08-08 7:17 ` Thomas Monjalon
2019-08-08 14:37 ` [dpdk-dev] [PATCH v3] usertools: fix input handling in telemetry script Andrius Sirvys
2019-08-08 15:32 ` Van Haaren, Harry
2019-08-08 15:32 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12433889.H1ufI3jC0d@xps \
--to=thomas@monjalon.net \
--cc=andrius.sirvys@intel.com \
--cc=cian.ferriter@intel.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=herakliusz.lipiec@intel.com \
--cc=kevin.laatz@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).