From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 11DE5A00E6 for ; Thu, 8 Aug 2019 17:32:54 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D5E881BE7B; Thu, 8 Aug 2019 17:32:53 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id AD89C1BE74; Thu, 8 Aug 2019 17:32:52 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 5719421B4C; Thu, 8 Aug 2019 11:32:52 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 08 Aug 2019 11:32:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=YU4052uhIusZiAKDP36c8vDJ+k2t+1UIcgJk0wx60Tg=; b=jmRpa+F/yMHP 1rUby32Vp5a+GRJQeo2BQcZhKWSPfRLhNEm+u0CMdY1FcODiT6nrrWeZflrJj/6C gZds/huukuPYICLMrDqnbedfTabEKBcAI3UUe/pfKuKO94W+Eipvm0j69xJeQSSf EAaJFo78g1hzQCm7oSkanv4rWEhIV9U= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=YU4052uhIusZiAKDP36c8vDJ+k2t+1UIcgJk0wx60 Tg=; b=Nbo7UoY8gQf7uuuq0yiE6xzFnCko+vlPmELJ7ihuSkpxH6TWHiMJ8/KTP g2UyNw5QJAAQc9kvTc5ocm2WVqEoMBGNmn2lzZEp9dwc6Hp3e7jCl3cs+RCd5zMM XBzi3+Y4Ym7vyU9e5vChUB0qAKuGBDNRvmOl3Nt/mW4qI8dzhaj1HNl6K8USelPT cfNdJgI7R3kgv0ru5+MEQqBmsec4D7IPNwI57QFMjncojO72UmebbL4xLps324zD ipKHyWT8CUWM+2KlbJhiIOxQ+zrMx9AoNhTDb1BatJip6dn83rLnCREZsZqOKNkV wzxsfOvq2O+ELTSb2dmSfdOhOuvbA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrudduhedgledtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeelfedrvdefrddutdeirdefudenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhm rghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (31.106.23.93.rev.sfr.net [93.23.106.31]) by mail.messagingengine.com (Postfix) with ESMTPA id 7BC1F380075; Thu, 8 Aug 2019 11:32:48 -0400 (EDT) From: Thomas Monjalon To: Andrius Sirvys Cc: dev@dpdk.org, Kevin Laatz , stable@dpdk.org, harry.van.haaren@intel.com, cian.ferriter@intel.com, herakliusz.lipiec@intel.com Date: Thu, 08 Aug 2019 17:32:42 +0200 Message-ID: <12433889.H1ufI3jC0d@xps> In-Reply-To: <20190808143753.16788-1-andrius.sirvys@intel.com> References: <20190807130458.16754-1-andrius.sirvys@intel.com> <20190808143753.16788-1-andrius.sirvys@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] usertools: fix input handling in telemetry script X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 08/08/2019 16:37, Andrius Sirvys: > This commit removes the unnecesarry ast.literal_eval() function call > from the input handling, which now relies just on raw_input() to get > its input. > > Fixes: 53f293c9a783 ("usertools: replace unsafe input function") > Cc: andrius.sirvys@intel.com > > Signed-off-by: Andrius Sirvys > --- > v2: Removed unnecessary comments > v3: Reduced scope of changes only to required Python 2 fix > > Please note that the dpdk-telemetry-client.py script has a number of > issues with Python3 support. Fixing Python3 support is being deferred > to DPDK 19.11 release. OK, hope it will be good enough for 19.08. Applied, thanks