From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D0EE5A053C; Thu, 6 Feb 2020 16:15:14 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 44B801C135; Thu, 6 Feb 2020 16:15:14 +0100 (CET) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by dpdk.org (Postfix) with ESMTP id 048F11C133; Thu, 6 Feb 2020 16:15:13 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id AA40B432; Thu, 6 Feb 2020 10:15:10 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 06 Feb 2020 10:15:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=zzKsVSBQq7Wp8c8DVPes69UWo43Uktv3h3ArqbHG3bg=; b=NqH0MGI1Cydf BL8P/nYU4WfvFDtgX0vycFnZ+2oMQ58ObE2lXi8R9JfleBpXxnvkXe5gay6UXNda R6Z8/Dz4DUhxF+NnTPc/52x3/p+Jrm9VPWCdRmoCs1zurw0c6uP+6GiXen3xkQGP DYCuxnxJ/x8wLgu8VxTkGbl2//LY7Zs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=zzKsVSBQq7Wp8c8DVPes69UWo43Uktv3h3ArqbHG3 bg=; b=zGRXp5OP/pd3Ab4ENneMJuVwJHewRSlFDbtrjczfwcPQ5JONxmLlFffCF EkChxF0FSKjJaUP/N8UceYLeLPL8/SAoiHjolI2pfnbWJviXRJeaU8aReoDTwy09 3f0ZbTEaX7BQ3xNzwrubJ94yzjIceY5ZN/W/EHCRZKilxUxRZpVGq6NoFjNPvx37 PJX1KWmLSMbbwKaQnBlwjjBa2bmVs8lm1WuFutje91+AsEE9QKPiddEH9MCuiUd2 RiiD1Q31PtqvXOYjJQmutd9/Jvc1Sg0q2hSMXlB8/72QQceqaW1+QFC3szIqGxEg iZyBQ1fOXmJ/xo4Hfymy1pIQleVpw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrheefgdejfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 595083280066; Thu, 6 Feb 2020 10:15:09 -0500 (EST) From: Thomas Monjalon To: Vladimir Medvedkin Cc: dev@dpdk.org, stable@dpdk.org Date: Thu, 06 Feb 2020 16:15:08 +0100 Message-ID: <12449795.y0N7aAr316@xps> In-Reply-To: <1579619229-75215-1-git-send-email-vladimir.medvedkin@intel.com> References: <1579022312-396072-1-git-send-email-vladimir.medvedkin@intel.com> <1579619229-75215-1-git-send-email-vladimir.medvedkin@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] fib: fix possible integer overflow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 21/01/2020 16:07, Vladimir Medvedkin: > This commit fixes possible integer overflow for > prev_idx in build_common_root() CID 350596 > and > tbl8_idx in write_edge() CID 350597 > > Unintentional integer overflow (OVERFLOW_BEFORE_WIDEN) > overflow_before_widen: Potentially overflowing expression tbl8_idx * 256 > with type int (32 bits, signed) is evaluated using 32-bit arithmetic, > and then used in a context that expects an expression of > type uint64_t (64 bits, unsigned). > > Coverity issue: 350596, 350597 > Fixes: c3e12e0f0354 ("fib: add dataplane algorithm for IPv6") > Cc: vladimir.medvedkin@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Vladimir Medvedkin Applied, thanks