From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5882CA052A; Thu, 26 Nov 2020 15:04:57 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 14EB0C97A; Thu, 26 Nov 2020 15:04:55 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id D1355C938; Thu, 26 Nov 2020 15:04:52 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 369D05C0110; Thu, 26 Nov 2020 09:04:51 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 26 Nov 2020 09:04:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= IbtIiLWeXI+vFoiq+Ryxo2xFRiuIft6PZYucLBKZaSk=; b=tlY1jm5e51qArBcZ yZ/IWe5mEDnhBsRTLhUTC9cE11ZcuJ7VP4E9zfqbthNTbJLEMKurLtadBfxzptbn 2wQxZnmdNAVmi73Q530lZb71WLcVOJ+Ba6dlNZiXJUq7XihrlzeCKtP4H9caH8Hq cVMLo/evqWgqneBR0A7DhX+p6yLYETuov5e2PRaLCf9EA/3uspNAT/q8sg71+761 74cf3kNK66u6PN8bkQrIUiI3qJlQ6kfJB4KoundsVvGHCPGOrQz3+10w3fUJQ+Zt f0TIC9hRxv8t0VvE9K+CCGr5tT1mAjzq6ctyVIGc0+opX70kRUiVZUk4LQxcxmfI sF9clg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=IbtIiLWeXI+vFoiq+Ryxo2xFRiuIft6PZYucLBKZa Sk=; b=rFKyd+uiUnEEmxl1fAsUDkl3n5BwPHms/FolxGkAhajkrYi9blemKjWvA ku76KKYrTn2NLoB9LQhdRRfICgNoEpEMVAm/MGuLmEdNNKT3RezB23YWqkzV4PXr o438CetapJrA8XTJ3CCs0lfwaD/j+Vs/se3Fr4m4cE28NQUitCSIBLOJka3TuygR iyYLjMyi4EJlyz+QUGJvASDs1SGKq45NoxzUXm/WVwWd+wbyEUXHlZvFrHOc716y P+9aSpm6GkzkoHvfDuaOTK9H1v6+zc67b5TxKr6oRAbCRosUimJFjtF8lzioQQSf 6QdvLxfBbsarHXfTy81WjsuF57MGQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudehvddgiedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 407BB3280067; Thu, 26 Nov 2020 09:04:49 -0500 (EST) From: Thomas Monjalon To: "Walsh, Conor" Cc: "Yigit, Ferruh" , "dev@dpdk.org" , "techboard@dpdk.org" , Stephen Hemminger , "Richardson, Bruce" Date: Thu, 26 Nov 2020 15:04:47 +0100 Message-ID: <12453683.mZJSUfSEK2@thomas> In-Reply-To: References: <20201125191908.1867106-1-ferruh.yigit@intel.com> <20201125191908.1867106-4-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 3/6] usertools/setup: remove running built applications X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 26/11/2020 15:02, Walsh, Conor: > Hi Ferruh, > > Patch tested. > > Thanks, > Conor. > > > -----Original Message----- > > From: dev On Behalf Of Ferruh Yigit > > Sent: Wednesday 25 November 2020 19:19 > > To: Thomas Monjalon > > Cc: Yigit, Ferruh ; dev@dpdk.org; > > techboard@dpdk.org; Stephen Hemminger > > ; Richardson, Bruce > > > > Subject: [dpdk-dev] [PATCH 3/6] usertools/setup: remove running built > > applications > > > > Running application relies on make based build variable 'RTE_TARGET' to > > find the location of the applications, which is not valid anymore. > > > > Signed-off-by: Ferruh Yigit > > Tested-by: Conor Walsh Hi Conor, If no comment on code below, you can remove the below lines from your reply. Thanks > > > --- > > usertools/dpdk-setup.sh | 52 ++--------------------------------------- > > 1 file changed, 2 insertions(+), 50 deletions(-) > > > > diff --git a/usertools/dpdk-setup.sh b/usertools/dpdk-setup.sh > > index bcf0c843678f..759f6c096536 100755 > > --- a/usertools/dpdk-setup.sh > > +++ b/usertools/dpdk-setup.sh > > @@ -17,11 +17,6 @@ echo "----------------------------------------------------------- > > --------------- > > > > HUGEPGSZ=`cat /proc/meminfo | grep Hugepagesize | cut -d : -f 2 | tr -d ' '` > > > > -# > > -# Application EAL parameters for setting memory options > > (amount/channels/ranks). > > -# > > -EAL_PARAMS='-n 4' > > - > > # > > # Sets QUIT variable so script will finish. > > # > > @@ -252,34 +247,6 @@ set_numa_pages() > > create_mnt_huge > > } > > > > -# > > -# Run unit test application. > > -# > > -run_test_app() > > -{ > > - echo "" > > - echo " Enter hex bitmask of cores to execute test app on" > > - echo " Example: to execute app on cores 0 to 7, enter 0xff" > > - echo -n "bitmask: " > > - read Bitmask > > - echo "Launching app" > > - sudo ${RTE_TARGET}/app/test -c $Bitmask $EAL_PARAMS > > -} > > - > > -# > > -# Run unit testpmd application. > > -# > > -run_testpmd_app() > > -{ > > - echo "" > > - echo " Enter hex bitmask of cores to execute testpmd app on" > > - echo " Example: to execute app on cores 0 to 7, enter 0xff" > > - echo -n "bitmask: " > > - read Bitmask > > - echo "Launching app" > > - sudo ${RTE_TARGET}/app/testpmd -c $Bitmask $EAL_PARAMS -- -i > > -} > > - > > # > > # Print hugepage information. > > # > > @@ -381,24 +348,10 @@ step1_func() > > FUNC[7]="set_vfio_permissions" > > } > > > > -# > > -# Options for running applications. > > -# > > -step2_func() > > -{ > > - TITLE="Run test application for linux environment" > > - > > - TEXT[1]="Run test application (\$RTE_TARGET/app/test)" > > - FUNC[1]="run_test_app" > > - > > - TEXT[2]="Run testpmd application in interactive mode > > (\$RTE_TARGET/app/testpmd)" > > - FUNC[2]="run_testpmd_app" > > -} > > - > > # > > # Other options > > # > > -step3_func() > > +step2_func() > > { > > TITLE="Other tools" > > > > @@ -410,7 +363,7 @@ step3_func() > > # > > # Options for cleaning up the system > > # > > -step4_func() > > +step3_func() > > { > > TITLE="Uninstall and system cleanup" > > > > @@ -433,7 +386,6 @@ step4_func() > > STEPS[1]="step1_func" > > STEPS[2]="step2_func" > > STEPS[3]="step3_func" > > -STEPS[4]="step4_func" > > > > QUIT=0 > > > > -- > > 2.26.2 > >