From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f52.google.com (mail-wg0-f52.google.com [74.125.82.52])
 by dpdk.org (Postfix) with ESMTP id 945BDB38D
 for <dev@dpdk.org>; Fri, 29 May 2015 20:41:17 +0200 (CEST)
Received: by wgez8 with SMTP id z8so69862763wge.0
 for <dev@dpdk.org>; Fri, 29 May 2015 11:41:17 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=JPQewwymMZtjoAv0998mxB6r1Hz6A3KEAe7GCI3V0Q4=;
 b=RL77qjtxUJikTJBYa1Pz3gkbPfRGg/Xs1ZTDr8Dd25xwcuCir2+2OXzHvaN6piPG9s
 EltS67z9dFtnQxU+fftDW3DcKfBeBWTGz8XWqKrt7wwOONZmrJOEbSqNvT4YTpuxwvQJ
 FZf2FQbSjs8os3L4irS4nwCoXXBNo9p/aXp6GZoYSW0yfO9y0Ao5POkBx3wp9R+qJcUU
 Y4jZ6VjHwZg58jMr/ROFwttF3mLmBPe+SUBZE0v6TH1USblwNXIvPiNMI55BI+ag+W/i
 HjO0x4dr1Kd4o/3l5gvW7wEU1RmXBPAFlj44MHTDjo1m20yIKNvlQTiJrcub3UGW4Tz5
 u5DA==
X-Gm-Message-State: ALoCoQnuImO3hwL7XuACahTm4elwCSCfLtKdiGhECMabcjVFN8lMJgfsgryqrtkXeL3hCfTpkN2J
X-Received: by 10.180.100.74 with SMTP id ew10mr9376080wib.12.1432924877499;
 Fri, 29 May 2015 11:41:17 -0700 (PDT)
Received: from xps13.localnet (166.16.90.92.rev.sfr.net. [92.90.16.166])
 by mx.google.com with ESMTPSA id v3sm4276589wiz.14.2015.05.29.11.41.06
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 29 May 2015 11:41:16 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Erik Ziegenbalg <eziegenb@brocade.com>
Date: Fri, 29 May 2015 19:42:35 +0200
Message-ID: <12488353.7GeDSJAbkN@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.7 (Linux/4.0.1-1-ARCH; KDE/4.14.7; x86_64; ; )
In-Reply-To: <1432080295-8972-1-git-send-email-eziegenb@brocade.com>
References: <1432080295-8972-1-git-send-email-eziegenb@brocade.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] Mem: Fixes small memory leak due to
	missing free.
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 29 May 2015 18:41:17 -0000

2015-05-19 17:04, Erik Ziegenbalg:
> From: eziegenb <eziegenb@brocade.com>
> 
> A function in cmdline.c has a return that does not free buf properly.
> 
> Signed-off-by: Erik Ziegenbalg <eziegenb@brocade.com>

You forgot to add a changelog and the previous acked-by:
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: John McNamara <john.mcnamara@intel.com>

> -	if (ret < 0)
> +	if (ret < 0){

checkpatch complains about a missing space.

Applied with the above fix, thanks