From: Thomas Monjalon <thomas@monjalon.net> To: Ferruh Yigit <ferruh.yigit@intel.com> Cc: dev@dpdk.org, Joe Perches <joe@perches.com>, stephen@networkplumber.org Subject: Re: [dpdk-dev] [PATCH 2/2] devtools: disable fixes authors in get maintainers Date: Tue, 02 Nov 2021 12:28:20 +0100 Message-ID: <12489504.UicEPBppVI@thomas> (raw) In-Reply-To: <1f940709-5b29-3a80-6966-8938d5034f3d@intel.com> 02/11/2021 11:04, Ferruh Yigit: > On 11/1/2021 10:20 PM, Thomas Monjalon wrote: > > 01/11/2021 14:35, Ferruh Yigit: > >> 'get_maintainer.pl' by default returns authors that has fixes in > >> relevant code, to reduce the output only maintainers from MAINTAINERS > >> file, disabling fixes authors, by making '--no-fixes' default. > > > > Do you mean it is not Cc'ing people who have contributed to the file? > > Is it keeping Cc of people having contributed to the commit being fixed? > > > > It is adding both, people contributed to the file and contributed to the commit > it is fixing. More details from tool is below [1]. > > Intention to cc'ing the people who introduced the commit you are fixing > makes sense. > But as far as I can see it adds all xxx-by names from the fix commit, not > just author, that may add some unrelated people. > > Let me give a sample: > Commit A: ("ethdev: add namespace") > It updates bunch of drivers and it has acks from various > driver maintainers. > > Commit B: ("net/txgbe: fix link macro") > Fixing Commit A for one driver (txgbe) > > If --fixes is used on 'Commit B', the author of 'Commit A' and all people > acked 'Commit A' is added. But none of the acks were related to 'Commit B'. > So as a result unrelated people cc'ed for 'Commit B'. > > > If the commit and fix commit are more narrow scope, this make sense. > So we may prefer to keep '--fixes' if we are OK to some noises in some cases. Yes I prefer Cc'ing everybody. In case where the people are not needed for sure, I don't use the script. > [1] > From 'get_maintainer.pl': > --fixes => for patches, add signatures of commits with 'Fixes: <commit>' (default: 1 (on)) > > > And form commit log that adding the feature: > 2f5bd343694e ("scripts/get_maintainer.pl: add signatures from Fixes: <badcommit> lines in commit message") > > A Fixes: lines in a commit message generally indicate that a previous > commit was inadequate for whatever reason. > > The signers of the previous inadequate commit should also be cc'd on > this new commit so update get_maintainer to find the old commit and add > the original signers. >
next prev parent reply other threads:[~2021-11-02 11:28 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-11-01 13:35 [dpdk-dev] [PATCH 1/2] devtools: remove ugly workaround from " Ferruh Yigit 2021-11-01 13:35 ` [dpdk-dev] [PATCH 2/2] devtools: disable fixes authors in " Ferruh Yigit 2021-11-01 22:20 ` Thomas Monjalon 2021-11-02 10:04 ` Ferruh Yigit 2021-11-02 11:28 ` Thomas Monjalon [this message] 2021-11-02 12:08 ` Ferruh Yigit 2021-11-01 23:19 ` Stephen Hemminger 2021-11-02 10:07 ` Ferruh Yigit 2022-01-13 11:35 ` [dpdk-dev] [PATCH 1/2] devtools: remove ugly workaround from " Thomas Monjalon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=12489504.UicEPBppVI@thomas \ --to=thomas@monjalon.net \ --cc=dev@dpdk.org \ --cc=ferruh.yigit@intel.com \ --cc=joe@perches.com \ --cc=stephen@networkplumber.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git