From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 64099A0C4E; Tue, 2 Nov 2021 12:28:26 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 44F9F40689; Tue, 2 Nov 2021 12:28:26 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 2FB5E4003F for ; Tue, 2 Nov 2021 12:28:24 +0100 (CET) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id DCE0F5C00D6; Tue, 2 Nov 2021 07:28:22 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Tue, 02 Nov 2021 07:28:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= sQwnIx2SDtS7+6hyUfY2KIYO4Pr5Smz02TxCPeFH5Sw=; b=X2p86OQl1ZgmqE6q wkMQs1illvCxBjCnMxaODVS5y0nD2o/x2ndjhv18a2fbokz1hwb1vWFP/PfksUf5 FynopSkcl4ZHS8wgYxAMFHLOFmvN2m+3vZpUe7nUGJvXc5zAD1jr5uFDQfQoC/Ye BpGEENLQaKbpcN0Mi4QGZmHHJQoLkrm71k5V0NYFhVvHDH2PTGZz6aKY/PSaPQwd 6sQAO5lvyj9iT8g2LyCQLgM+FB7FJlmBqePMvikzvZaxFbadYPX8lRLPSbx2qpI8 Ta9xHjbBbprd9IiTKSdcWr4QoinAPqb+NLHcWboBA5idjz2s0DU+07pU2CcDQNcH 6Ujthw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=sQwnIx2SDtS7+6hyUfY2KIYO4Pr5Smz02TxCPeFH5 Sw=; b=k1SIew1UpjrTn0dvin0Ss/fYeZdYL7WD2Lf1zVX4u1rb1WXTMdIFDf5Q3 ltNyNLdu27+lEjLFswhOc9PnVvuVExgvHxmkt5L00vnDmfb6EtBgXeh8BGqghZMm ye93BPmRIu6kqhJVwyapx0cctXWL6HYR1EYmVM3BnKtlHtHa50IrU67CEwxnf8M4 i/EhNHWRMzQrmH5Nl6UtmYkCvANj4lWPZMAVf2ZOuCkS3njBmTtLVCCQV4npPQC2 PIqpD8hqpKTmfLkpaV4xQRh+LReQCd/N9DrDGia3GcZnBH2qqyEhr7oVxYSX+BW/ +IrLydcfD++QylkS3PNcXGIJZmJMA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrtddtgddtfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 2 Nov 2021 07:28:21 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org, Joe Perches , stephen@networkplumber.org Date: Tue, 02 Nov 2021 12:28:20 +0100 Message-ID: <12489504.UicEPBppVI@thomas> In-Reply-To: <1f940709-5b29-3a80-6966-8938d5034f3d@intel.com> References: <20211101133533.3402007-1-ferruh.yigit@intel.com> <5473001.4jAN4JvoLB@thomas> <1f940709-5b29-3a80-6966-8938d5034f3d@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 2/2] devtools: disable fixes authors in get maintainers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 02/11/2021 11:04, Ferruh Yigit: > On 11/1/2021 10:20 PM, Thomas Monjalon wrote: > > 01/11/2021 14:35, Ferruh Yigit: > >> 'get_maintainer.pl' by default returns authors that has fixes in > >> relevant code, to reduce the output only maintainers from MAINTAINERS > >> file, disabling fixes authors, by making '--no-fixes' default. > > > > Do you mean it is not Cc'ing people who have contributed to the file? > > Is it keeping Cc of people having contributed to the commit being fixed? > > > > It is adding both, people contributed to the file and contributed to the commit > it is fixing. More details from tool is below [1]. > > Intention to cc'ing the people who introduced the commit you are fixing > makes sense. > But as far as I can see it adds all xxx-by names from the fix commit, not > just author, that may add some unrelated people. > > Let me give a sample: > Commit A: ("ethdev: add namespace") > It updates bunch of drivers and it has acks from various > driver maintainers. > > Commit B: ("net/txgbe: fix link macro") > Fixing Commit A for one driver (txgbe) > > If --fixes is used on 'Commit B', the author of 'Commit A' and all people > acked 'Commit A' is added. But none of the acks were related to 'Commit B'. > So as a result unrelated people cc'ed for 'Commit B'. > > > If the commit and fix commit are more narrow scope, this make sense. > So we may prefer to keep '--fixes' if we are OK to some noises in some cases. Yes I prefer Cc'ing everybody. In case where the people are not needed for sure, I don't use the script. > [1] > From 'get_maintainer.pl': > --fixes => for patches, add signatures of commits with 'Fixes: ' (default: 1 (on)) > > > And form commit log that adding the feature: > 2f5bd343694e ("scripts/get_maintainer.pl: add signatures from Fixes: lines in commit message") > > A Fixes: lines in a commit message generally indicate that a previous > commit was inadequate for whatever reason. > > The signers of the previous inadequate commit should also be cc'd on > this new commit so update get_maintainer to find the old commit and add > the original signers. >