From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3E45345D38; Mon, 18 Nov 2024 17:51:43 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 19BC740673; Mon, 18 Nov 2024 17:51:43 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mails.dpdk.org (Postfix) with ESMTP id 5012440290 for ; Mon, 18 Nov 2024 17:51:41 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 847AA165C; Mon, 18 Nov 2024 08:52:10 -0800 (PST) Received: from [192.168.50.107] (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 671EA3F6A8; Mon, 18 Nov 2024 08:51:39 -0800 (PST) Message-ID: <124e876a-ff72-4811-99f0-ffd49ea2f23f@arm.com> Date: Mon, 18 Nov 2024 16:51:38 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/6] dts: Remove build target config and list of devices To: Nicholas Pratte , probb@iol.unh.edu, dmarx@iol.unh.edu, jspewock@iol.unh.edu, yoan.picchi@foss.arm.com, Honnappa.Nagarahalli@arm.com, paul.szczepanek@arm.com, juraj.linkes@pantheon.tech Cc: dev@dpdk.org References: <20240613201831.9748-3-npratte@iol.unh.edu> <20240705171341.23894-4-npratte@iol.unh.edu> Content-Language: en-GB From: Luca Vizzarro In-Reply-To: <20240705171341.23894-4-npratte@iol.unh.edu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Nick, I second the comments already made. A couple of nits on top of those: On 05/07/2024 18:13, Nicholas Pratte wrote: > Remove the list of devices from the schema, as these are unuesed. > Likewise, removed build-target information since these is not currently > used, and it is unlikely to be used in the future. Adjustments to the > dts.rst are made to reflect these changes. There are no adjustments made to the dts.rst here, so it shouldn't be mentioned. > > Bugzilla ID: 1360 There should be an empty line between Signed-off-by and the metatags. > Signed-off-by: Nicholas Pratte > --- > @unique > class Compiler(StrEnum): > r"""The supported compilers of :class:`~framework.testbed_model.node.Node`\s.""" > @@ -341,28 +325,20 @@ class BuildTargetConfiguration: > The configuration used for building DPDK. > > Attributes: > - arch: The target architecture to build for. > - os: The target os to build for. > - cpu: The target CPU to build for. > compiler: The compiler executable to use. > compiler_wrapper: This string will be put in front of the compiler when > executing the build. Useful for adding wrapper commands, such as ``ccache``. > name: The name of the compiler. I am a bit confused whether you are removing `name` or not, but if you are you forgot to remove this entry from the docstring. > """ > > - arch: Architecture > - os: OS > - cpu: CPUType > compiler: Compiler > compiler_wrapper: str > - name: str