From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5C54FA0547; Fri, 30 Jul 2021 14:03:19 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C61FB40042; Fri, 30 Jul 2021 14:03:18 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id 25E7B4003F; Fri, 30 Jul 2021 14:03:17 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id B93A95C017F; Fri, 30 Jul 2021 08:03:16 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Fri, 30 Jul 2021 08:03:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= xSOmQpeVRrDa5TCrJhBqjmT8iHkI3urXzOVoEl6jRIk=; b=xpPjFyDRhi1RwhZU xFK7VU2L980w5HR2mvC+I4V1mvlPSTRhxzqPJhrf5A0QV5YwxX+f5bD61NQMDvbE rIRLYWCOolbbWFrPyGsbYa1n0+Om2ma1ws7nqq0d6zom+tsW5h3rMP2prC7UhN1M dFpxHtFlap1YmsjNQdbd7G+p7bYF2J+MvrNttLxo8GdJlhuj6UnXrE46X2vSFiVV qruzOR6AkGO+GqGXJNVm/AmXm1gbVUeJGvCuDtgZSPFEFgMRoyrjUf167/AJPACJ 84NsfYpJvXbqfq1pEpxk2Qfe8SGfF/tS7H+SMHypu6t4PbC3PtBhSRbz7BGIeC3J n6XL6w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=xSOmQpeVRrDa5TCrJhBqjmT8iHkI3urXzOVoEl6jR Ik=; b=pCnDUkYW87CxTcRidQazLKojVUGLsAcFkyR/2kFZ3BYqO4OfaX6KHfe+c K5jvuK9t6vZgVhRi/tGN3nm9wPr+N9v4AtMMTpdsmsPE6Stgx0AVmoxiYlf3/Gww ZYeaqrlrQdXlyhRQuy6ooWycHUVpWj9OtgW4FRKfX7UwVrFAzGx++NUDVXtVlnVW 9t+pbU72AJntoRpPOhSFss2iIva98IgNght1RF3LHSOeF38AnF+fsNmK6aN36P3/ J/JULg6ncg0we1z0VISeLF9km6hgDdtglOA4dSYqqhAQ5bXiVnw0Hx/NZMcLs6FR CJLWQoQhR1t01iqT95Olj73xGYU7w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrheehgdegfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 30 Jul 2021 08:03:14 -0400 (EDT) From: Thomas Monjalon To: Gregory Etelson Cc: dev@dpdk.org, Ajit Khaparde , Andrew Rybchenko , Ferruh Yigit , stable@dpdk.org, Xiaoyun Li , Tomasz Kulasek , Konstantin Ananyev , Olivier Matz Date: Fri, 30 Jul 2021 14:04:02 +0200 Message-ID: <125205582.vBP58ymnIJ@thomas> In-Reply-To: References: <20210719083309.15428-1-getelson@nvidia.com> <20210729170141.26563-1-getelson@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4] app/testpmd: fix TX checksum calculation for tunnel X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 30/07/2021 10:39, Olivier Matz: > On Thu, Jul 29, 2021 at 08:01:41PM +0300, Gregory Etelson wrote: > > csumonly engine calculates TX checksum of a tunnelled packet for outer > > headers only or separately for outer and inner headers. The > > calculation method is determined by checksum configuration options. > > If TX checksum calculation is separated, the inner headers are > > processed before outer headers. > > > > Inner headers processing sets checksum values to 0 unconditionally. > > If TX configuration offloads inner checksums only, outer checksum > > calculation in software will read 0 instead of real values and > > produce wrong result. > > > > The patch zeroes inner checksums only before software calculation. > > > > Fixes: 6b520d54ebfe ("app/testpmd: use Tx preparation in checksum engine") > > Cc: stable@dpdk.org > > > > Signed-off-by: Gregory Etelson > > Acked-by: Olivier Matz > The previous acks were forgotten (it should be added manually in the patch): Acked-by: Ori Kam Acked-by: Ajit Khaparde Acked-by: Xiaoyun Li Applied, thanks.