From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0D4B642C50; Wed, 7 Jun 2023 18:48:40 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E52EA42C76; Wed, 7 Jun 2023 18:48:39 +0200 (CEST) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by mails.dpdk.org (Postfix) with ESMTP id 6B54242C4D for ; Wed, 7 Jun 2023 18:48:38 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 3FE1532007E8; Wed, 7 Jun 2023 12:48:37 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Wed, 07 Jun 2023 12:48:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1686156516; x=1686242916; bh=jnQUQW+Kk7Zwxn7aNJNHYvPLYW93dfd/F6v eDxkDRaE=; b=Xvx9XaUTjfyNiTarZC9lFhrIfqdINrLgWfHcrXfR/2A40QDv/+u 3WHzAIw90hMBpG56DQJfcT06dR6FPj43GxinOSYvVLVzXDeUE20ZEAITrRijhJ1K w4vNP9kosCo++wR2Mt9XkJjGVltImC6ofJbW4smqkd7sq+DjBYBi+mL4n4x5OhoA RfJ7zOsX3NH/IiqcZrx40AtBnKfHUYFO7MxIApMV4PisouiMo+9UPtY6+5s0IetA 86P+0g2CGNkfpn1Fr5jv+zn6NlG6cYMxnY9WaD5UpaHhJE1SJetBZWAfmNl54mzP 2FdZU5GvW3EqeLz4Bd8X4/BkeOSDSBuoe2w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1686156516; x=1686242916; bh=jnQUQW+Kk7Zwxn7aNJNHYvPLYW93dfd/F6v eDxkDRaE=; b=xI2wVRzg3RkjXmNZ9qtfXlj4R16+g4635bwj/DAWwcknPot5YF5 675VwExdLCthcJcRWQlVlfyuEnbAfexVPv9tPsdGJDfhCzgLYwvrcxo7ilgzvM/l 3vUBUVQQK6qktIkbE+ErBz0zE+nrTseATlWCZx7ixVjPDqlGh0Srw1D7t57+EDXD KTV54kwdqma4x2um51It8wRtu3Naye8EDOp+c5eFjGQLArzjSUBwcNg1wW7atBuO 2VKTPmA1RXHRNHSHJQ9RIPwullmthRP2pdbk8L1fGRz/XESXg5ECIMIFBKMnCZuX fhZupZ2pzOSipZ0F8546a0JHEtqvqpEK6yw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgedtgedguddtiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtqhertddttddunecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnhepfefhjeeluedvvedtuddtuedtvefhieejtefhffeujefhtedu udevtdektdeikeffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 7 Jun 2023 12:48:35 -0400 (EDT) From: Thomas Monjalon To: Viacheslav Ovsiienko Cc: dev@dpdk.org, david.marchand@redhat.com, Bruce Richardson Subject: Re: [PATCH v2] eal: choose IOVA mode according to compilation flags Date: Wed, 07 Jun 2023 18:48:34 +0200 Message-ID: <12585842.hYdu0Ggh8K@thomas> In-Reply-To: References: <20230412171949.27665-1-viacheslavo@nvidia.com> <20230606151511.978-1-viacheslavo@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 06/06/2023 17:23, Bruce Richardson: > On Tue, Jun 06, 2023 at 06:15:11PM +0300, Viacheslav Ovsiienko wrote: > > The DPDK can be compiled to be run in IOVA VA mode with > > 'enable_iova_as_pa=3Dfalse' meson option. If there is no > > explicit EAL --iova-mode parameter specified in the command > > line the rte_eal_init() tried to deduce VA or PA mode without > > taking into account the above mentioned compile time option, > > resulting into initialization failure. It looks like a bug fix to backport. Do you agree? Could you add the fix tags? > >=20 > > Signed-off-by: Viacheslav Ovsiienko You forgot previous tag: Reviewed-by: Morten Br=F8rup > > --- > > lib/eal/linux/eal.c | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) What about FreeBSD and Windows? I suspect there is the same issue. > > @@ -1081,7 +1081,10 @@ rte_eal_init(int argc, char **argv) > > if (iova_mode =3D=3D RTE_IOVA_DC) { > > RTE_LOG(DEBUG, EAL, "Buses did not request a specific IOVA mode.\n"= ); > > =20 > > - if (!phys_addrs) { > > + if (!RTE_IOVA_IN_MBUF) { > > + iova_mode =3D RTE_IOVA_VA; > > + RTE_LOG(DEBUG, EAL, "IOVA as VA mode is forced by build option.\n"= ); > > + } else if (!phys_addrs) { > > /* if we have no access to physical addresses, > > * pick IOVA as VA mode. > > */ >=20 > Acked-by: Bruce Richardson