From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Flavia Musatescu <flavia.musatescu@intel.com>,
dev@dpdk.org, "John W. Linville" <linville@tuxdriver.com>
Cc: stable@dpdk.org, ciwillia@brocade.com
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v4] net/af_packet: improve Tx statistics accuracy
Date: Mon, 21 Oct 2019 19:15:34 +0100 [thread overview]
Message-ID: <125df986-5e49-7a3c-bb4a-3892033b8fa4@intel.com> (raw)
In-Reply-To: <915cf788-d313-eb95-1ba1-f11bac7e400f@intel.com>
On 10/18/2019 4:15 PM, Ferruh Yigit wrote:
> On 10/18/2019 3:24 PM, Flavia Musatescu wrote:
>> When sendto call fails and ENOBUFS/EAGAIN error is being set
>> some of the packets are actually successfully transmitted.
>> There is no available count of those packets, so in order to
>> make the statistics more accurate, all the previously enqueued
>> packets will be considered successful, even though this is not
>> entirely correct.
>>
>> Statistics numbers before this update:
>>
>> Pktgen:
>> Total Rx Pkts: 1360084
>> Tx Pkts: 2000000
>> testpmd:
>> RX-packets: 1408346 RX-missed: 0 RX-bytes: 84503418
>> TX-packets: 526486 TX-errors: 881851 TX-bytes: 31589724
>>
>> Statistics numbers after this update:
>>
>> Pktgen:
>> Total Rx Pkts: 1329872
>> Tx Pkts: 2000000
>> testpmd:
>> RX-packets: 1389156 RX-missed: 0 RX-bytes: 83349360
>> TX-packets: 1389156 TX-errors: 0 TX-bytes: 83349360
>>
>> Fixes: 74b7fc0a0ff1 ("net/af_packet: fix packet bytes counting")
>> Cc: ciwillia@brocade.com
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Flavia Musatescu <flavia.musatescu@intel.com>
>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
Applied to dpdk-next-net/master, thanks.
prev parent reply other threads:[~2019-10-21 18:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 15:29 [dpdk-dev] [PATCH] " Flavia Musatescu
2019-10-09 17:26 ` Stephen Hemminger
2019-10-10 17:34 ` [dpdk-dev] [PATCH v2] " Flavia Musatescu
2019-10-10 18:35 ` Stephen Hemminger
2019-10-11 17:13 ` Musatescu, Flavia
2019-10-17 11:51 ` [dpdk-dev] [PATCH v3] " Flavia Musatescu
2019-10-18 14:24 ` [dpdk-dev] [PATCH v4] " Flavia Musatescu
2019-10-18 15:15 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2019-10-21 18:15 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=125df986-5e49-7a3c-bb4a-3892033b8fa4@intel.com \
--to=ferruh.yigit@intel.com \
--cc=ciwillia@brocade.com \
--cc=dev@dpdk.org \
--cc=flavia.musatescu@intel.com \
--cc=linville@tuxdriver.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).