From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id 2A93668D1 for ; Mon, 3 Oct 2016 16:08:18 +0200 (CEST) Received: by mail-wm0-f54.google.com with SMTP id p138so153534832wmb.1 for ; Mon, 03 Oct 2016 07:08:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=JioJru1KYIKPOR70SzEkpBR3jaibD9AJNap34xZtASg=; b=U4SyEq1HwrAkkrtMoMstn9UD4PUa7NKmN6S90IMlWg9B0A+k6zHfc2xdjnqbXIPtps v38VdotfUpR+arC2ERQBYgCbACoETFZ24jCvh7/90hqIYnUyUE+A+Q1xa8DVCIeAF4pw 4zNAynUefgeVQ6DMMntWNbY89ImmSms4CdnmK+Zcu81puyoVZdQ0R1uuJOoQh3EDlZ5W ZBMeDt1XRU2cGUlTAJJRYO5JswGeTuB7mKXWcMLzlOVyYlQcl2GoAuI598CQkmAPhmg0 9b5ADNwHW5phOAnkbOmpAgZAa48aPDAWgw96xTxaCsQ8aZHuji2bviMx2FqaHMip4PMc Vv5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=JioJru1KYIKPOR70SzEkpBR3jaibD9AJNap34xZtASg=; b=IPIReJZDxKyF6/zM6QI3DxnPU8g4RDk7cxsgtR7IFp/W8QZ2ae+fqUTCUa88GPdx+z usrunMAZwObhvJ8AhyrGuHq1RyIhLHLwOpfmS33SiQfCpVE/9AT83KKcqaBgxZY/C3BI 6Fwz6Ol2kotSSlHpsH8bQHsu5RQlCU2jr0qJEf0dxABWT7Ie3P00f6kQJRgK3QXmngMk r3Xmq24BsQTMRblw+e4Z0urzJuBATAzA80+1kz08Ww2JAVaNUgqgifT8tAIxPJ3/Zy4P CmjVdSp+/ctn9RQrLyAussSgtxtaa9wYp0cRqr9gqAiLRwDMtT237L2lswMPqA8V48iW ZSFw== X-Gm-Message-State: AA6/9RkYyuPe+r6zebI/VEse2RCvKHUN+34jgR+5MHA9iRI8Cj2i/R8mCuTgsIiDeOjAhStz X-Received: by 10.28.51.21 with SMTP id z21mr9168272wmz.24.1475503697649; Mon, 03 Oct 2016 07:08:17 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id xy4sm34510073wjc.2.2016.10.03.07.08.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Oct 2016 07:08:16 -0700 (PDT) From: Thomas Monjalon To: Yuanhan Liu Cc: Sergio Gonzalez Monroy , David Marchand , dev@dpdk.org, "Tan, Jianfeng" Date: Mon, 03 Oct 2016 16:08:16 +0200 Message-ID: <12611877.pV9n3cg2jy@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <65601617-b4a2-4971-6482-af4810dbb34a@intel.com> References: <1474614646-23648-1-git-send-email-yuanhan.liu@linux.intel.com> <65601617-b4a2-4971-6482-af4810dbb34a@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal: remove single file segments related code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Oct 2016 14:08:18 -0000 2016-09-30 15:48, Sergio Gonzalez Monroy: > On 30/09/2016 15:32, David Marchand wrote: > > On Fri, Sep 23, 2016 at 12:08 PM, Tan, Jianfeng wrote: > >>> -----Original Message----- > >>> From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com] > >>> Sent: Friday, September 23, 2016 5:15 PM > >>> To: Thomas Monjalon > >>> Cc: dev@dpdk.org; David Marchand; Tan, Jianfeng > >>> Subject: Re: [PATCH] eal: remove single file segments related code > >>> > >>> On Fri, Sep 23, 2016 at 10:50:06AM +0200, Thomas Monjalon wrote: > >>>> 2016-09-23 15:10, Yuanhan Liu: > >>>>> Commit c711ccb30987 ("ivshmem: remove library and its EAL integration") > >>>>> removed ivshmem support, but seems David forgot to remove the another > >>>>> piece of code: code for RTE_EAL_SINGLE_FILE_SEGMENTS, which is > >>> introduced > >>>>> when ivshmem was firstly added. > >>>> It is not a mistake. We thought it is used by container use case. > >>> I think no. It would help the container case a bit, but not too much I > >>> would think, especially when the memory goes fragement. > >>> > >>> Jianfeng, IIRC, you don't use that option for container case, right? > >>> > >>> --yliu > >> No, I don't use this option for container case. As yuanhan said, it cannot provide much help for virtio_user memory region number limitation. > > Ok, as said, since this feature had been introduced with ivshmem > > 40b966a211ab ("ivshmem: library changes for mmaping using ivshmem"), > > if Sergio has nothing against this removal, I am all for removing > > unused code. > > I certainly do not have anything against this removal :) > > Acked-by: Sergio Gonzalez Monroy Applied, thanks