From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D9DBEA0A0C; Thu, 22 Jul 2021 21:15:34 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5F12A4014D; Thu, 22 Jul 2021 21:15:34 +0200 (CEST) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by mails.dpdk.org (Postfix) with ESMTP id CC0EF40040 for <dev@dpdk.org>; Thu, 22 Jul 2021 21:15:32 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id AADBF320090B; Thu, 22 Jul 2021 15:15:31 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 22 Jul 2021 15:15:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= xRaJNp296iXQJTzDr11ld2WbpV2xb5NGESH/UoJfzns=; b=1ZrSVyiACdKH0w9d fdTWEn/ybMW6bNbXfbAGBduN5QOXyMbJSIumuwnr/Gbm7wZq/5KG3RqrE8Lfzx5e XwbkWbVXCb6lW+F/OmYmTvURBZZ8iAKCIb6CvvZNecgQAFxSouM2lsepnPG8RO5k OV+cvrGuPspGv+lgZCtDcsykapWPq6YdDwLJS7nvYoRuH53DaGuLayX/AUOFgIvM vKrpBQ1dfBJ9EVIaDBRjjToy4Z3ar94WEEziMkEnXYPP1t1+qYYyztws7ntuQv9s +Yhi0MCtYa0q15nR6IBbMaJCSu1uSU9DmLbe5Ip9ngcOGx05tMjj3goTjlkrYhHd JshBaw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=xRaJNp296iXQJTzDr11ld2WbpV2xb5NGESH/UoJfz ns=; b=Pvl+pTuvDLjuGXOBHc5JkdzOGKSnk2YIzk/jpWI2bRG0jU7iL5RX1N/ET gICXPMLbEd2EVynzxPk1fNi65+x4lzxr9Pz754UARav97T38jocJxv04P3AjRcIw LU7nxgGL/qCnl7uiHdZBrCDwzyOBhsv5G64fBZP5Yxmf+0fKFS9EkcnvM/Pcy5aY cD7XwIihlbll7Nj7dEgFGbxhxDhQ03WOLviJvsUzkwvYegr4jPN5c/aBtJvb3zzM OqwNo2bnOIw2nRTEyo2DJFjGJ1fdwMC6GT0dIokaYH6yk4K9dEmRQ1buIy8kZlMN 0i6TZz+YX/lMzuaSMo6sQ7Wwp2wzw== X-ME-Sender: <xms:0sP5YKMNDJrb8I4fO1lFlkRND9F2KNst44RrzF-XOBdnuud_xqP9NQ> <xme:0sP5YI9cnJ93IPYZ_76IclxMxXCmzOiJ-n49YdoMuGfRZQ0tGgSvqoWGYJqY_I8fD HtgrdN0gsp_d8kmgw> X-ME-Received: <xmr:0sP5YBQ78L3DtQoHOapRMLpJrXRftInBXgpRw9rK4WUKuFOdSLOy8vtlhlI63BucRHLL-VRP4vSGAfkYLiW7CBpRSw> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrfeeigdduvdehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: <xmx:0sP5YKuLsMeBMng-9SJwaR8iE1nZzfPrcj-AbIfSJ53Lrn123p7hcA> <xmx:0sP5YCfejuuaD-3HMbSfNYWNTnnc1cVQX6VONy7fOXUUHe5UxsJVJQ> <xmx:0sP5YO08RsY0_saJlZWz4FEzNV8xLzslV9CwHBQKesmVyHXmI4s2Dg> <xmx:08P5YDrp0io1yECNBLyQU5UbUHpg8VYRlNNs1HjJiWW3AZKiYNc87w> Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 22 Jul 2021 15:15:30 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: jerb <jonathan.erb@banduracyber.com> Cc: Stephen Hemminger <sthemmin@microsoft.com>, dev@dpdk.org, Long Li <longli@microsoft.com> Date: Thu, 22 Jul 2021 21:15:48 +0200 Message-ID: <12614253.dWt8NKk3Zt@thomas> In-Reply-To: <BY5PR21MB150616D609C9AC15AA9C2848CEE39@BY5PR21MB1506.namprd21.prod.outlook.com> References: <20210720145839.12180-1-jonathan.erb@banduracyber.com> <MW4PR21MB1907C4CE74CB87B814740379CCE29@MW4PR21MB1907.namprd21.prod.outlook.com> <BY5PR21MB150616D609C9AC15AA9C2848CEE39@BY5PR21MB1506.namprd21.prod.outlook.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] bus/vmbus: Fix crash when handling packets in secondary process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 21/07/2021 02:17, Long Li: > From: Stephen Hemminger <sthemmin@microsoft.com> > > > > Looks good, minor comment. You don't have to check for NULL before calling > > rte_free(). > > Rte_free(NULL) is a NOP like free(NULL). > > > > Sorry for top posting; but if you send to my Microsoft account you are stuck > > with what Outlook can do... > > > From: jerb <jonathan.erb@banduracyber.com> > > > > Have secondary processes construct their own copy of primary channel with > > own mappings. > > > > Remove vmbus_channel primary ptr from struct mapped_vmbus_resource as > > its not used. > > > > Populate virtual memory address "addr" in struct rte_mem_resource for > > secondary processes as netvsc will attempt to reference it thus causing a crash. > > It was initialized for primary processes but not for secondary. > > > > Signed-off-by: jerb <jonathan.erb@banduracyber.com> Please give your complete name. > Looks good. > > This should also go to stable. Please send a v2 with Fixes and Cc: stable@dpdk.org lines as documented in the contributor's guide. If you don't know how to do, the maintainers can help. Thank you