From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8725A43B45; Mon, 19 Feb 2024 02:10:22 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 275C0402B8; Mon, 19 Feb 2024 02:10:22 +0100 (CET) Received: from fout4-smtp.messagingengine.com (fout4-smtp.messagingengine.com [103.168.172.147]) by mails.dpdk.org (Postfix) with ESMTP id 41AA24029B; Mon, 19 Feb 2024 02:10:21 +0100 (CET) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailfout.nyi.internal (Postfix) with ESMTP id 7929F13800B5; Sun, 18 Feb 2024 20:10:20 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Sun, 18 Feb 2024 20:10:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1708305020; x=1708391420; bh=4sSjF8cm48u79dDpkIuBjzWa951LE5hH+PGHy6ewCXY=; b= 0/bRx7zzHV4+mCMbX+L5wGR79Eog6IzWVHqHLOBSCstdC0vqVoCPw/7RLqo2zPYP JqRtPTVp7uoF33xhql/ZhCu8MKOtBwO+8bhc05dc/8IwBZuF5CBeKDzwzzxtRwTW ggnKH2E7XN1vDcl/bOyy4cU0jjOLl2V+QZHzcysooVYQu+PEyXmUJzTSBDhFyHih oiJpM+JUcpC1I7l8xHAYc1XqSBZPe5VMXCd9AbuBakSJ3A1BJNWd/jQw1BDi8w8x lHLfO9/8OwL2MsUYf8GeFdvFcpwMWe3uRAximKQRVZld/YT6ptLzNspc330c5Rr6 l/jjnI9TdDOdpJTP3zvVew== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1708305020; x= 1708391420; bh=4sSjF8cm48u79dDpkIuBjzWa951LE5hH+PGHy6ewCXY=; b=V PPiPxFbS/fWKPTutE6bs6RMg5qPwXsg+Tix7rP9otoNKz0T0DHkKa2MLYgYbIbLW y7v6Ri+Tc+puJNilvI7Hgwc8gPfQWdyuGZny9u1s6Fu5zJuxTLmpPiSdPTurz/iV 29j7bWVUT9GxLdClPsTC4QZanClVNQJJJ/2Kmkmikf34VlxuMWZW8daW01gKbVIX 10KlRIWp+p1FmUUwauMi53QaT2dnOINvUDuQhahReGoAEvbScHI5bfcGKhqumawP Rx52JtfZnxtibal0buvCB/dGp6i2uMimOODaanKAU/q2X5EUJMLauR6XQ19rytMR 9MTzeBRH8mUDtQBgxcLDA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdejgdefvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtqhertddttddunecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepfefhjeeluedvvedtuddtuedtvefhieejtefhffeujefhteduudev tdektdeikeffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 18 Feb 2024 20:10:18 -0500 (EST) From: Thomas Monjalon To: Kaiwen Deng Cc: dev@dpdk.org, stable@dpdk.org, qiming.yang@intel.com, yidingx.zhou@intel.com, Aman Singh , Ferruh Yigit , Xiaoyun Li , Morten =?ISO-8859-1?Q?Br=F8rup?= Subject: Re: [PATCH v5] lib/net: fix tcp/udp cksum with padding data Date: Mon, 19 Feb 2024 02:10:17 +0100 Message-ID: <12660958.BaYr0rKQ5T@thomas> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F0C7@smartserver.smartshare.dk> References: <20231213043732.2113867-1-kaiwenx.deng@intel.com> <20231214092259.2126634-1-kaiwenx.deng@intel.com> <98CBD80474FA8B44BF855DF32C47DC35E9F0C7@smartserver.smartshare.dk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 14/12/2023 12:20, Morten Br=F8rup: > > From: Kaiwen Deng [mailto:kaiwenx.deng@intel.com] > > Sent: Thursday, 14 December 2023 10.23 > >=20 > > IEEE 802 packets may have a minimum size limit. The data fields > > should be padded when necessary. In some cases, the padding data > > is not zero. > >=20 > > In 'rte_ipv4_udptcp_cksum_mbuf()', as payload length > > "mbuf->pkt_len - l4_off" is used, which includes padding and if > > padding is not zero it will end up producing wrong checksum. > >=20 > > This patch will use IP header to get the payload size to calculate > > tcp/udp checksum. > >=20 > > Fixes: d178f693bbfe ("net: add UDP/TCP checksum in mbuf segments") > > Cc: stable@dpdk.org > >=20 > > Signed-off-by: Kaiwen Deng >=20 > Reviewed-by: Morten Br=F8rup Applied, thanks.