From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 21DF5A04B1; Wed, 23 Sep 2020 19:20:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D34F01D969; Wed, 23 Sep 2020 19:20:28 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 45D421D6A9 for ; Wed, 23 Sep 2020 19:20:26 +0200 (CEST) IronPort-SDR: XHO3ZMiodcoeI+s4wm6l3cSxPQ7p4W9EBn75cvA/O2G7DZgvUZFnVge4bgsSxofG8DGgYWonra kZAf0NoAZgdw== X-IronPort-AV: E=McAfee;i="6000,8403,9753"; a="148704381" X-IronPort-AV: E=Sophos;i="5.77,293,1596524400"; d="scan'208";a="148704381" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2020 10:20:24 -0700 IronPort-SDR: NiyxfMucoQ5Va6UQvA1r7qpPWB5twG7XvBshJM7Iho2bteUjmeKGAPRKyxN3dw7o3ZuMzslLYX CUeFfabMZqog== X-IronPort-AV: E=Sophos;i="5.77,293,1596524400"; d="scan'208";a="305460199" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.218.147]) ([10.213.218.147]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2020 10:20:24 -0700 To: Andrew Rybchenko , dev@dpdk.org References: <1600764594-14752-1-git-send-email-arybchenko@solarflare.com> <1600767288-12109-1-git-send-email-arybchenko@solarflare.com> <1600767288-12109-3-git-send-email-arybchenko@solarflare.com> From: Ferruh Yigit Message-ID: <126c77b8-fff4-1f93-9a5e-487e1ad4740e@intel.com> Date: Wed, 23 Sep 2020 18:20:20 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.2.2 MIME-Version: 1.0 In-Reply-To: <1600767288-12109-3-git-send-email-arybchenko@solarflare.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 02/60] common/sfc_efx/base: update MCDI headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/22/2020 10:33 AM, Andrew Rybchenko wrote: > Signed-off-by: Andrew Rybchenko <...> > > + > +/***********************************/ > +/* MC_CMD_VNIC_ENCAP_RULE_ADD > + * Add a rule for detecting encapsulations in the VNIC stage. Currently this only affects checksum validation in VNIC RX - on TX the send descriptor explicitly specifies encapsulation. These rules are per-VNIC, i.e. only apply to the current driver. If a rule matches, then the packet is considered to have the corresponding encapsulation type, and the inner packet is parsed. It is up to the driver to ensure that overlapping rules are not inserted. (If a packet would match multiple rules, a random one of them will be used.) A rule with the exact same match criteria may not be inserted twice (EALREADY). Only a limited number MATCH_FLAGS values are supported, use MC_CMD_GET_PARSER_DISP_INFO with OP OP_GET_SUPPORTED_VNIC_ENCAP_RULE_MATCHES to get a list of supported combinations. Each driver may only have a limited set of active rules - returns ENOSPC if the caller's table is full. > We are allowing base files to keep their original syntax (as long as it is consistent within), but whole above comment as single line looks a little excessive, can you please fix it? > + > +/***********************************/ > +/* MC_CMD_VNIC_ENCAP_RULE_REMOVE > + * Remove a VNIC encapsulation rule. Packets which would have previously matched the rule will then be considered as unencapsulated. Returns EALREADY if the input HANDLE doesn't correspond to an existing rule. > + */ ditto