* [dpdk-dev] [PATCH v1] bus/fslmc: fix dpio close
@ 2020-07-28 16:24 rohit.raj
2020-08-06 14:32 ` Sachin Saxena (OSS)
0 siblings, 1 reply; 3+ messages in thread
From: rohit.raj @ 2020-07-28 16:24 UTC (permalink / raw)
To: Hemant Agrawal, Sachin Saxena; +Cc: dev, stable, Rohit Raj
From: Rohit Raj <rohit.raj@nxp.com>
The current state of the DPIO object should be checked
before trying to close/disable the object.
Fixes: 293c0ca94c36 ("bus/fslmc: support memory backed portals with QBMAN 5.0")
Cc: stable@dpdk.org
Signed-off-by: Rohit Raj <rohit.raj@nxp.com>
---
drivers/bus/fslmc/portal/dpaa2_hw_dpio.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c b/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c
index 97be76116..b0055b164 100644
--- a/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c
+++ b/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c
@@ -528,8 +528,13 @@ dpaa2_create_dpio_device(int vdev_fd,
err:
if (dpio_dev->dpio) {
- dpio_disable(dpio_dev->dpio, CMD_PRI_LOW, dpio_dev->token);
- dpio_close(dpio_dev->dpio, CMD_PRI_LOW, dpio_dev->token);
+ if (dpio_dev->token) {
+ dpio_disable(dpio_dev->dpio, CMD_PRI_LOW,
+ dpio_dev->token);
+ dpio_close(dpio_dev->dpio, CMD_PRI_LOW,
+ dpio_dev->token);
+ }
+
rte_free(dpio_dev->eqresp);
rte_free(dpio_dev->dpio);
}
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH v1] bus/fslmc: fix dpio close
2020-07-28 16:24 [dpdk-dev] [PATCH v1] bus/fslmc: fix dpio close rohit.raj
@ 2020-08-06 14:32 ` Sachin Saxena (OSS)
2020-10-06 8:57 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Sachin Saxena (OSS) @ 2020-08-06 14:32 UTC (permalink / raw)
To: rohit.raj, dev
Acked-by: Sachin Saxena<sachin.saxena@oss.nxp.com>
On 28-Jul-20 9:54 PM, rohit.raj@nxp.com wrote:
> From: Rohit Raj <rohit.raj@nxp.com>
>
> The current state of the DPIO object should be checked
> before trying to close/disable the object.
>
> Fixes: 293c0ca94c36 ("bus/fslmc: support memory backed portals with QBMAN 5.0")
> Cc: stable@dpdk.org
>
> Signed-off-by: Rohit Raj <rohit.raj@nxp.com>
> ---
> drivers/bus/fslmc/portal/dpaa2_hw_dpio.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c b/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c
> index 97be76116..b0055b164 100644
> --- a/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c
> +++ b/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c
> @@ -528,8 +528,13 @@ dpaa2_create_dpio_device(int vdev_fd,
>
> err:
> if (dpio_dev->dpio) {
> - dpio_disable(dpio_dev->dpio, CMD_PRI_LOW, dpio_dev->token);
> - dpio_close(dpio_dev->dpio, CMD_PRI_LOW, dpio_dev->token);
> + if (dpio_dev->token) {
> + dpio_disable(dpio_dev->dpio, CMD_PRI_LOW,
> + dpio_dev->token);
> + dpio_close(dpio_dev->dpio, CMD_PRI_LOW,
> + dpio_dev->token);
> + }
> +
> rte_free(dpio_dev->eqresp);
> rte_free(dpio_dev->dpio);
> }
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH v1] bus/fslmc: fix dpio close
2020-08-06 14:32 ` Sachin Saxena (OSS)
@ 2020-10-06 8:57 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2020-10-06 8:57 UTC (permalink / raw)
To: rohit.raj; +Cc: dev, Sachin Saxena (OSS)
06/08/2020 16:32, Sachin Saxena (OSS):
> On 28-Jul-20 9:54 PM, rohit.raj@nxp.com wrote:
> > From: Rohit Raj <rohit.raj@nxp.com>
> >
> > The current state of the DPIO object should be checked
> > before trying to close/disable the object.
> >
> > Fixes: 293c0ca94c36 ("bus/fslmc: support memory backed portals with QBMAN 5.0")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Rohit Raj <rohit.raj@nxp.com>
>
> Acked-by: Sachin Saxena <sachin.saxena@oss.nxp.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-06 8:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-28 16:24 [dpdk-dev] [PATCH v1] bus/fslmc: fix dpio close rohit.raj
2020-08-06 14:32 ` Sachin Saxena (OSS)
2020-10-06 8:57 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).