From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 7D2241B116 for ; Fri, 12 Oct 2018 08:50:10 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1D94B21FBA; Fri, 12 Oct 2018 02:50:10 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 12 Oct 2018 02:50:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=XfEnNU/GdKPqeKtA8kcBj0CFbjx/EtP+slXiuzM8v3I=; b=b7bCFDAiwkSD AO5JO0/FZRyUsT3qHG+DyoJziOB09zb/ToLk3FFHHM2P973caz6RqJ+9rIEIqVmU p1BAQZFgNRDRWYEidX0obHgdeNQzKOSMNdd4C2NgR8uorbzadRFnJHt80HwjUCm9 V0IScR1XSrw/zZavVwfirtjT8I1fRaU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=XfEnNU/GdKPqeKtA8kcBj0CFbjx/EtP+slXiuzM8v 3I=; b=WnPNxW8Z6dNn7kc+JG3B3MmFT8tls+nD7LRZJaBhNldg4W/5r8p9i60v5 E4uG7cxIMaGj+ptHcRZn6szIH+kPMhmavWluRP9Q3210K6s1lBgs8/8Iy3V3nekF ylQOD7lpgVMTlVO9F0Nfs6V+VG4YelIyMMwD5vr7qjqPLGm87EOWsi+Hs3jeoTlv EcxtwLcCFjJ0q80UrfrY5LHFBuqeYaI0vTeFC5+lYRj+ItJhThjJzs/uB1EEyN4Y BOsGi5McSp6kd3tWcwcpOO15I0P2espCs5WyLdDYRl+/QlvkXxAYU+yCfaBmCF31 7aXDBG1ajnImUDBSKOoBuhzYKut1w== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 876FF102DE; Fri, 12 Oct 2018 02:50:08 -0400 (EDT) From: Thomas Monjalon To: Jerin Jacob Cc: Chao Zhu , dev@dpdk.org, gowrishankar.m@linux.vnet.ibm.com, ola.liljedahl@arm.com Date: Fri, 12 Oct 2018 08:50:06 +0200 Message-ID: <12734944.s5Hp39GJoV@xps> In-Reply-To: <20181012041255.GA7250@jerin> References: <20181007061857.29451-1-jerin.jacob@caviumnetworks.com> <000001d461d2$adc87910$09596b30$@linux.vnet.ibm.com> <20181012041255.GA7250@jerin> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] =?utf-8?b?562U5aSNOiAgW1BBVENIXSBlYWwvcHBjNjQ6IGFkZCBz?= =?utf-8?q?upport_for_rte_pause?= X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Oct 2018 06:50:10 -0000 12/10/2018 06:12, Jerin Jacob: > -----Original Message----- > > Date: Fri, 12 Oct 2018 10:24:16 +0800 > > From: Chao Zhu > > To: 'Jerin Jacob' > > CC: dev@dpdk.org, thomas@monjalon.net, gowrishankar.m@linux.vnet.ibm.co= m, > > ola.liljedahl@arm.com > > Subject: =E7=AD=94=E5=A4=8D: [dpdk-dev] [PATCH] eal/ppc64: add support = for rte pause > > X-Mailer: Microsoft Outlook 16.0 > >=20 > >=20 > > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > > =E5=8F=91=E4=BB=B6=E4=BA=BA: Jerin Jacob > > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2018=E5=B9=B410=E6=9C=887=E6=97= =A5 14:19 > > =E6=94=B6=E4=BB=B6=E4=BA=BA: Chao Zhu > > =E6=8A=84=E9=80=81: dev@dpdk.org; thomas@monjalon.net; gowrishankar.m@l= inux.vnet.ibm.com; > > ola.liljedahl@arm.com; Jerin Jacob > > =E4=B8=BB=E9=A2=98: [dpdk-dev] [PATCH] eal/ppc64: add support for rte p= ause > >=20 > > Add support for rte_pause() implementation for ppc64. > >=20 > > Signed-off-by: Jerin Jacob > > --- > >=20 > > The reference implementation for Linux's cpu_relax() for ppc64 is at > > https://elixir.bootlin.com/linux/latest/source/arch/powerpc/include/asm= /proc > > essor.h#L440 > >=20 > > --- > > lib/librte_eal/common/include/arch/ppc_64/rte_pause.h | 7 +++++++ > > 1 file changed, 7 insertions(+) > >=20 > > diff --git a/lib/librte_eal/common/include/arch/ppc_64/rte_pause.h > > b/lib/librte_eal/common/include/arch/ppc_64/rte_pause.h > > index 8bd835764..16e47ce22 100644 > > --- a/lib/librte_eal/common/include/arch/ppc_64/rte_pause.h > > +++ b/lib/librte_eal/common/include/arch/ppc_64/rte_pause.h > > @@ -9,10 +9,17 @@ > > extern "C" { > > #endif > >=20 > > +#include "rte_atomic.h" > > + > > #include "generic/rte_pause.h" > >=20 > > static inline void rte_pause(void) > > { > > + /* Set hardware multi-threading low priority */ > > + asm volatile("or 1,1,1"); > > + /* Set hardware multi-threading medium priority */ > > + asm volatile("or 2,2,2"); > > + rte_compiler_barrier(); > > } > >=20 > > #ifdef __cplusplus > > -- > > 2.19.0 > >=20 > > Acked-by: Chao Zhu >=20 > Thomas, >=20 > Just noticed, due to some reason, The above Acked-by: is not reflected in= patchwork. >=20 > http://patches.dpdk.org/patch/46195/ >=20 > Probably because, it was not a "inline" reply which patchwork couldn't pa= rse it. Or more probably, there are some special characters in the email or headers which make patchwork parsing to fail.