From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0D859A04B5; Thu, 24 Sep 2020 15:17:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B876E1C438; Thu, 24 Sep 2020 15:17:48 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 586611C434 for ; Thu, 24 Sep 2020 15:17:46 +0200 (CEST) IronPort-SDR: hM6kF6918NP0P1lWkA9r75eVtkiGTNKq4SOa/nRukf9OFMQ86ZhF1h6kZVSF/iYwJumlSrVrYo UgEryi+auROg== X-IronPort-AV: E=McAfee;i="6000,8403,9753"; a="162103397" X-IronPort-AV: E=Sophos;i="5.77,297,1596524400"; d="scan'208,217";a="162103397" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Sep 2020 06:17:45 -0700 IronPort-SDR: MCAQusOapDniKQg3fu9NZsUf1a18E5D6nBlC7jdd707Msky6HPCIwsMRHQ6P6fA4TfiiK5/3Fg 3HuIXM+GPEhQ== X-IronPort-AV: E=Sophos;i="5.77,297,1596524400"; d="scan'208,217";a="335973104" Received: from dhunt5-mobl5.ger.corp.intel.com (HELO [10.213.217.234]) ([10.213.217.234]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Sep 2020 06:17:38 -0700 To: Ciara Power , dev@dpdk.org Cc: Nicolas Chautru , John McNamara , Marko Kovacevic , Olivier Matz , Ori Kam , Bruce Richardson , Radu Nicolau , Akhil Goyal , Tomasz Kantecki , Sunil Kumar Kori , Pavan Nikhilesh , Harry van Haaren , Bernard Iremonger , Konstantin Ananyev , Cristian Dumitrescu , Ferruh Yigit , Jerin Jacob , Kiran Kumar K , Nithin Dabilpuram , Anatoly Burakov , Xiaoyun Li , Jingjing Wu , Reshma Pattan , Kirill Rybalchenko , Jasvinder Singh , Byron Marohn , Yipeng Wang , Robert Sanford , Erik Gabriel Carrillo , Maxime Coquelin , Chenbo Xia , Zhihong Wang , Wenzhuo Lu , Beilei Xing References: <20200807123009.21266-1-ciara.power@intel.com> <20200921135931.13355-1-ciara.power@intel.com> <20200921135931.13355-17-ciara.power@intel.com> From: David Hunt Message-ID: <12825fb2-7476-ce88-163e-c2ab260911a6@intel.com> Date: Thu, 24 Sep 2020 14:17:36 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200921135931.13355-17-ciara.power@intel.com> Content-Language: en-GB Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v5 16/20] doc: remove references to make from app guides X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Ciara, On 21/9/2020 2:59 PM, Ciara Power wrote: > Make is no longer supported for compiling DPDK, references are now > removed in the documentation. > > Signed-off-by: Ciara Power > Acked-by: Nicolas Chautru > --- --snip-- When checking the vm_power_manager portion of this guide, I came across a dependency on a patch set that Bruce submitted, which makes some power management library headers public. This patch set needs to be applied so vm_power_mgr and guest_cli can be build with these instruction. http://patches.dpdk.org/project/dpdk/list/?series=11745 Once that patch set is applied, new guide instructions works well. Also, one small nit, if you're pusing another version of the patch set (don't worry about it of you're not), maybe something to consider for the patch description: While make has been deprecated for DPDK, it's still applicable for some example apps, this patch set adjusts the guides to take that into consideration. Thanks, Dave.