Re: [dpdk-dev] [PATCH v2] eal: fix positive error codes from probe/remove

[Ilya Maximets <i.maximets@samsung.com>]

On 06.06.2019 13:02, Ilya Maximets wrote:
> According to API, 'rte_dev_probe()' and 'rte_dev_remove()' must
> return 0 or negative error code. Bus code returns positive values
> if device wasn't recognized by any driver, so the result of
> 'bus->plug/unplug()' must be converted. 'local_dev_probe()' and
> 'local_dev_remove()' also has their internal API, so the conversion
> should be done there.
> 
> Positive on remove means that device not found by driver.
> Positive on probe means that there are no suitable buses/drivers,
> i.e. device is not supported.
> 
> Users of these API fixed to provide a good example by respecting
> DPDK API. This also will allow to catch such issues in the future.
> 
> CC: stable@dpdk.org
> Fixes: a3ee360f4440 ("eal: add hotplug add/remove device")
> Fixes: 244d5130719c ("eal: enable hotplug on multi-process")
> 
> Signed-off-by: Ilya Maximets <i.maximets@samsung.com>
> ---
> 
> Version 2:
> 
>     * Fixed API callers.
>     * Check for probe moved from 'rte_dev_probe' to 'local_dev_probe'.
> 
>  app/test-pmd/testpmd.c                 | 4 ++--
>  drivers/net/failsafe/failsafe.c        | 2 +-
>  drivers/net/failsafe/failsafe_eal.c    | 4 ++--
>  drivers/net/failsafe/failsafe_ether.c  | 2 +-
>  drivers/net/vdev_netvsc/vdev_netvsc.c  | 2 +-
>  lib/librte_eal/common/eal_common_dev.c | 5 ++++-
>  6 files changed, 11 insertions(+), 8 deletions(-)


Any more thoughts on this patch? Or can it be merged?

Best regards, Ilya Maximets.