From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A021045BB1; Mon, 28 Oct 2024 14:35:33 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 77B1B40E0B; Mon, 28 Oct 2024 14:35:33 +0100 (CET) Received: from smtp-gw.pt.net (smtp-gw.pt.net [206.210.192.15]) by mails.dpdk.org (Postfix) with ESMTP id D0411400D7 for ; Mon, 28 Oct 2024 14:35:31 +0100 (CET) X-ASG-Debug-ID: 1730122530-09411a490e388bd0001-TfluYd Received: from mail.pt.net (mail.pt.net [206.210.194.11]) by smtp-gw.pt.net with ESMTP id Xo5Lcxud18qAHEVt (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Mon, 28 Oct 2024 08:35:30 -0500 (CDT) X-Barracuda-Envelope-From: lew@perftech.com X-Barracuda-Effective-Source-IP: mail.pt.net[206.210.194.11] X-Barracuda-Apparent-Source-IP: 206.210.194.11 Received: from localhost (localhost [IPv6:::1]) by mail.pt.net (Postfix) with ESMTP id 9CC87269033; Mon, 28 Oct 2024 08:35:30 -0500 (CDT) Received: from mail.pt.net ([IPv6:::1]) by localhost (mail.pt.net [IPv6:::1]) (amavis, port 10032) with ESMTP id yYXyHerpUHnv; Mon, 28 Oct 2024 08:35:30 -0500 (CDT) Received: from localhost (localhost [IPv6:::1]) by mail.pt.net (Postfix) with ESMTP id 258FA26911D; Mon, 28 Oct 2024 08:35:30 -0500 (CDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.pt.net 258FA26911D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=perftech.com; s=B15A3A56-ABEA-11EE-9719-5F12F125680F; t=1730122530; bh=APiucCo7vAC+57JIudwL9Zj3ahkVC7by2zF61DUmTkE=; h=Date:From:To:Message-ID:MIME-Version; b=n3ytn7xNNSSGq/Rzg9VmTgD/DnqW5iksctBmUTKtHS6CZevyitMUPAKaQgTkggZjH xYCs5x7S/CEpmJqkyn9R2Qj8CfA3HoZAwvIsdrReUAi+k8MMnjYloYNb2mOIl7mMqG PVZpT/7eEYlLtOc5ZWHgpDyQSSAE/I4iFef63Yg10nZD6FafxsPPsbhLkC8RpUFnsZ yL8WlVHb2KFzuHyukLNfpPA/kctI894f5eF+MJxd2kTw+4K481VheYIxvIwjTTukaJ 9ogtI6HeWePk52msyUZLxAII0lH/4jNOSrnROkxmVpeoVo7m9bIL6l3B8rk05TGhH5 uoGG+mnQa4R6Q== X-Virus-Scanned: amavis at pt.net Received: from mail.pt.net ([IPv6:::1]) by localhost (mail.pt.net [IPv6:::1]) (amavis, port 10026) with ESMTP id RBWms1H4gMjI; Mon, 28 Oct 2024 08:35:30 -0500 (CDT) Received: from mail.pt.net (mail.pt.net [206.210.194.11]) by mail.pt.net (Postfix) with ESMTP id 0A547269032; Mon, 28 Oct 2024 08:35:30 -0500 (CDT) Date: Mon, 28 Oct 2024 08:35:29 -0500 (CDT) From: Lewis Donzis To: Dmitry Kozlyuk Cc: dev , anatoly burakov , Stephen Hemminger , Morten =?iso-8859-1?Q?Br=F8rup?= Message-ID: <1285938349.226037.1730122529843.JavaMail.zimbra@donzis.com> In-Reply-To: <20241028162606.48381738@sovereign> References: <20241023231859.1323727-1-kozlyuk@bifit.com> <20241025202615.2581513-1-dmitry.kozliuk@gmail.com> <20241025202615.2581513-2-dmitry.kozliuk@gmail.com> <1865717992.9940628.1729942988633.JavaMail.zimbra@donzis.com> <20241028162606.48381738@sovereign> Subject: Re: [PATCH v2 1/2] contigmem: support including mapped buffers in core dump MIME-Version: 1.0 X-ASG-Orig-Subj: Re: [PATCH v2 1/2] contigmem: support including mapped buffers in core dump Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Originating-IP: [206.210.194.11] X-Mailer: Zimbra 8.8.15_GA_4652 (ZimbraWebClient - GC130 (Mac)/8.8.15_GA_4652) Thread-Topic: contigmem: support including mapped buffers in core dump Thread-Index: FlHwQPGFpcJII7y7llOaVF+YQUCalw== X-Barracuda-Connect: mail.pt.net[206.210.194.11] X-Barracuda-Start-Time: 1730122530 X-Barracuda-Encrypted: TLS_AES_256_GCM_SHA384 X-Barracuda-URL: https://smtp-gw.pt.net:443/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at pt.net X-Barracuda-Scan-Msg-Size: 1286 X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using global scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=9.0 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.132419 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org It seems unlikely that there are other users of contigmem on FreeBSD, especially since it's not necessary for other applications. On FreeBSD, use of large and huge pages is automatic; you just call mmap() with a large size and it automatically tries to use the largest physical pages possible. So the only thing contigmem is doing for us on FreeBSD is providing the physical address and, of course, making it consistent with Linux. At least, that's my understanding. ----- On Oct 28, 2024, at 8:26 AM, Dmitry Kozlyuk dmitry.kozliuk@gmail.com wrote: > 2024-10-26 06:43 (UTC-0500), Lewis Donzis: >> Is the extra control necessary, i.e., why not just always do this and let >> the EAL option control whether the pages get dumped? > > I've been evaluating your suggestion and see no downsides, > except contigmem default behavior change, but does it have non-DPDK users? > If no one objects, I'll prepare v3 doing the following: > 1) everything from v2, > 2) except always mark contigmem buffers as dumpable, > 3) add --dump-mapped back and make DPDK disable dumping by default. > As a result, in order to include mapped memory in coredump: > * FreeBSD will require only "--dump-mapped"; > * Linux will require both "coredump_filter" setup and "--dump-mapped".