* [dpdk-dev] [PATCH] app/testpmd: remove port status check from TM hierarchy commit cli
@ 2017-10-27 9:46 Jasvinder Singh
2017-11-07 6:38 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Jasvinder Singh @ 2017-10-27 9:46 UTC (permalink / raw)
To: dev; +Cc: wenzhuo.lu, yulong.pei
Some drivers might allow to commit the traffic management hierarchy
while being in running state. Therefore, removes port status check
before invoking hierarchy commit API in the cli. If needed, device can
add port status check at the driver layer.
Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
---
app/test-pmd/cmdline_tm.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/app/test-pmd/cmdline_tm.c b/app/test-pmd/cmdline_tm.c
index 964ce9d..53f941c 100644
--- a/app/test-pmd/cmdline_tm.c
+++ b/app/test-pmd/cmdline_tm.c
@@ -2033,12 +2033,6 @@ static void cmd_port_tm_hierarchy_commit_parsed(void *parsed_result,
if (port_id_is_invalid(port_id, ENABLED_WARN))
return;
- /* Port status */
- if (port_is_started(port_id)) {
- printf(" Port %u not stopped (error)\n", port_id);
- return;
- }
-
if (strcmp(res->clean_on_fail, "yes") == 0)
clean_on_fail = 1;
else
--
2.9.3
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] app/testpmd: remove port status check from TM hierarchy commit cli
2017-10-27 9:46 [dpdk-dev] [PATCH] app/testpmd: remove port status check from TM hierarchy commit cli Jasvinder Singh
@ 2017-11-07 6:38 ` Ferruh Yigit
2017-11-07 6:42 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Ferruh Yigit @ 2017-11-07 6:38 UTC (permalink / raw)
To: Jasvinder Singh, dev; +Cc: wenzhuo.lu, yulong.pei
On 10/27/2017 2:46 AM, Jasvinder Singh wrote:
> Some drivers might allow to commit the traffic management hierarchy
> while being in running state. Therefore, removes port status check
> before invoking hierarchy commit API in the cli. If needed, device can
> add port status check at the driver layer.
>
> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] app/testpmd: remove port status check from TM hierarchy commit cli
2017-11-07 6:38 ` Ferruh Yigit
@ 2017-11-07 6:42 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2017-11-07 6:42 UTC (permalink / raw)
To: Jasvinder Singh, dev; +Cc: wenzhuo.lu, yulong.pei
On 11/6/2017 10:38 PM, Ferruh Yigit wrote:
> On 10/27/2017 2:46 AM, Jasvinder Singh wrote:
>> Some drivers might allow to commit the traffic management hierarchy
>> while being in running state. Therefore, removes port status check
>> before invoking hierarchy commit API in the cli. If needed, device can
>> add port status check at the driver layer.
>>
>> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied to dpdk/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-07 6:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-27 9:46 [dpdk-dev] [PATCH] app/testpmd: remove port status check from TM hierarchy commit cli Jasvinder Singh
2017-11-07 6:38 ` Ferruh Yigit
2017-11-07 6:42 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).