From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B5693A04EF; Mon, 1 Jun 2020 23:14:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1A0631BFEE; Mon, 1 Jun 2020 23:14:47 +0200 (CEST) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by dpdk.org (Postfix) with ESMTP id 1DF8A1BFE4 for ; Mon, 1 Jun 2020 23:14:45 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id 33EDC5801E7; Mon, 1 Jun 2020 17:14:44 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Mon, 01 Jun 2020 17:14:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= 2mlU/D5Qu7Vy9Y49ZBwbJ1isuP+TJ0LuqdAXw4m8i5k=; b=AEPkE3P93S7q1vsG uju0UXSnl0FpuoqL5q7+DbpzFf9meGzEXWDys5x1iyRNve4DyWmc4PpS7kAh4H9/ BXKEa2kZpSysr04KpDuGO7fxoAaOx4XMdg5k07DkaPF5fUcR8Ugav5wdekdCAwZt sH6bMsxltU97XTEqmHu23AMOzEkG2cYihdu/ZijST4lg71ItBfgsYe/pp3UAMJnz wgKKT3GsXzNRaJ4Qmt5fwW4JuCCHxZZSIttMGTolwBBz7UWIIPxwmKS7ndI0D2OT nzwo2s1Th2lyK3c5HnUklb1bx4JfHAwSi5gGwaS1Nom9XCkvUfldCZdBJxkzCvKD u2o2lQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=2mlU/D5Qu7Vy9Y49ZBwbJ1isuP+TJ0LuqdAXw4m8i 5k=; b=1kJ6T4IJm8n4fFu1uuuO5hauz3SumCV5kG4j8HCw8QtumKPRqLFlck/Iv LjvWb1gD0S6Oe2JfNWGtNKnWW100P6P8V9pMs0zOxjfULko59ruN7phkoAX00IKG 9LrCtzP2vGyfsq8lCWLWWVPtKKMacV9j1KCP6Cmw2l/Wd3+j/hgd57zkRAnD7cYU cGqJe9gQ9gAhh2Z4D7ti6bdEcu4NjY+UcIQgdiqlrpOfxcKNnc1N5ppX+gb6LPCv CtwOKjWddua6MWwxQ7Qpm01UGmYwQ29nMmQcMpfAo7eFrrznITbEIvyNOOnik9IN 3tAbFc60Auc0HuRQyAcpQbE3SOt9g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudefhedgudehtdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 13F6D30624F3; Mon, 1 Jun 2020 17:14:41 -0400 (EDT) From: Thomas Monjalon To: Dmitry Kozlyuk Cc: Fady Bader , dev@dpdk.org, tbashar@mellanox.com, talshn@mellanox.com, yohadt@mellanox.com, harini.ramakrishnan@microsoft.com, ocardona@microsoft.com, pallavi.kadam@intel.com, ranjit.menon@intel.com, olivier.matz@6wind.com, arybchenko@solarflare.com, mdr@ashroe.eu, nhorman@tuxdriver.com Date: Mon, 01 Jun 2020 23:14:41 +0200 Message-ID: <12936534.z0KI8IRTVO@thomas> In-Reply-To: <20200601225921.371ebfa6@sovereign> References: <20200601103139.8612-1-fady@mellanox.com> <20200601103139.8612-3-fady@mellanox.com> <20200601225921.371ebfa6@sovereign> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 2/4] mempool: use generic memory management X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 01/06/2020 21:59, Dmitry Kozlyuk: > 1. What do you think about changing rte_ to rte_eal_ prefix for memory > management wrappers in MM series as Andrew Rybchenko suggested for v1? Since > the functions are DPDK-internal, this sounds reasonable to me. For lib-internal function, the prefix should not start with rte_. For exported function (even if internal), the prefix should be rte_[component]_. For memory related functions, rte_mem_ is better than rte_eal_.