From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f54.google.com (mail-wg0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id 752D55A51 for ; Thu, 9 Jul 2015 03:59:08 +0200 (CEST) Received: by wgjx7 with SMTP id x7so210404582wgj.2 for ; Wed, 08 Jul 2015 18:59:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=BC5QUW/z0IJNQ2q0mR4MpcqHS3Yl02T10pqpOK5qFuI=; b=XLoG/k9Oh291ZDtPfkshBv6VG6pnYaaUJa14J8IyuQdPJorMHTEmU/Xz6klh/tfsqY NzukXuFtUtA476x+cabxbjavR/xlwjUzLRUGynXW0Ew0fu1t6W9d16lkjPvWk+rypYBM z1MUtR8ZrZ4NCzZRiYQvcqLXJ6b/nReRGlVO1cYx3hwxJwcVwTEExZmL1pODbW/fuziM MdofGwAyiFd/hY1d7iYI+HAy+/F0PRFVRPSjwlDwgRtF4qt1H2bZFNA3vSsw2/AymBzI HMvdXkWJlMEJWPg1Zn8kcLQDOMacFWXCNckEACWcRiuw4RSUN+9mtLXC7yAtfIpkkeae fwjw== X-Gm-Message-State: ALoCoQl3w0qCB0KZXgkenW+/3o3WVROPUFGp6bYhzxAs64V3yin047Zso9rg6Xod4UVvGUosVLjg X-Received: by 10.194.59.212 with SMTP id b20mr23789401wjr.31.1436407148349; Wed, 08 Jul 2015 18:59:08 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id ul1sm6160956wjc.30.2015.07.08.18.59.07 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 Jul 2015 18:59:07 -0700 (PDT) From: Thomas Monjalon To: Tomasz Kulasek Date: Thu, 09 Jul 2015 03:58:02 +0200 Message-ID: <12941587.YRQEe5TYyV@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: <1435589444-1988-6-git-send-email-tomaszx.kulasek@intel.com> References: <1434723200-7528-1-git-send-email-tomaszx.kulasek@intel.com> <1435589444-1988-1-git-send-email-tomaszx.kulasek@intel.com> <1435589444-1988-6-git-send-email-tomaszx.kulasek@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3 5/8] ring: queue stats mapping set dummy implementation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jul 2015 01:59:08 -0000 2015-06-29 16:50, Tomasz Kulasek: > Per queue statistics are already implemented for ring device, but with > static mapping (stat_idx == queue_id). > > This fix is required, if you want to use ring device in test application > and is used only to point that per queue statistics are provided for this > device. > > Signed-off-by: Tomasz Kulasek [...] > +static int > +eth_queue_stats_mapping_set(__rte_unused struct rte_eth_dev *dev, > + __rte_unused uint16_t queue_id, __rte_unused uint8_t stat_idx, > + __rte_unused uint8_t is_rx) > +{ > + /* Do nothing, just return ok */ > + return 0; > +} I've just realized how this is broken. Some Intel devices use a mapping to select hardware queues which will have some stats. But we may have stats per queues without requiring such mapping. I may miss something but I suggest these 3 actions: - remove this patch - replace checks on stats_mapping by an ethdev flag - remove device-specific stats_mapping from ethdev