From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8642B45B5F; Thu, 17 Oct 2024 17:46:12 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 32F2E4025F; Thu, 17 Oct 2024 17:46:12 +0200 (CEST) Received: from fhigh-a6-smtp.messagingengine.com (fhigh-a6-smtp.messagingengine.com [103.168.172.157]) by mails.dpdk.org (Postfix) with ESMTP id 87B614021E for ; Thu, 17 Oct 2024 17:46:10 +0200 (CEST) Received: from phl-compute-05.internal (phl-compute-05.phl.internal [10.202.2.45]) by mailfhigh.phl.internal (Postfix) with ESMTP id 05125114059D; Thu, 17 Oct 2024 11:46:10 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-05.internal (MEProxy); Thu, 17 Oct 2024 11:46:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1729179970; x=1729266370; bh=FgHA62xkSKVt1NTBxhUU4VlCM2XXHP9IxYYbf4c4jPk=; b= OZaoCai5hqyHMV/9rgMJ1vWiXUU6BH0X6nZzaHQ+WM8ofvG+5QwtehAlwLFTbDBk YYJ0O9lsvGLiCpT6YjRUV7a9sjwPjaIJ8OqGibSrv7JL3YVo8EngkY7DVplE/1vw KI3KpggZ/2kOhMPYOfhjfLcKLMf0sUVcDJ7ET0LyPT+mlJcArmSAz8AXQD+ABl0K cUreZh+VuuFKkfDfUR4bfS5AQ/tXCNAIHdu1yGAbYIBLuzD64FdubHAdKoGBgf1p OGJYJ0TN19JJ6kspMs0d3DAFR3HgupJP65XyzCvXY6w/X2280npQ89G9y4K1LZiA 4fAAVun2e9JCq9sjq5LOuw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1729179970; x= 1729266370; bh=FgHA62xkSKVt1NTBxhUU4VlCM2XXHP9IxYYbf4c4jPk=; b=A nb+YoGskpp3+Cnc7kNyyy4bNCYmRk8/ekoNvNtmV2OuVX+0uJbLh6IScgLQ+Pt4H do+WGJ91tfJveSzmoUbWEKbYCPlC0KgUTOnopfOx38jaa2SLtT/qCq7frIvqHRQT SexUJRGbAoY7LDRBXApeg9u1xva2lzOEIQwCULev/URA0D8PsvV9+GDkc3UEj+my /lrzUv49IXOCy2EykqMyZhB6rAlm+PKS14NR+AkqCOgXToyRNhKDyMuUIrm2kewY zu5hCANSAROWGEFmOpouaw92hnmNyJWVsu/DWJvp16Q46W9k9jwywlQrPMqOXneo 48l8vTnNQ967p/4/zDRJg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdehuddgleegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhephffvvefufffkjghfggfgtgesthfuredttddtjeen ucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrg hlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpeejudevheeiveduuddtveffgfdtgeek ueevjeffjeegtdeggeekgfdvuefgfeekjeenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtpdhn sggprhgtphhtthhopeefpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehgrdhsih hnghhhsehngihprdgtohhmpdhrtghpthhtohepsghruhgtvgdrrhhitghhrghrughsohhn sehinhhtvghlrdgtohhmpdhrtghpthhtohepuggvvhesughpughkrdhorhhg X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 17 Oct 2024 11:46:09 -0400 (EDT) From: Thomas Monjalon To: Gagandeep Singh Cc: Bruce Richardson , dev@dpdk.org Subject: Re: [v1 1/3] meson: add a meson option to install examples Date: Thu, 17 Oct 2024 17:46:07 +0200 Message-ID: <12973403.iMDcRRXYNz@thomas> In-Reply-To: References: <20240806134218.3619913-1-g.singh@nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 07/08/2024 06:09, Gagandeep Singh: > From: Bruce Richardson > > On Tue, Aug 06, 2024 at 07:12:16PM +0530, Gagandeep Singh wrote: > > > Adding a meson option "enable_examples_bin_install" > > > to install the examples binaries in bin. > > > > > > Default value is false. > > > > > > Signed-off-by: Gagandeep Singh > > > --- > > > examples/meson.build | 13 ++++++++++++- > > > meson_options.txt | 2 ++ > > > 2 files changed, 14 insertions(+), 1 deletion(-) > > > > > Is there a particular reason we might want to do this? Installing sample code > > binaries in bin seems rather strange to me. > > > Currently, I can see only app binaries are getting installed in bin but not examples binaries. I am not able to > find the particular reason behind this. > The main reason to have the examples in installation directory is to provides a convenient > way for users to explore DPDK's examples without having to manually scan each example build directory and copy them in > their package. > The default behavior remains unchanged. It does not make sense to me. Examples must be seen as a doc. We are compiling them mostly to check there is no error. Running an example should be educational only, no need to install it somewhere else. I'm afraid this patch is deviating from the intent behind examples.