From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1DCA7A09FF; Tue, 5 Jan 2021 11:45:16 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9548B1607F0; Tue, 5 Jan 2021 11:45:15 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 984341607E9 for ; Tue, 5 Jan 2021 11:45:13 +0100 (CET) IronPort-SDR: S2IrmSndEBu+3ag5E9tiNopCW1Jugth/IQUVYUSX9drVxYlTfIo80UpfQViFhpRhAmQNV5op3b DfHDCwVtv81Q== X-IronPort-AV: E=McAfee;i="6000,8403,9854"; a="177240012" X-IronPort-AV: E=Sophos;i="5.78,476,1599548400"; d="scan'208";a="177240012" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jan 2021 02:45:12 -0800 IronPort-SDR: jKFyMC9YeF+9Ac6HfDnAmBQ9TaOtpUvC8L9xNTwiKWyzVRGbBbTuQ1xmR1O/qZwJPqDrOMFEY9 0Tdu5GMw7Fpg== X-IronPort-AV: E=Sophos;i="5.78,476,1599548400"; d="scan'208";a="421734975" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.236.177]) ([10.213.236.177]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jan 2021 02:45:10 -0800 To: "Guo, Jia" , Souvik Dey , "Xing, Beilei" , "Zhang, Qi Z" Cc: "dev@dpdk.org" , Kevin Traynor , Luca Boccassi References: <20201212130525.14656-1-sodey@rbbn.com> <20201215132815.15200-1-sodey@rbbn.com> <04670cb0b85b4b1c90ae264639372754@intel.com> <8295f154-93cc-8be7-4697-994e98b5e4be@intel.com> <236c50f285ed48fbaa1544321d365b2f@intel.com> From: Ferruh Yigit Message-ID: <129a8246-6376-744f-dc98-b8b978bf176c@intel.com> Date: Tue, 5 Jan 2021 10:45:06 +0000 MIME-Version: 1.0 In-Reply-To: <236c50f285ed48fbaa1544321d365b2f@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v3] net/i40e: issue with ADD VLAN from Guest X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/5/2021 3:07 AM, Guo, Jia wrote: > >> -----Original Message----- >> From: Ferruh Yigit >> Sent: Tuesday, January 5, 2021 12:43 AM >> To: Guo, Jia ; Souvik Dey ; Xing, >> Beilei ; Zhang, Qi Z >> Cc: dev@dpdk.org; Kevin Traynor ; Luca Boccassi >> >> Subject: Re: [dpdk-dev] [PATCH v3] net/i40e: issue with ADD VLAN from >> Guest >> >> On 12/16/2020 2:09 AM, Guo, Jia wrote: >>> Acked-by: Jeff Guo > >>> >>> From: Souvik Dey >>> Sent: Tuesday, December 15, 2020 9:28 PM >>> To: Xing, Beilei ; Guo, Jia >>> ; Zhang, Qi Z >>> Cc: dev@dpdk.org; Souvik Dey >>> Subject: [PATCH v3] net/i40e: issue with ADD VLAN from Guest >>> >>> Reset the configuration of vlan strip that would be change by the pf >>> kernel driver when adding vlan from vf. >>> Application cannot use rte_eth_dev_set_vlan_offload() to set the >>> VLAN_STRIP, as this will only work for the first time when original >>> and current config mismatch, but for all subsequent call it will be >>> ignored. >>> >>> Signed-off-by: Souvik Dey > >> >> I suggest title: "net/i40e: fix VLAN stripping in VF" >> Will update the title and some wording in the commit log while merging. >> >> And I assume this should be backported, so will add stable@dpdk.org tag, >> but can you please confirm the Linux PF behavior was always same? >> >> And if the Linux PF behavior was always same, should we add the DPDK >> commit as fixes commit, @Qi, @Jeff, what do you think? >> >> Other question is, does Linux PF and DPDK PF behave differently on enabling >> VLAN stripping and should it be unified to be consistent? > > Yes, it does have different behave when enabling VLAN stripping in DPDK PF and Linux PF, and not always the same in linux PFs, but this patch set could be an workaround in DPDK PF for the compatibility. > OK, and since the patch is safe from Linux PF point of view, I will add following fixline, which is the initial DPDK code that adds VF VLAN add support: Fixes: 4861cde46116 ("i40e: new poll mode driver") Cc: stable@dpdk.org -- Thanks, ferruh