DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Wang, Yixue" <yixue.wang@intel.com>,
	"Yang, Qiming" <qiming.yang@intel.com>
Cc: "Zhang, Liheng" <liheng.zhang@intel.com>,
	"Dong, Yao" <yao.dong@intel.com>, "dev@dpdk.org" <dev@dpdk.org>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] net/ice: fix data path corrupt on secondary process
Date: Fri, 4 Jun 2021 07:21:26 +0000	[thread overview]
Message-ID: <129c9990e2ee42f0a5c9b423deadf107@intel.com> (raw)
In-Reply-To: <SA2PR11MB47931FDCF9F7000BAE69D50F863B9@SA2PR11MB4793.namprd11.prod.outlook.com>



> -----Original Message-----
> From: Wang, Yixue <yixue.wang@intel.com>
> Sent: Friday, June 4, 2021 2:52 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Yang, Qiming
> <qiming.yang@intel.com>
> Cc: Zhang, Liheng <liheng.zhang@intel.com>; Dong, Yao
> <yao.dong@intel.com>; dev@dpdk.org; stable@dpdk.org
> Subject: RE: [PATCH v2] net/ice: fix data path corrupt on secondary process
> 
> Hi Qi,
> 
> Patch v2 has been tested.
> 
> Best Regards,
> Yixue.
> 
> > -----Original Message-----
> > From: Zhang, Qi Z <qi.z.zhang@intel.com>
> > Sent: Wednesday, May 26, 2021 14:13
> > To: Yang, Qiming <qiming.yang@intel.com>
> > Cc: Zhang, Liheng <liheng.zhang@intel.com>; Wang, Yixue
> > <yixue.wang@intel.com>; Dong, Yao <yao.dong@intel.com>; dev@dpdk.org;
> > Zhang, Qi Z <qi.z.zhang@intel.com>; stable@dpdk.org
> > Subject: [PATCH v2] net/ice: fix data path corrupt on secondary
> > process
> >
> > The rte_eth_devices array is not in share memory, it should not be
> > referenced by ice_adapter which is shared by primary and secondary.
> > Any process set ice_adapter->eth_dev will corrupt another process'
> > context.
> >
> > The patch removed the field "eth_dev" from ice_adapter.
> > Now, when the data paths try to access the rte_eth_dev_data instance,
> > they should replace adapter->eth_dev->data with adapter->pf.dev_data.
> >
> > Fixes: f9cf4f864150 ("net/ice: support device initialization")
> > Cc: stable@dpdk.org
> >
> > Reported-by: Yixue Wang <yixue.wang@intel.com>
> > Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
Tested-by: Yixue Wang <yixue.wang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi

      reply	other threads:[~2021-06-04  7:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-26  5:59 [dpdk-dev] [PATCH] " Qi Zhang
2021-05-26  6:12 ` [dpdk-dev] [PATCH v2] " Qi Zhang
2021-06-04  6:51   ` Wang, Yixue
2021-06-04  7:21     ` Zhang, Qi Z [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=129c9990e2ee42f0a5c9b423deadf107@intel.com \
    --to=qi.z.zhang@intel.com \
    --cc=dev@dpdk.org \
    --cc=liheng.zhang@intel.com \
    --cc=qiming.yang@intel.com \
    --cc=stable@dpdk.org \
    --cc=yao.dong@intel.com \
    --cc=yixue.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).