From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B0FCDA0A02; Fri, 4 Jun 2021 09:21:32 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 47D2940147; Fri, 4 Jun 2021 09:21:32 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id B68D64003C; Fri, 4 Jun 2021 09:21:30 +0200 (CEST) IronPort-SDR: MeEJ6VdumxhjBBLfdR+3I0wSrnnke+R+8jvHjgGpvKizrsddD2sU9e4JKKXSyqZFNrsjAr7XCu lYQhKI9tPZ/Q== X-IronPort-AV: E=McAfee;i="6200,9189,10004"; a="204052538" X-IronPort-AV: E=Sophos;i="5.83,247,1616482800"; d="scan'208";a="204052538" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jun 2021 00:21:29 -0700 IronPort-SDR: 7QWUSZbg5k8kZMostzldo7DE2QvEex3eOGLAyVC14geQ0M7JBH3tjEah1rxH518yTzO28bjZyH kFXlX5QzOMLQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,247,1616482800"; d="scan'208";a="483800147" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga002.fm.intel.com with ESMTP; 04 Jun 2021 00:21:29 -0700 Received: from shsmsx602.ccr.corp.intel.com (10.109.6.142) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Fri, 4 Jun 2021 00:21:28 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX602.ccr.corp.intel.com (10.109.6.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Fri, 4 Jun 2021 15:21:26 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.2242.008; Fri, 4 Jun 2021 15:21:26 +0800 From: "Zhang, Qi Z" To: "Wang, Yixue" , "Yang, Qiming" CC: "Zhang, Liheng" , "Dong, Yao" , "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH v2] net/ice: fix data path corrupt on secondary process Thread-Index: AQHXUfW2NUuigRP+Q0SkwBSNYeKaI6sC8hMAgACOUPA= Date: Fri, 4 Jun 2021 07:21:26 +0000 Message-ID: <129c9990e2ee42f0a5c9b423deadf107@intel.com> References: <20210526055923.1024336-1-qi.z.zhang@intel.com> <20210526061256.1024478-1-qi.z.zhang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] net/ice: fix data path corrupt on secondary process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Wang, Yixue > Sent: Friday, June 4, 2021 2:52 PM > To: Zhang, Qi Z ; Yang, Qiming > > Cc: Zhang, Liheng ; Dong, Yao > ; dev@dpdk.org; stable@dpdk.org > Subject: RE: [PATCH v2] net/ice: fix data path corrupt on secondary proce= ss >=20 > Hi Qi, >=20 > Patch v2 has been tested. >=20 > Best Regards, > Yixue. >=20 > > -----Original Message----- > > From: Zhang, Qi Z > > Sent: Wednesday, May 26, 2021 14:13 > > To: Yang, Qiming > > Cc: Zhang, Liheng ; Wang, Yixue > > ; Dong, Yao ; dev@dpdk.org; > > Zhang, Qi Z ; stable@dpdk.org > > Subject: [PATCH v2] net/ice: fix data path corrupt on secondary > > process > > > > The rte_eth_devices array is not in share memory, it should not be > > referenced by ice_adapter which is shared by primary and secondary. > > Any process set ice_adapter->eth_dev will corrupt another process' > > context. > > > > The patch removed the field "eth_dev" from ice_adapter. > > Now, when the data paths try to access the rte_eth_dev_data instance, > > they should replace adapter->eth_dev->data with adapter->pf.dev_data. > > > > Fixes: f9cf4f864150 ("net/ice: support device initialization") > > Cc: stable@dpdk.org > > > > Reported-by: Yixue Wang > > Signed-off-by: Qi Zhang Tested-by: Yixue Wang Applied to dpdk-next-net-intel. Thanks Qi