From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Rastislav Cernay <cernay@netcope.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] net/nfb: remove resources when port is closed
Date: Tue, 27 Aug 2019 13:08:52 +0100 [thread overview]
Message-ID: <12b48c71-8540-9156-29f7-536891c8f351@intel.com> (raw)
In-Reply-To: <1565608778-17185-1-git-send-email-cernay@netcope.com>
On 8/12/2019 12:19 PM, Rastislav Cernay wrote:
> From: Rastislav Cernay <cernay@netcope.com>
>
> The rte_eth_dev_close() function now handles freeing resources for
> devices (e.g., mac_addrs). To conform with the new close() behaviour we
> are asserting the RTE_ETH_DEV_CLOSE_REMOVE flag so that
> rte_eth_dev_close() releases all device level dynamic memory.
>
> Signed-off-by: Rastislav Cernay <cernay@netcope.com>
> Acked-by: Jan Remes <remes@netcope.com>
> Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>
> ---
> v2: remove unnecessary cast
> drivers/net/szedata2/rte_eth_szedata2.c | 14 ++++++++++----
> 1 file changed, 10 insertions(+), 4 deletions(-)
Hi Rastislav,
The first version of this patch is for 'nfb' driver [1], ack/review is based on
that path. But this patch, v2, is for 'szedata2' driver. It looks like something
went wrong.
But both driver needs this update, can you please send a proper new version for
'nfb' (v3) and a new 'szedata2' patch?
Thanks,
ferruh
[1]
https://mails.dpdk.org/archives/dev/2019-August/140864.html
next prev parent reply other threads:[~2019-08-27 12:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-09 14:59 [dpdk-dev] [PATCH] net/nfb: remove resources when dev " Rastislav Cernay
2019-08-09 15:01 ` Jan Remeš
2019-08-10 12:51 ` Ye Xiaolong
2019-08-12 11:19 ` [dpdk-dev] [PATCH v2] net/nfb: remove resources when port " Rastislav Cernay
2019-08-27 12:08 ` Ferruh Yigit [this message]
2019-08-27 20:37 ` [dpdk-dev] [PATCH v3] " Rastislav Cernay
2019-08-28 17:20 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12b48c71-8540-9156-29f7-536891c8f351@intel.com \
--to=ferruh.yigit@intel.com \
--cc=cernay@netcope.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).