From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AEED5459CC; Wed, 18 Sep 2024 15:59:39 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 98709402D5; Wed, 18 Sep 2024 15:59:39 +0200 (CEST) Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) by mails.dpdk.org (Postfix) with ESMTP id B760F4003C for ; Wed, 18 Sep 2024 15:59:38 +0200 (CEST) Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-5c275491c61so1942948a12.0 for ; Wed, 18 Sep 2024 06:59:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; s=google; t=1726667978; x=1727272778; darn=dpdk.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XqqJJMVD+IqNaFbP50PdNAhs5Ong6AOWh7L1D8D8/sY=; b=MICFqIJeQT08eUK3iMWifp+01dG6az3Qi1krwMFRRIfBgq8g+FrkYs0lPGVHwSN1Y8 BapQS5I2yZ18DOsPyyj+Ok4318FYUwraPHpk+PcvGfAOL2QS2BcfCtozRCpVXaZP2kB+ Fjqryi/opbdmD7drhp2mKnmJmwIOOuXVxi3T8oz6rJ04McrD45miSXTEMG/UAmq6r6mb fTWSvBhYDMIhjsL1nnkpihqT3fAwuROGYer5UblB/7opgcf0KfAKGpMrZwob2BL3Tq8o 2Zb0DzMO/zf+yNKl/0RXCFwRVG2F/+gyyvf+QyUfuykfMJCFtQLTOTv+/cbRl+nQ9OKZ I4QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726667978; x=1727272778; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XqqJJMVD+IqNaFbP50PdNAhs5Ong6AOWh7L1D8D8/sY=; b=NjfQJ5I8i54d2a5e3NgDzNp1LUyKlt+MKtRvAbGXu5wyp0uY5X+O2/+qi9pWxWVJGY WUJ6A9t2nAq/Devb3Zd3LFJxTrMIJWfppTxs62A85778BfuShQ4fnx3kMTXUK9QiZIL2 hHleLM3FUo8cPYKAP1NvKUsHeZwsD5cUvVxkdG5NcImWINgp9X1VeTHwYy+DwyUMnO61 8nX7Gi+o3VTKNc54pQ1ObaqK9REtYIYMSML8N8e9x2n/n0OOGIi8Px2qxyNErOxTKiT8 oXlkra8+5QrGO5t3VNBLBRMNba4T5BZr13W52zEnYpoi1/2ab5nC2F2losYGJCxgoBi9 lpWg== X-Forwarded-Encrypted: i=1; AJvYcCVQ0ZJkzN41X5yNyBhOEqghoPTsH9XVqaXAvOEDDs+lmK5Bi7N4yUk1HD3Wxzkkn2+Sr/c=@dpdk.org X-Gm-Message-State: AOJu0Yz8Q8bXtWkoQGnn7Qsqud0RHYQZY6cInblno51vzf8xu648D6al I7vwKbIHyKl78lhG9PJg5eyyKmAnvJgXIzEOtHo5zTsMpO0bidcNFs8bh9UxVE4= X-Google-Smtp-Source: AGHT+IF/q5P2TqfwUHiwiywchQqkYX7hREu4XCRnjrR6TWymtIfLBBmNcHtbRB7kxWGgfNISYxypxg== X-Received: by 2002:a05:6402:40c5:b0:5c4:23a4:ad54 with SMTP id 4fb4d7f45d1cf-5c423a4afc7mr15748564a12.32.1726667978086; Wed, 18 Sep 2024 06:59:38 -0700 (PDT) Received: from [192.168.200.22] ([84.245.121.62]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c42bb533besm4992994a12.26.2024.09.18.06.59.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Sep 2024 06:59:37 -0700 (PDT) Message-ID: <12b594f5-40c2-4b6d-a56b-629daabc022f@pantheon.tech> Date: Wed, 18 Sep 2024 15:59:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 11/12] dts: add Rx offload capabilities To: Dean Marx Cc: thomas@monjalon.net, Honnappa.Nagarahalli@arm.com, jspewock@iol.unh.edu, probb@iol.unh.edu, paul.szczepanek@arm.com, Luca.Vizzarro@arm.com, npratte@iol.unh.edu, alex.chapman@arm.com, dev@dpdk.org References: <20240301155416.96960-1-juraj.linkes@pantheon.tech> <20240821145315.97974-1-juraj.linkes@pantheon.tech> <20240821145315.97974-12-juraj.linkes@pantheon.tech> Content-Language: en-US From: =?UTF-8?Q?Juraj_Linke=C5=A1?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3. 9. 2024 21:49, Dean Marx wrote: > On Wed, Aug 21, 2024 at 10:53 AM Juraj Linkeš > wrote: > > The scatter Rx offload capability is needed for the pmd_buffer_scatter > test suite. The command that retrieves the capability is: > show port rx_offload capabilities > > The command also retrieves a lot of other capabilities (RX_OFFLOAD_*) > which are all added into a Flag. The Flag members correspond to NIC > capability names so a convenience function that looks for the supported > Flags in a testpmd output is also added. > > The NIC capability names (mentioned above) are copy-pasted from the > Flag. Dynamic addition of Enum members runs into problems with typing > (mypy doesn't know about the members) and documentation generation > (Sphinx doesn't know about the members). > > Signed-off-by: Juraj Linkeš > > > > > +    RX_OFFLOAD_VLAN_FILTER = 1 << 9 > +    #: Device supports VLAN offload. > +    RX_OFFLOAD_VLAN_EXTEND = auto() > +    #: Device supports receiving segmented mbufs. > +    RX_OFFLOAD_SCATTER = 1 << 13 > > > This was an interesting section, I'm not super familiar with bitwise > shifting in python flags so I figured I'd ask while it's in mind if > there's any specific reason for shifting these two flags? Not a critique > of the code, just genuinely curious. > It's there just to mirror the flags in DPDK code. > Reviewed-by: Dean Marx >