From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id E25EFA0A0C;
	Thu,  1 Jul 2021 15:34:35 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 572FE4067C;
	Thu,  1 Jul 2021 15:34:35 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 893BC40141;
 Thu,  1 Jul 2021 15:34:34 +0200 (CEST)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 0A65D7F502;
 Thu,  1 Jul 2021 16:34:34 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 0A65D7F502
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1625146474;
 bh=O1ytpPZtwqqBJdT7IDc+ldM8HADsyqilZ3j2O90hhuQ=;
 h=Subject:To:Cc:References:From:Date:In-Reply-To;
 b=cfSPUc+uflATZucOEBUQ8XkDFGMUuZ50nJqAnBjsVvcfYytCGXZsTg2QL5ApnLby+
 Uu0KcH6hXV9YE+2ll5YIwYU3KfD8ZVXUMOpQFu+vDdAqsrgXzOkxReNraynRiSBjNy
 HL0okOvll50SA1IMGEexr1GVQ136KWUHICJeqRcs=
To: Jie Zhou <jizh@linux.microsoft.com>, dev@dpdk.org
Cc: dmitry.kozliuk@gmail.com, xiaoyun.li@intel.com, roretzla@microsoft.com,
 talshn@nvidia.com, pallavi.kadam@intel.com, thomas@monjalon.net,
 bruce.richardson@intel.com, ferruh.yigit@intel.com,
 konstantin.ananyev@intel.com, stable@dpdk.org
References: <1624998226-12220-1-git-send-email-jizh@linux.microsoft.com>
 <1624999822-16149-1-git-send-email-jizh@linux.microsoft.com>
 <1624999822-16149-7-git-send-email-jizh@linux.microsoft.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
Message-ID: <12b788e3-fdd5-9b2c-d7b4-9c02d3ec90e3@oktetlabs.ru>
Date: Thu, 1 Jul 2021 16:34:32 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <1624999822-16149-7-git-send-email-jizh@linux.microsoft.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v16 6/9] app/testpmd: fix parse_fec_mode
 return type name
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 6/29/21 11:50 PM, Jie Zhou wrote:
> Passing an uint32_t pointer to an enum pointer parameter causes
> pointer-sign warning on Windows (converts between pointers to
> integer types with different sign), since enum is implicitly
> converted to int on Windows.
> 
> And the current enum pointer parameter of that function is actually
> misleading and should be fixed as an uint32_t pointer parameter.
> 
> Fixes: b19da32e3151 ("app/testpmd: add FEC command")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Jie Zhou <jizh@linux.microsoft.com>

Reviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>

I'll fix summary on apply:
app/testpmd: fix FEC mode parse output parameter type