From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 1144AF94; Fri, 14 Apr 2017 11:40:29 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Apr 2017 02:40:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,197,1488873600"; d="scan'208";a="1155858373" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.122]) ([10.237.220.122]) by fmsmga002.fm.intel.com with ESMTP; 14 Apr 2017 02:40:27 -0700 To: Declan Doherty , Eric Kinzie , Ilya Maximets Cc: dev@dpdk.org, Heetae Ahn , Bernard Iremonger , stable@dpdk.org References: <1491577632-31289-1-git-send-email-i.maximets@samsung.com> <20170410022225.GA5162@roosta> <32c66606-95aa-3187-a4f6-89563d290793@intel.com> From: Ferruh Yigit Message-ID: <12d3d9ac-ed90-745d-a553-86a8fe5d19f1@intel.com> Date: Fri, 14 Apr 2017 10:40:26 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: <32c66606-95aa-3187-a4f6-89563d290793@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/bonding: allow configuring jumbo frames without slaves X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Apr 2017 09:40:30 -0000 On 4/14/2017 9:31 AM, Declan Doherty wrote: > On 10/04/17 03:22, Eric Kinzie wrote: >> On Fri Apr 07 18:07:12 +0300 2017, Ilya Maximets wrote: >>> Currently, 'rte_eth_dev_configure' fails on attempt to setup >>> max_rx_pkt_len > 2048 if no slaves was added to bonded device. >>> >>> For example: >>> >>> rte_eth_dev_attach("eth_bond0,slave=05:00.0,mode=l34", &id) >>> conf.rxmode.jumbo_frame = 1; >>> conf.rxmode.max_rx_pkt_len = 9000; >>> rte_eth_dev_configure(id, 1, 1, &conf) >>> >>> Result: >>> EAL: Initializing pmd_bond for eth_bond0 >>> EAL: Create bonded device eth_bond0 on port 4 in mode 2 on socket 0. >>> rte_eth_dev_configure: ethdev port_id=4 \ >>> max_rx_pkt_len 9018 > max valid value 2048 >>> >>> It's expected that slaves will be added to bonded device inside >>> 'rte_eth_dev_configure' and proper 'max_rx_pktlen' configured >>> for all of them. >>> >>> Failure happens because of hardcoded low value of 'max_rx_pktlen'. >>> Increasing of this value to ETHER_MAX_JUMBO_FRAME_LEN will allow >>> above scenario (attach + configure). >>> >>> It is important because it is the way OVS wants to work with >>> all DPDK devices (including virtual). >>> Changing the default hardcoded value makes no harm because >>> all the slaves' related code uses only 'candidate_max_rx_pktlen' >>> variable. >>> >>> Fixes: 6cfc6a4f0d61 ("net/bonding: inherit maximum Rx packet length") >>> CC: stable@dpdk.org >>> Signed-off-by: Ilya Maximets >>> --- > ... >> >> Reviewed-by: Eric Kinzie >> > > Acked-by: Declan Doherty Applied to dpdk-next-net/master, thanks.