From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 3EADB25A1 for ; Thu, 20 Jul 2017 12:02:52 +0200 (CEST) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Jul 2017 03:02:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,383,1496127600"; d="scan'208";a="127271394" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.255.136.225]) ([10.255.136.225]) by orsmga005.jf.intel.com with ESMTP; 20 Jul 2017 03:02:47 -0700 To: Ajit Khaparde , dev@dpdk.org References: <20170720044826.44103-1-ajit.khaparde@broadcom.com> From: Ferruh Yigit Message-ID: <12e05afb-d540-be7a-6d26-2229fd74a969@intel.com> Date: Thu, 20 Jul 2017 11:02:46 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170720044826.44103-1-ajit.khaparde@broadcom.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 0/8] bnxt patchset X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Jul 2017 10:02:53 -0000 On 7/20/2017 5:48 AM, Ajit Khaparde wrote: > Hi, > This patch set fixes some of the issues found during testing. > Please apply. > > Thanks > > net/bnxt: fix log levels for non error conditions. > net/bnxt: fix to avoid a segfault > net/bnxt: fix vnic cleanup > net/bnxt: fix set link config > net/bnxt: reset VF stats during initialization > net/bnxt: fix VLAN antispoof configuration code > net/bnxt: check invalid l2_filter_id > net/bnxt: fix to free a filter before reusing it Getting following build errors, fyi: .../drivers/net/bnxt/rte_pmd_bnxt.c:464:8: error: variable 'rc' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized] if (bnxt_hwrm_cfa_l2_set_rx_mask(bp, &vnic, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ .../drivers/net/bnxt/rte_pmd_bnxt.c:471:9: note: uninitialized use occurs here return rc; ^~ .../drivers/net/bnxt/rte_pmd_bnxt.c:464:4: note: remove the 'if' if its condition is always true if (bnxt_hwrm_cfa_l2_set_rx_mask(bp, &vnic, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ .../drivers/net/bnxt/rte_pmd_bnxt.c:462:7: error: variable 'rc' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized] if (bnxt_hwrm_vnic_qcfg(bp, &vnic, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ .../drivers/net/bnxt/rte_pmd_bnxt.c:471:9: note: uninitialized use occurs here return rc; ^~ .../drivers/net/bnxt/rte_pmd_bnxt.c:462:3: note: remove the 'if' if its condition is always true if (bnxt_hwrm_vnic_qcfg(bp, &vnic, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ .../drivers/net/bnxt/rte_pmd_bnxt.c:454:6: error: variable 'rc' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized] if (dflt_vnic < 0) { ^~~~~~~~~~~~~ .../drivers/net/bnxt/rte_pmd_bnxt.c:471:9: note: uninitialized use occurs here return rc; ^~ .../drivers/net/bnxt/rte_pmd_bnxt.c:454:2: note: remove the 'if' if its condition is always false if (dflt_vnic < 0) { ^~~~~~~~~~~~~~~~~~~~ .../drivers/net/bnxt/rte_pmd_bnxt.c:440:8: note: initialize the variable 'rc' to silence this warning int rc; ^ = 0 3 errors generated.