From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 980DB45B31; Mon, 14 Oct 2024 03:26:55 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AA1CC40274; Mon, 14 Oct 2024 03:26:54 +0200 (CEST) Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by mails.dpdk.org (Postfix) with ESMTP id 7D57740151; Mon, 14 Oct 2024 03:26:52 +0200 (CEST) Received: from loongson.cn (unknown [10.20.42.74]) by gateway (Coremail) with SMTP id _____8AxDOtacwxnp7cZAA--.38853S3; Mon, 14 Oct 2024 09:26:50 +0800 (CST) Received: from [10.20.42.74] (unknown [10.20.42.74]) by front2 (Coremail) with SMTP id qciowMCxBcVWcwxn98grAA--.62078S3; Mon, 14 Oct 2024 09:26:49 +0800 (CST) Subject: Re: [PATCH 0/5] Increase minimum meson version To: Patrick Robb Cc: David Marchand , dpdklab , dev@dpdk.org, mb@smartsharesystems.com, thomas@monjalon.net, ci@dpdk.org, Bruce Richardson References: <20240920125737.1197969-1-bruce.richardson@intel.com> <9a6c43e9-b2a1-15fe-9b7c-4178419f1e35@loongson.cn> From: zhoumin Message-ID: <12eae603-d75d-ee3f-3822-670e8e4bbbeb@loongson.cn> Date: Mon, 14 Oct 2024 01:24:19 +0000 User-Agent: Mozilla/5.0 (X11; Linux loongarch64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/alternative; boundary="------------6049E43E4AE5FDF73E4D9E22" Content-Language: en-US X-CM-TRANSID: qciowMCxBcVWcwxn98grAA--.62078S3 X-CM-SenderInfo: 52kr3ztlq6z05rqj20fqof0/1tbiAgEKAWcLuCEEBQAAs8 X-Coremail-Antispam: 1Uk129KBj93XoWxCr1xJr1kKw45Kw15Cw1xWFX_yoW5ZryrpF 1kKry5KryrXw4rJr4DZw18AFWrJwsxJ3W5Jw15ta4UGFs8tryjqrWjgFZYgF9rWrW8AF40 gr15uw45uF1UAagCm3ZEXasCq-sJn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3UbIjqfuFe4nvWSU5nxnvy29KBjDU0xBIdaVrnRJUUUkEb4IE77IF4wAF F20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r 106r15M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAF wI0_Gr0_Xr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Cr0_Gr1UM28EF7xvwVC2z280aV AFwI0_Gr0_Cr1l84ACjcxK6I8E87Iv6xkF7I0E14v26r4j6r4UJwAS0I0E0xvYzxvE52x0 82IY62kv0487Mc804VCY07AIYIkI8VC2zVCFFI0UMcIj6xIIjxv20xvE14v26r1j6r18Mc Ij6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41l7480 Y4vEI4kI2Ix0rVAqx4xJMxk0xIA0c2IEe2xFo4CEbIxvr21l42xK82IYc2Ij64vIr41l4I 8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUGVWUWwC20s026x8GjcxK67AK xVWUGVWUWwC2zVAF1VAY17CE14v26r1q6r43MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcV AFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r1j6r4UMIIF0xvE42xK8VAvwI8I cIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r 1j6r4UYxBIdaVFxhVjvjDU0xZFpf9x07UEFAJUUUUU= X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This is a multi-part message in MIME format. --------------6049E43E4AE5FDF73E4D9E22 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Hi Patrick Robb, Thank you for your reminding. I have set the meson version to 0.57.0 in Loongson lab. On Wed, Oct 9, 2024 at 2:31PM, Patrick Robb wrote: > Hi Min Zhou, > > I think it makes sense for you to set your meson version to the > minimum version supported for DPDK (so, .57 now I suppose) instead of > .63. The principle that David described above regarding LTS is also > true for main. So, for the main and next-* branch testing that > Loongson lab does, we want our CI testing to verify that no change > relying on post .57 meson features get merged into main. > > On Tue, Oct 8, 2024 at 9:07 PM zhoumin > wrote: > > Hi David, > > On Tues, Oct 8, 2024 at 8:28AM, David Marchand wrote: > > Hello CI guys, > > > > On Fri, Sep 20, 2024 at 2:57 PM Bruce Richardson > > > > wrote: > >> This patchset proposed increasing the minimum meson version to 0.57 > >> and makes changes to update our build files appropriately for that > >> change: replacing deprecated functions, removing unnecessary > version > >> checks and taking advantage of some new capabilities. > >> > >> Why 0.57? No one particular reason; it's mainly a conservative > version > >> bump that doesn't have many impacts, but still gives us the minimum > >> updates we need to replace the deprecated get_cross_properties fn > >> and have a few extra features guaranteed available. > >> > >> Bruce Richardson (5): > >>    build: increase minimum meson version to 0.57 > >>    build: remove version check on compiler links function > >>    build: remove unnecessary version checks > >>    build: use version file support from meson > >>    build: replace deprecated meson function > >> > >>   .ci/linux-setup.sh                        | 2 +- > >>   config/arm/meson.build                    | 4 ++-- > >>   config/meson.build                        | 8 ++++---- > >>   config/riscv/meson.build                  | 4 ++-- > >>   doc/api/meson.build                       | 2 +- > >>   doc/guides/linux_gsg/sys_reqs.rst         | 2 +- > >>   doc/guides/prog_guide/build-sdk-meson.rst | 2 +- > >>   drivers/common/qat/meson.build            | 2 +- > >>   drivers/crypto/ipsec_mb/meson.build       | 2 +- > >>   drivers/event/cnxk/meson.build            | 2 +- > >>   drivers/meson.build                       | 7 ++----- > >>   drivers/net/cnxk/meson.build              | 2 +- > >>   lib/meson.build                           | 6 ------ > >>   meson.build                               | 7 ++----- > >>   14 files changed, 20 insertions(+), 32 deletions(-) > > This series can't be merged until the (UNH and LoongArch) CI are > ready > > for such a change. > > > > TL;DR: the meson minimum version is being changed from 0.53.2 to > 0.57 > > in the current release. > > > > @UNH @Min Zhou > > How long would it take for all CI to be ready for this change? > It's OK for Loongson lab. The meson version for DPDK CI in > Loongson lab > is 0.63.0. > > Important note: if relevant to your CI, testing against LTS branches > > must still be done with the 0.53.2 version, so no change relying on > > post 0.53.2 meson feature gets backported. > > > > > --------------6049E43E4AE5FDF73E4D9E22 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 8bit

Hi Patrick Robb,

Thank you for your reminding. I have set the meson version to 0.57.0 in Loongson lab.

On Wed, Oct 9, 2024 at 2:31PM, Patrick Robb wrote:
Hi Min Zhou,

I think it makes sense for you to set your meson version to the minimum version supported for DPDK (so, .57 now I suppose) instead of .63. The principle that David described above regarding LTS is also true for main. So, for the main and next-* branch testing that Loongson lab does, we want our CI testing to verify that no change relying on post .57 meson features get merged into main. 

On Tue, Oct 8, 2024 at 9:07 PM zhoumin <zhoumin@loongson.cn> wrote:
Hi David,

On Tues, Oct 8, 2024 at 8:28AM, David Marchand wrote:
> Hello CI guys,
>
> On Fri, Sep 20, 2024 at 2:57 PM Bruce Richardson
> <bruce.richardson@intel.com> wrote:
>> This patchset proposed increasing the minimum meson version to 0.57
>> and makes changes to update our build files appropriately for that
>> change: replacing deprecated functions, removing unnecessary version
>> checks and taking advantage of some new capabilities.
>>
>> Why 0.57? No one particular reason; it's mainly a conservative version
>> bump that doesn't have many impacts, but still gives us the minimum
>> updates we need to replace the deprecated get_cross_properties fn
>> and have a few extra features guaranteed available.
>>
>> Bruce Richardson (5):
>>    build: increase minimum meson version to 0.57
>>    build: remove version check on compiler links function
>>    build: remove unnecessary version checks
>>    build: use version file support from meson
>>    build: replace deprecated meson function
>>
>>   .ci/linux-setup.sh                        | 2 +-
>>   config/arm/meson.build                    | 4 ++--
>>   config/meson.build                        | 8 ++++----
>>   config/riscv/meson.build                  | 4 ++--
>>   doc/api/meson.build                       | 2 +-
>>   doc/guides/linux_gsg/sys_reqs.rst         | 2 +-
>>   doc/guides/prog_guide/build-sdk-meson.rst | 2 +-
>>   drivers/common/qat/meson.build            | 2 +-
>>   drivers/crypto/ipsec_mb/meson.build       | 2 +-
>>   drivers/event/cnxk/meson.build            | 2 +-
>>   drivers/meson.build                       | 7 ++-----
>>   drivers/net/cnxk/meson.build              | 2 +-
>>   lib/meson.build                           | 6 ------
>>   meson.build                               | 7 ++-----
>>   14 files changed, 20 insertions(+), 32 deletions(-)
> This series can't be merged until the (UNH and LoongArch) CI are ready
> for such a change.
>
> TL;DR: the meson minimum version is being changed from 0.53.2 to 0.57
> in the current release.
>
> @UNH @Min Zhou
> How long would it take for all CI to be ready for this change?
It's OK for Loongson lab. The meson version for DPDK CI in Loongson lab
is 0.63.0.
> Important note: if relevant to your CI, testing against LTS branches
> must still be done with the 0.53.2 version, so no change relying on
> post 0.53.2 meson feature gets backported.
>
>

--------------6049E43E4AE5FDF73E4D9E22--