From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C5147A0C57; Mon, 1 Nov 2021 14:43:33 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3AEA240E28; Mon, 1 Nov 2021 14:43:33 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id C957040DF6 for ; Mon, 1 Nov 2021 14:43:30 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10154"; a="291853550" X-IronPort-AV: E=Sophos;i="5.87,199,1631602800"; d="scan'208";a="291853550" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2021 06:43:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,199,1631602800"; d="scan'208";a="488659264" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga007.jf.intel.com with ESMTP; 01 Nov 2021 06:43:29 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 1 Nov 2021 06:43:28 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 1 Nov 2021 06:43:28 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 1 Nov 2021 06:43:28 -0700 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.170) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 1 Nov 2021 06:43:28 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DhxlWe+ZCG933R5hxyeT7ARtzFpJWqFViig53KhITov0gu6ZbbQmaTezTIkFjs+oC9cBf5xOUoDBPbrSd11LsErcI+UKmDrt86YZJ3Sl500+W181TrVqEPjpKrE9fEhvtGS+39UwYGDCJPMl0GFTyqejfHm+GInCCn1xdiZJmeF8O7CUZb294UhqNlnxMaHwTw4bKYGGN8JEvB7nfTGykry32R76hSZuGrXajcKmD48JIIV0yOYTMkVZQEAR97N5qYUPgcYwQJF4lKJ/9k3eT1SpKDeO31HJpx3v4y2SdsbnRNye/D37TGxie39yHLHStldR9iVcdoU+EfwUevRZqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=erBcsL2yIy98BFwAwzJIrVnaATCPpmurcc7pQtjXNGk=; b=G31MjpGTiphsV7lZMSXQGnfZUi6mumPuMyC3+LNGv5bAHb+oiKcn6DH4Advm+Soz3ZAtfv3LGPGIjTRdFnq8HQGN+9HPmKU+DzmbMizmuGvMNmoeUogMwA2fVzCju0k0m+YmhARsz1sDggz2qfU7jnJLGsJ6DAKPeXMzGPbjunr3r5CGe6JGknaxKxJa/c5fHFOANyjyx1M852dxEQEp32OxlDK+m9AFJwcMDd9TAlp7hiZjhcDUBRnFiZbwwFIuum86v8hssJod59KoDajKoN5mumxdVJ+BRNtq0xy2bwvG+sDH8LxFpRS6LpGEzyGFyuiM1HNtBGJyLjXaRFIUdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=erBcsL2yIy98BFwAwzJIrVnaATCPpmurcc7pQtjXNGk=; b=rHqT7nnM2rxFgvU0taTys2llUQFDy1bXqJ7NVx3xalM3p/XTYttLaBauwJAoPrGXMjQzhdsa+ndBEI1GA+EvnbOWJfcKZQSpScIPlP4EfR73nJcxc5a33loQ0yuFKxcnjT3savkJGmvEKqgh5uDCP+sN//AstQPGUgpas8zAgUQ= Authentication-Results: broadcom.com; dkim=none (message not signed) header.d=none;broadcom.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4888.namprd11.prod.outlook.com (2603:10b6:510:32::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14; Mon, 1 Nov 2021 13:43:22 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%5]) with mapi id 15.20.4649.019; Mon, 1 Nov 2021 13:43:21 +0000 Message-ID: <12effb53-1fea-91ef-b3a9-0e16dc085db4@intel.com> Date: Mon, 1 Nov 2021 13:43:09 +0000 Content-Language: en-US From: Ferruh Yigit To: Ajit Khaparde , Somnath Kotur , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Rahul Lakkireddy , Hemant Agrawal , Sachin Saxena , Haiyue Wang , John Daley , Hyong Youb Kim , Gaetan Rivet , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , "Min Hu (Connor)" , Yisen Zhuang , Lijun Ou , Beilei Xing , Jingjing Wu , Beilei Xing , Qiming Yang , Qi Zhang , Rosen Xu , Liron Himi , Jerin Jacob , Nithin Dabilpuram , "Kiran Kumar K" , Rasesh Mody , Devendra Singh Rawat , Andrew Rybchenko , Jasvinder Singh , Cristian Dumitrescu , Keith Wiles , Jiawen Wu , Jian Wang CC: Ori Kam , Dmitry Kozlyuk , References: <20211019123722.3414694-1-dkozlyuk@nvidia.com> <20211021063503.3632732-1-dkozlyuk@nvidia.com> X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DU2PR04CA0300.eurprd04.prod.outlook.com (2603:10a6:10:28c::35) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DU2PR04CA0300.eurprd04.prod.outlook.com (2603:10a6:10:28c::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.17 via Frontend Transport; Mon, 1 Nov 2021 13:43:13 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f9882cc2-882c-43d8-c753-08d99d3d9157 X-MS-TrafficTypeDiagnostic: PH0PR11MB4888: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1Nrst/Gst7PSWYyEqxa0xOflu/CGxXCRi7t29XgVDXFuY/TjulXEN2XPPCPzBdWE7DXBNWN4LtuWAGgGNKHE/GHwRMsVb0k9c1F9S7QKPTLOAKy9nUqixn+frHZpRyQZZU+BDqGPeUUzh+3ug+1kS9JgigI5hnCmeN8ls3FxYVGBktrZKpr25cPY54OWLJ0vcDP40OW7ql7QWd5EdD9JX1RVfDb1ODn5uEQuUrRB1Y0Rr1/ampsc9YAUMJzOYFB6oOKwHbFBZ3JTTLhHmBr0jV6moPaUk3Y32zuGksTNMg2HAgutbwng4L5LYog6adl3U4OZiyAHM0/5jx6pqtXNAyzsnTcez8sPbp3+bet+meZIcXi1jK632MC4GSfTyRenmEweJmQP9scupxglQqWRoR0hXzwoMehvfdFIdHn88opQL2uPj/nnYX2l7FgMvSbSEXLjh6vyfkeGZ/ZQ+icrz4JBAyvD2fn0xfaOm2m+8IFqlyudSFe2IOoZxyH95UXEGOPYF722pkScPTd8UoEZvYZnW1J1qojDRyqpXOGgrmFyr4BeP4JoO3PsTi1I8nC5V2ulRym2IBgasXyUW2YnHinxmGeRrwpvIQA8w7hxmqZFxi9AGL0N8iRTn7340/HK3HKGHqyCe1aFaYbOvvVs4r6Zto1gaqG7iBCqr+pMapatLrlDweM/p/DqpWgUpFVFe2JtKM2oElmHluId2ymPRAlNLWa84BZ/F3trkENwdyaqeD39YXK+uIBpmOf8nP68yKb5AT5XpL6jeUxJqkW6UzVArjxHmGNUn8QAm8ZEml8C72wh6bfVf7LGFKisTmRFwGoiyI5qFS+YQHLE17miKenze4PUJzoGt5Lxac3LLk4= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(186003)(6666004)(31696002)(83380400001)(86362001)(53546011)(31686004)(2906002)(82960400001)(54906003)(316002)(966005)(956004)(7416002)(2616005)(6486002)(8936002)(44832011)(5660300002)(508600001)(921005)(8676002)(26005)(38100700002)(4326008)(36756003)(16576012)(110136005)(66946007)(66476007)(66556008)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U0VodjlPNWhOaVhMNHJ3d1N5TWdLdDBLd3Y4NUNmUG9BeThQOHIybnBBMDgv?= =?utf-8?B?YUZqWnFuaEVVK1gxTHFVMkd3MlQ4NjA0d0duRUJpRjQxdjBKTEt0ZGkva0t5?= =?utf-8?B?bFlycWF4Q0FqTXJYUEVZclRUQ0ZxNGRVd3hZMUVJRlZLUDY1TE16VUp1QnMz?= =?utf-8?B?a2RVSjV0eGI4Um9TTS9iclhDb0pveFlZREdtakVHYWtHMWZpZ2xCY3h4MDI2?= =?utf-8?B?YW5qY2JQRHNjQWdaRE5aK3BDdVM4SkVFT2Z0Q1ZSdmsya1VQcmhhZ2VlYnlQ?= =?utf-8?B?MytLZGZlQzMvelU2clhLNlpWcWJzS2pkemJTVUF4SEFtTWxTa2trTmVUUUxY?= =?utf-8?B?eGVXR3BWbi94RUMxTUtqZExWcHREQzNyZ1BiS1VkeEZzRUxVdDl6Q2RMZXRI?= =?utf-8?B?djJ2K01VdUc5UWk1amlZb1NzYWpRaVhLdHN2Wm81RUdHdE5GZDB6K2RnZWZq?= =?utf-8?B?czlSVWgzbGZLNDAwaDhINFB0QjVRc3k1VWdTbTFGcDdrWnk5bkd5OFY4Nnpj?= =?utf-8?B?Y0VIeGdvVkJLaU1wdkZSL2h3WEtqb1UwYU50K1FhYk5JYXdBd1J5M2tseFpR?= =?utf-8?B?N2YvOEpRekZTL2dQMXVqZ2hiTkRtR1BZVnF4NXBBaWxVUVJ3aEw3VUFKekVR?= =?utf-8?B?OVU4NmRYKzVYSm9uQTRmME1sWGhiTUVwNDUvU3VkV0VPV3hpTmpmOGx0b0Z2?= =?utf-8?B?SU1CakpOTEFlSFVsQ2lUSU1pQlF0VzgydXZxaTFZS1dyODdGUm9LUzJVb3B6?= =?utf-8?B?QUU0MytDZW5IZVNYNEkyaXZzWnpId0IrT0Q2S2ZQWGdGRnpvTmpyQ1FBdUJ6?= =?utf-8?B?QnliR3d6d3N6a2FqdTBDZ0RBbnEyaXpvTnlDeWRUWTVzMHA1eklvMEZRZDJT?= =?utf-8?B?K0hYWGRIeHBwdUlsajJPMlFyTUU3b2FJQ1VNd2Yvd2ZtUEFraFBYcEFORG9v?= =?utf-8?B?WE5sODR1SFQ1VUhBREJ2WGs2U29EY3RGaSttWmlDb0hnYkUzME50RmNsTnd0?= =?utf-8?B?b1U5Sm9JT1hkd2VSdkVHanRYVHE3V2ozaDlWUXN6eWhFQmtWNGxVYWl5Ui9R?= =?utf-8?B?bHhjYUFWaFB5VGkwRUV1djcrNU5yalRpV1crVXNGNklOc0lKdHBtT2lhVXha?= =?utf-8?B?bXVDNURJYWZ1TTR0UTZYSnJxMzdBcXRCajExNFdMVkF4Tm9wNUNibmwzQ01H?= =?utf-8?B?SngyNTFsS1lGUm1yT21hemNXREVGeGY1aS82eFFScjRxbFduc0paQ3hDU0lK?= =?utf-8?B?UENqU3VyRFQ1cHdMTVJLc1FBVEF0WkR6SitJRXl3dmVSRmNncTdiNVRubzhn?= =?utf-8?B?MXVlUzNjWjVJRUN0SWJHdGt5bW5TQUN6a3luOGhDUFNnaGFqWFFqeHAwUjJ1?= =?utf-8?B?SUlmdTIxeTBPSytyZUE0Nkl3L2Nvei85Mi9ENzNsK2FEbmtpeG9NNjJnYkNx?= =?utf-8?B?d3FKd2ovdS80eXlwd0lIdVZ1ZG5WbmVQNEZxT2htVTAzVG4xUDczcndRSmpD?= =?utf-8?B?UWQ5UG1jclVaVjQ2TitkZDA3eGF6Zjg3T2ZFcmhLSzlPYk5TUXBHZUhNYlhB?= =?utf-8?B?TElzZFEyZEl4d0ozUGFBTnZTdC96MW9HemtpYmsxdkR3QXVUS1M1ZnhzU1pS?= =?utf-8?B?SWd0a3MxNGdpRnBXQk9vRFl6aUh3TU93bkRJMTBXMTg2WEwrdTR0ZzE2bEdI?= =?utf-8?B?ZXZpL09NenJUdnU3YU8zNVh5dHE2WXMvSVJhVmc3aHJRWk9mUllPUTJad2F4?= =?utf-8?B?ZjF1MVJOVFhwcE1pckZoQWFYT0lnd2pJditrekJGYklKWHdUWmhCRFIxdU50?= =?utf-8?B?K0JnZDhRRVZ4S3kxZkFqd04yZkpsRDF0aGhqUUV2T0NDSWRvT0s2cXRkaUw3?= =?utf-8?B?bWRJRUNWWVgyTVRPc2pXMmtqZ2s1bkhZTXg2Tmt4NkU2MGJpaEVzeSswYW16?= =?utf-8?B?Sk1vc1FxZy85UXdSUTRIcm9kQWNzMG1Wb3JjY2RCZlEwdVFrY1FLbUkvOWph?= =?utf-8?B?K0E4UGVBTEQ0Z1FvMXcwNStoTzlsWS9lQ1NjZVBTQmkrYjlWQVBzNlFRMFRC?= =?utf-8?B?UkduUDBvcEVEQWZ3YjlpRkpTelZ2MUJWT3d0K002VWtxRUk4NUZlbnB0STlU?= =?utf-8?B?TzBVM1hBREcwd2NxQTJoZUV3N1U3Q0tkNlM1WGd4Yjc1Nm96UTY2a1ozajFX?= =?utf-8?Q?TQyXQDqyaM1fPqy6idlf8q4=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: f9882cc2-882c-43d8-c753-08d99d3d9157 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2021 13:43:21.1748 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qoBbUrP0udONdngurI5yrJiGk/Hkpd+vZQtFsPLvzMO1Xk5TYtGziyl4WAg0COgX9aBcvy71dCUNq/Csy8/Rsw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4888 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v4 0/6] Flow entites behavior on port restart X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/26/2021 12:46 PM, Ferruh Yigit wrote: > On 10/21/2021 7:34 AM, Dmitry Kozlyuk wrote: >> It is unspecified whether flow rules and indirect actions are kept >> when a port is stopped, possibly reconfigured, and started again. >> Vendors approach the topic differently, e.g. mlx5 and i40e PMD >> disagree in whether flow rules can be kept, and mlx5 PMD would keep >> indirect actions. In the end, applications are greatly affected >> by whatever contract there is and need to know it. >> >> Applications may wish to restart the port to reconfigure it, >> e.g. switch offloads or even modify queues. >> Keeping rte_flow entities enables application improvements: >> 1. Since keeping the rules across restart comes with the ability >>     to create rules before the device is started. This allows >>     to have all the rules created at the moment of start, >>     so that there is no time frame when traffic is coming already, >>     but the rules are not yet created (restored). >> 2. When a rule or an indirect action has some associated state, >>     such as a counter, application saves the need to keep >>     additional state in order to cope with information loss >>     if such an entity would be destroyed. >> >> It is proposed to advertise capabilities of keeping flow rules >> and indirect actions (as a special case of shared object) >> using a combination of ethdev info and rte_flow calls. >> Then a bug is fixed in mlx5 PMD that prevented indirect RSS action >> from being kept, and the driver starts advertising the new capability. >> >> Prior discussions: >> 1) http://inbox.dpdk.org/dev/20210727073121.895620-1-dkozlyuk@nvidia.com/ >> 2) http://inbox.dpdk.org/dev/20210901085516.3647814-1-dkozlyuk@nvidia.com/ >> >> v4:  1. Fix rebase conflicts (CI). >>       2. State rule behavior when a port is not started or stopped (Ori). >>       3. Improve wording on rule features, add examples (Andrew). >>       4. State that rules/actions that cannot be kept while other can be >>          must be destroyed by the application (Andrew/Ori). >>       5. Add rationale to the cover letter (Andrew). >> >> Dmitry Kozlyuk (6): >>    ethdev: add capability to keep flow rules on restart >>    ethdev: add capability to keep shared objects on restart >>    net: advertise no support for keeping flow rules >>    net/mlx5: discover max flow priority using DevX >>    net/mlx5: create drop queue using DevX >>    net/mlx5: preserve indirect actions on restart >> > > Requesting review from PMD maintainers. > > Since this patch tries to define behavior on keeping/flushing flow rules > after port stop/start/configure, better to get more feedback from various > vendors, please review/comment on patch so that we can get it for -rc2. > > If there is no comment the patch can go in as it is for -rc2. > Last review call before merge.