From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f179.google.com (mail-wi0-f179.google.com [209.85.212.179]) by dpdk.org (Postfix) with ESMTP id D7B4736D for ; Mon, 30 Jun 2014 11:20:49 +0200 (CEST) Received: by mail-wi0-f179.google.com with SMTP id cc10so5580251wib.12 for ; Mon, 30 Jun 2014 02:21:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=udtz9RQd2PpZsZUKcDBMqWyA6Swn+r+K5vZqNcE9+xo=; b=Gte5UNIU8VD/KCo78VQvisD3MUEWl5vdIxFcOcmeg1JnFzqf0qUvN6a3D98dnKPQDm W74RNTjf/Pp9mG06wZwggFywajvqOLhB8FLDgaC67t4AkfU43R277nk8LMoTj/2TxdK+ KUHLEiiYSGhnZBNO3H2qeMXdYzxltoDT6Ss8igKkUjcnF0sTE4w3e+CGYXuyIlMqyHUl wN3FQQYPWJwk6ngDBdHVAi1uggro+EoK0NYDd5ZFZWLZwoWiNepydGCPzV7KjnrDTsLh BTOWRnzSqoIQdhBMKL4akwBxjQU4euIasKGJBZLrUG1aueiX6w3pHIpOPwWIKebfQhxw O6Wg== X-Gm-Message-State: ALoCoQmLg48vZHtBbYN8h91Dp7Nt3UiY951kA8C9tWECOsJinxMPklXVH07xboCGm6F2oDHw09+a X-Received: by 10.180.186.97 with SMTP id fj1mr27528934wic.18.1404120069844; Mon, 30 Jun 2014 02:21:09 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id oy4sm40066928wjb.41.2014.06.30.02.21.08 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 Jun 2014 02:21:09 -0700 (PDT) From: Thomas Monjalon To: Declan Doherty Date: Mon, 30 Jun 2014 11:21:02 +0200 Message-ID: <13010138.0NjEKNQfRt@xps13> Organization: 6WIND User-Agent: KMail/4.13.1 (Linux/3.14.6-1-ARCH; KDE/4.13.1; x86_64; ; ) In-Reply-To: <1404064161-26370-1-git-send-email-declan.doherty@intel.com> References: <1403864324-12022-1-git-send-email-declan.doherty@intel.com> <1404064161-26370-1-git-send-email-declan.doherty@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v11 0/5] link bonding library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Jun 2014 09:20:50 -0000 Hi Declan, 2014-06-29 18:49, Declan Doherty: > This patchset contains the name change fix in the link bonding library > makefile. I have also put a change into the unit test application makefile > so that the link bonding tests are not built if the library is also not > being built. It doesn't make sense to split the bonding libraries APIs into > a seperate library, as they are directly coupled to with the bonding > library implmentation You fixed optional building but there is still an issue when building shared library. As you don't want to split the library to separate the PMD plugin from the specific API, I suggest to not consider it as a plugin (unlike other PMDs). I've sent some patches about these 2 topics. If you agree, I'll apply them, merged with your serie. Thanks -- Thomas