From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id A07CC9E3 for ; Mon, 26 Jun 2017 16:36:24 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 0B4562089B; Mon, 26 Jun 2017 10:36:24 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Mon, 26 Jun 2017 10:36:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=R7sx4JAkCoEMQJO SruKPyGX+vBVE68EbLO90zR2XRsg=; b=nJ5tcXFEI1pwGjMiCMCXD/2jmaLGMuH N/g8itTXiRM0DEwK6eeqdg8syHz2IIVKsqAK+k5/PBk0bstP3QJfQoA5VjuuJzBZ +fu1k25HAoAbS32K6cMKc5Zr2Q/nV8hpJiy4jg9bsuilsQ0xyawScq5z0rqH0leE XC+siNnuoDoU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=R7sx4JAkCoEMQJOSruKPyGX+vBVE68EbLO90zR2XRsg=; b=MWHOLpPc 8UZkcMPolxYE0xs1keh4hRp+I55J0nTlDGPyZvqSV8R2GPA6vk3HzRLoBt2CVY8K iWAboYpefiwiNqdaxktOsKmsXRSLNYu+60rSOd4N7zjAoQ4e2bd0IKeTlMKeRKMk R+z+c454HIY5Xne3dfjBHQgtUEMkA4UeglnSqRxohFhBc/nua8pXt0pjkmY96V1s yuTuFSg9LCiEN3RhVY4eID7cFOJ6L8c6nEkNVFXrD13ABI3FTDyTFymGcP31GLPj 7IyBfuWafQRYA4nx1BuiMI56e+DpRKYVRy2mAMbq2jfrzLKzupACYjhWaRPdVMpA G+mHglaR1+ZqaQ== X-ME-Sender: X-Sasl-enc: FUNl1I39EhmO2Pff3sVMl/Df53iVkl5QhJiNCx5QoEug 1498487783 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id A7E192445F; Mon, 26 Jun 2017 10:36:23 -0400 (EDT) From: Thomas Monjalon To: Sergio Gonzalez Monroy Cc: Tonghao Zhang , dev@dpdk.org Date: Mon, 26 Jun 2017 16:36:22 +0200 Message-ID: <13031028.yozIglrOR3@xps> In-Reply-To: References: <1494467793-19887-1-git-send-email-nic@opencloud.tech> <2606734.FJRB2dCBfg@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4] eal: Set numa node value for system which not support it. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Jun 2017 14:36:25 -0000 26/06/2017 14:50, Sergio Gonzalez Monroy: > On 26/06/2017 10:39, Thomas Monjalon wrote: > > 26/06/2017 11:14, Sergio Gonzalez Monroy: > >> On 23/06/2017 14:02, Thomas Monjalon wrote: > >>> 22/06/2017 17:15, Sergio Gonzalez Monroy: > >>>> Just fyi, the summary line should be lowercase apart from acronyms (DPDK > >>>> guidelines). > >>>> > >>>> On 11/05/2017 02:56, Tonghao Zhang wrote: > >>>>> The NUMA node information for PCI devices provided through > >>>>> sysfs is invalid for AMD Opteron(TM) Processor 62xx and 63xx > >>>>> on Red Hat Enterprise Linux 6, and VMs on some hypervisors. > >>>>> It is good to see more checking for valid values. > >>>>> > >>>>> Signed-off-by: Tonghao Zhang > >>>>> --- > >>>> IMHO the message could be slightly improved by adding some of the > >>>> replies that you made to your v3. > >>>> ie. Typical wrong numa node in VMs > >>>> > >>>> $ cat /sys/devices/pci0000:00/0000:00:18.6/numa_node > >>>> -1 > >>> [...] > >>>> The code changes look fine, so I leave it to Thomas regarding the commit > >>>> message :) > >>>> > >>>> Acked-by: Sergio Gonzalez Monroy > >>> Applied, thanks > >> It looks like some systems have quite a few devices that report -1 as > >> numa_node value causing lots of warning messages being printed. > >> Quick fixes that come to mind would be: > >> 1) Change log level to DEBUG > > As it is important for performance, it should not be just for DEBUG. > > > >> 2) Add static var to only print the message once. > > Yes good idea. > > > >> I also think that the message itself should show at least the BDF to at > >> least know which devices are reporting bad numa_node values. > > With the static variable, we will have only the first device BDF. > > Is it relevant? > > > > I think it is relevant if it affects a device used by DPDK, but we don't > know that when doing full pci_scan. > > At least on x86 platforms we usually see many PCI devices without numa_node: > ls /sys/bus/pci/devices | xargs -n 1 -I {} head -v > "/sys/bus/pci/devices/{}/numa_node" > > A single warning is not going to mean much if all platforms have PCI > devices without proper numa_node, right? > > A more cleaner solution might be to leave -1 if we failed to parse > numa_node, then on rte_pci_probe_one_driver after checking if it is > blacklisted check if socket_id is -1 and show warning message defaulting > to 0? > > I would be inclined to: > a) leave it as it is with DEBUG log level, also showing PCI BDF (very > noisy in debug mode). > b) show the warning and default to 0 in rte_pci_probe_one_driver, > showing only relevant devices. Looks a good proposal Sergio! Thanks