From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D4A7DA00C5; Mon, 6 Jul 2020 10:15:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 21DC11D69D; Mon, 6 Jul 2020 10:15:48 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 181801D628 for ; Mon, 6 Jul 2020 10:15:46 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 848B45C0112; Mon, 6 Jul 2020 04:15:45 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Mon, 06 Jul 2020 04:15:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= Zmupz3TjVk9o4oBNMTMbHansmyToW/8K2JCSh7zFhHg=; b=xKOQzDySlKs323zr MxsjCVftWPxQqFqNeuzRvpMGvug4zPl81NWePI+edcCJaPYAoDwnJwyX80QZDYzf dltd9zOZOgxhvzdpgCIJk3ALQ2A9gIDzyXBT+cPP8btveHgnxe6NB6qt/fTKSVU7 sLKa+vs1nRgmYI/rxk7+gLY0CtmBEwrn83jIZI9gz3JzSOwBMg0I1LfRW2JZC87W xAL26zwG5+Dx7DNlImiXZRNKudatPTPXUUt8//VP078qr5L99C3egAarzXdZZsYi 6pw4DHnByJI2J7f9nnzyAnL5Rmv33Iuq//EcyOxeC37hs1Rejpo29gIPi1HdmqxQ Ca09LQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=Zmupz3TjVk9o4oBNMTMbHansmyToW/8K2JCSh7zFh Hg=; b=HyvIES0ZjqGNxwrP9abiF9Ol78ehsDruSVpE/K8yoAjTwZPNgdpeRxnKo uLKgpWc3OoEOx44wNVw84aDmDrr5Wug8WDPTiY4Txad2BlTquuPOv+uUvRiEbveb wpt4LlLqMl887ae2rsJmv0afJkw05Ra6n9SMa/+LIfJYLN6UFq7QL/Sl1jswRtmf MpOJ2JWnTpzrI+d/FaazGpzj+LaWdCSjrWla2UYxEIQQHwZYxnoi7Q7UzbLQzouY CmLv89sQo8n78tvAl2km0xiG9HX8SQcAaHUktXz/9eAMik0M1VitqLBLrH0pD2O8 uY6do6E/u38hnFvd25nEg0CH3UrQg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrudefgddtudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 6D75D30653ED; Mon, 6 Jul 2020 04:15:44 -0400 (EDT) From: Thomas Monjalon To: Wisam Jaddo Cc: jackmin@mellanox.com, david.marchand@redhat.com, dev@dpdk.org, arybchenko@solarflare.com Date: Mon, 06 Jul 2020 10:15:42 +0200 Message-ID: <13068074.RF7ULXdDSz@thomas> In-Reply-To: <20200706075318.8048-1-wisamm@mellanox.com> References: <20200630081028.21339-1-wisamm@mellanox.com> <20200706075318.8048-1-wisamm@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] app/flow-perf: fix condition of hairpin queues setup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 06/07/2020 09:53, Wisam Jaddo: > The hairpin queue is the one that start from normal rxq, > and will be less than nr_queues where nr_queues is the > sum of normal and hairpin > > Fixes: bf3688f1e816 ("app/flow-perf: add insertion rate calculation") > Cc: wisamm@mellanox.com > > Signed-off-by: Wisam Jaddo > Reviewed-by: Asaf Penso > > --- > v2: > * Add documentation of hairpin peering and allocating logic. > * Add documentation for some variables. > --- > --- a/app/test-flow-perf/main.c > +++ b/app/test-flow-perf/main.c > @@ -1012,8 +1012,26 @@ init_port(void) > rte_strerror(-ret), port_id); > > if (hairpinq != 0) { > + /* Each hairpin queue setup need a hairpin configuration > + * object, which determine the TX path for hairpin. > + * > + * The peering here represent the TX side, which mean the > + * peer.port represent TX port, and peer.queue represent > + * tx_queue. > + * > + * So if RXQ=4 and TXQ=4, and first hairpin_q is 4 after > + * [0, 1, 2, 3], then tx_queue is TXQ+i which is 4 as well. > + * > + * hairpinq: represent the number of hairpin queues needed > + * to be initialized. > + * > + * In 0 case means no hairpin queues needed which is the > + * default. > + * > + * hairpin_q: represent hairpin queue id to be initialized. > + */ Variables doc should be on variable declaration.