* [PATCH] net: fix build with -Wpedantic
@ 2022-09-29 6:50 Ali Alnubani
2022-09-29 7:01 ` [EXT] " Akhil Goyal
0 siblings, 1 reply; 6+ messages in thread
From: Ali Alnubani @ 2022-09-29 6:50 UTC (permalink / raw)
To: dev; +Cc: gakhil
Adds the __extension__ attribute to resolve the following warning
with gcc 4.8.5 on CentOS 7:
lib/net/rte_macsec.h:38:2: error: type of bit-field 'short_length' is
a GCC extension [-Werror=pedantic]
Fixes: 0aaf097585a6 ("ethdev: add MACsec flow item")
Cc: gakhil@marvell.com
Signed-off-by: Ali Alnubani <alialnu@nvidia.com>
---
lib/net/rte_macsec.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/net/rte_macsec.h b/lib/net/rte_macsec.h
index 9228ebd083..d0cd2f69ab 100644
--- a/lib/net/rte_macsec.h
+++ b/lib/net/rte_macsec.h
@@ -28,6 +28,7 @@ extern "C" {
/**
* MACsec Header (SecTAG)
*/
+__extension__
struct rte_macsec_hdr {
/**
* Tag control information and Association number of secure channel.
--
2.25.1
^ permalink raw reply [flat|nested] 6+ messages in thread* RE: [EXT] [PATCH] net: fix build with -Wpedantic
2022-09-29 6:50 [PATCH] net: fix build with -Wpedantic Ali Alnubani
@ 2022-09-29 7:01 ` Akhil Goyal
2022-09-29 7:07 ` Ali Alnubani
2022-09-29 7:09 ` Thomas Monjalon
0 siblings, 2 replies; 6+ messages in thread
From: Akhil Goyal @ 2022-09-29 7:01 UTC (permalink / raw)
To: Ali Alnubani, dev
> Adds the __extension__ attribute to resolve the following warning
> with gcc 4.8.5 on CentOS 7:
> lib/net/rte_macsec.h:38:2: error: type of bit-field 'short_length' is
> a GCC extension [-Werror=pedantic]
>
> Fixes: 0aaf097585a6 ("ethdev: add MACsec flow item")
> Cc: gakhil@marvell.com
>
> Signed-off-by: Ali Alnubani <alialnu@nvidia.com>
> ---
> lib/net/rte_macsec.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lib/net/rte_macsec.h b/lib/net/rte_macsec.h
> index 9228ebd083..d0cd2f69ab 100644
> --- a/lib/net/rte_macsec.h
> +++ b/lib/net/rte_macsec.h
> @@ -28,6 +28,7 @@ extern "C" {
> /**
> * MACsec Header (SecTAG)
> */
> +__extension__
RTE_STD_C11 ??
> struct rte_macsec_hdr {
> /**
> * Tag control information and Association number of secure channel.
> --
> 2.25.1
^ permalink raw reply [flat|nested] 6+ messages in thread* RE: [EXT] [PATCH] net: fix build with -Wpedantic
2022-09-29 7:01 ` [EXT] " Akhil Goyal
@ 2022-09-29 7:07 ` Ali Alnubani
2022-09-29 7:09 ` Akhil Goyal
2022-09-29 7:09 ` Thomas Monjalon
1 sibling, 1 reply; 6+ messages in thread
From: Ali Alnubani @ 2022-09-29 7:07 UTC (permalink / raw)
To: Akhil Goyal, dev
> -----Original Message-----
> From: Akhil Goyal <gakhil@marvell.com>
> Sent: Thursday, September 29, 2022 10:02 AM
> To: Ali Alnubani <alialnu@nvidia.com>; dev@dpdk.org
> Subject: RE: [EXT] [PATCH] net: fix build with -Wpedantic
>
> > Adds the __extension__ attribute to resolve the following warning
> > with gcc 4.8.5 on CentOS 7:
> > lib/net/rte_macsec.h:38:2: error: type of bit-field 'short_length' is
> > a GCC extension [-Werror=pedantic]
> >
> > Fixes: 0aaf097585a6 ("ethdev: add MACsec flow item")
> > Cc: gakhil@marvell.com
> >
> > Signed-off-by: Ali Alnubani <alialnu@nvidia.com>
> > ---
> > lib/net/rte_macsec.h | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/lib/net/rte_macsec.h b/lib/net/rte_macsec.h
> > index 9228ebd083..d0cd2f69ab 100644
> > --- a/lib/net/rte_macsec.h
> > +++ b/lib/net/rte_macsec.h
> > @@ -28,6 +28,7 @@ extern "C" {
> > /**
> > * MACsec Header (SecTAG)
> > */
> > +__extension__
>
> RTE_STD_C11 ??
Replacing the __extension__ attribute with RTE_STD_C11 doesn't resolve the build failure for me.
^ permalink raw reply [flat|nested] 6+ messages in thread* RE: [EXT] [PATCH] net: fix build with -Wpedantic
2022-09-29 7:07 ` Ali Alnubani
@ 2022-09-29 7:09 ` Akhil Goyal
2022-09-29 7:20 ` Thomas Monjalon
0 siblings, 1 reply; 6+ messages in thread
From: Akhil Goyal @ 2022-09-29 7:09 UTC (permalink / raw)
To: Ali Alnubani, dev
> > > Adds the __extension__ attribute to resolve the following warning
> > > with gcc 4.8.5 on CentOS 7:
> > > lib/net/rte_macsec.h:38:2: error: type of bit-field 'short_length' is
> > > a GCC extension [-Werror=pedantic]
> > >
> > > Fixes: 0aaf097585a6 ("ethdev: add MACsec flow item")
> > > Cc: gakhil@marvell.com
> > >
> > > Signed-off-by: Ali Alnubani <alialnu@nvidia.com>
> > > ---
> > > lib/net/rte_macsec.h | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/lib/net/rte_macsec.h b/lib/net/rte_macsec.h
> > > index 9228ebd083..d0cd2f69ab 100644
> > > --- a/lib/net/rte_macsec.h
> > > +++ b/lib/net/rte_macsec.h
> > > @@ -28,6 +28,7 @@ extern "C" {
> > > /**
> > > * MACsec Header (SecTAG)
> > > */
> > > +__extension__
> >
> > RTE_STD_C11 ??
>
> Replacing the __extension__ attribute with RTE_STD_C11 doesn't resolve the
> build failure for me.
Ok, Thanks for the fix.
Acked-by: Akhil Goyal <gakhil@marvell.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [EXT] [PATCH] net: fix build with -Wpedantic
2022-09-29 7:09 ` Akhil Goyal
@ 2022-09-29 7:20 ` Thomas Monjalon
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2022-09-29 7:20 UTC (permalink / raw)
To: Ali Alnubani; +Cc: dev, Akhil Goyal
29/09/2022 09:09, Akhil Goyal:
> > > > Adds the __extension__ attribute to resolve the following warning
> > > > with gcc 4.8.5 on CentOS 7:
> > > > lib/net/rte_macsec.h:38:2: error: type of bit-field 'short_length' is
> > > > a GCC extension [-Werror=pedantic]
> > > >
> > > > Fixes: 0aaf097585a6 ("ethdev: add MACsec flow item")
> > > > Cc: gakhil@marvell.com
> > > >
> > > > Signed-off-by: Ali Alnubani <alialnu@nvidia.com>
> > > > ---
> > > > lib/net/rte_macsec.h | 1 +
> > > > 1 file changed, 1 insertion(+)
> > > >
> > > > diff --git a/lib/net/rte_macsec.h b/lib/net/rte_macsec.h
> > > > index 9228ebd083..d0cd2f69ab 100644
> > > > --- a/lib/net/rte_macsec.h
> > > > +++ b/lib/net/rte_macsec.h
> > > > @@ -28,6 +28,7 @@ extern "C" {
> > > > /**
> > > > * MACsec Header (SecTAG)
> > > > */
> > > > +__extension__
> > >
> > > RTE_STD_C11 ??
> >
> > Replacing the __extension__ attribute with RTE_STD_C11 doesn't resolve the
> > build failure for me.
>
> Ok, Thanks for the fix.
>
> Acked-by: Akhil Goyal <gakhil@marvell.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [EXT] [PATCH] net: fix build with -Wpedantic
2022-09-29 7:01 ` [EXT] " Akhil Goyal
2022-09-29 7:07 ` Ali Alnubani
@ 2022-09-29 7:09 ` Thomas Monjalon
1 sibling, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2022-09-29 7:09 UTC (permalink / raw)
To: Ali Alnubani, Akhil Goyal; +Cc: dev
29/09/2022 09:01, Akhil Goyal:
> > Adds the __extension__ attribute to resolve the following warning
> > with gcc 4.8.5 on CentOS 7:
> > lib/net/rte_macsec.h:38:2: error: type of bit-field 'short_length' is
> > a GCC extension [-Werror=pedantic]
> >
> > Fixes: 0aaf097585a6 ("ethdev: add MACsec flow item")
> > Cc: gakhil@marvell.com
> >
> > Signed-off-by: Ali Alnubani <alialnu@nvidia.com>
> > ---
> > --- a/lib/net/rte_macsec.h
> > +++ b/lib/net/rte_macsec.h
> > @@ -28,6 +28,7 @@ extern "C" {
> > /**
> > * MACsec Header (SecTAG)
> > */
> > +__extension__
>
> RTE_STD_C11 ??
We use RTE_STD_C11 only for anonymous struct and union.
I don't know why we don't use it for bitfield in struct.
It seems to be part of C11 standard, right?
In doubt, I would continue with __extension__
and we can replace all similar occurences in a separate patch,
if confirmed it is well defined in C11.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-09-29 7:20 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-29 6:50 [PATCH] net: fix build with -Wpedantic Ali Alnubani
2022-09-29 7:01 ` [EXT] " Akhil Goyal
2022-09-29 7:07 ` Ali Alnubani
2022-09-29 7:09 ` Akhil Goyal
2022-09-29 7:20 ` Thomas Monjalon
2022-09-29 7:09 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).