From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E6DEE42D07; Tue, 20 Jun 2023 12:32:19 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BAA604068E; Tue, 20 Jun 2023 12:32:19 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id D56A5400D6 for ; Tue, 20 Jun 2023 12:32:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687257138; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dQncZUczOYG6I57JO3HKPKdIXqH0YYito5gsCDG4q8s=; b=S+09ne/xgGnmU6li5xSRsQzm3O/lwri9VcImnAylGyZediWNAb6n2WBPuCT5NpUcP3416y xrabKETkrA2rTA0K2V1iLGu7C7W01AcLjbTlRi/y8e1CimVaaO+mU+rrZUD93yKxh6qm7I Bc6kkWjwD5t7dpBJ0sLgdqVrEmDjYiM= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-625--7VSlCQOPMegwWlNpUu1KQ-1; Tue, 20 Jun 2023 06:32:15 -0400 X-MC-Unique: -7VSlCQOPMegwWlNpUu1KQ-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-4f8727c7fb6so1577379e87.0 for ; Tue, 20 Jun 2023 03:32:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687257134; x=1689849134; h=content-transfer-encoding:in-reply-to:subject:from:references:cc:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dQncZUczOYG6I57JO3HKPKdIXqH0YYito5gsCDG4q8s=; b=AeegNUJIHgOkJ91idTaEbWedMtGaIL+6iksqx3FGQ5CMeZ9KuSGE0KUOFAknbnriZs 2k/jS5bjBCzQ4M2gxk8UbLqiufpZY6ImN6NUw3knB0vYtdvd4FnY7EBXp3ClNsEofnKx rAkxMHIA/i3MtYYGNjNEy5P+Ce/DRlE0Q37eNp/iLSFgg7qEXFNXYShRk+T3gIBKdShU l3tMFh5UaP+kNtgGGmv1AWMxQJJgE0ds5J9m690QAzpR19Fgh2Q3owihcTgV9zZnPn4e QXBFlE0vGu6BRkpiCI0TSFsOmsG0aqXRO5fYkM349a85RoQrUQehK5eKTu3SCs5Qba7b k1Qw== X-Gm-Message-State: AC+VfDyz5G0bV9Su6V4lF9pW3VtFt8T+b6wXYbBoH2rKVlqQf5kmA4eg yqP79au12TJUattV59uY0Y4k3N/YQdtM0G9fQX0kvBz1MMXH1kFdQ7ox45ypor/+fQYkIq+pecs 6EUI= X-Received: by 2002:a05:6512:612:b0:4f6:1c08:e9b0 with SMTP id b18-20020a056512061200b004f61c08e9b0mr7060645lfe.63.1687257134426; Tue, 20 Jun 2023 03:32:14 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4Lj1kB7qICFp8ApItS9cARLu0r3jAUSUUU/FerJva/5M3GqmcJ4l76hcSFAOdk/lNlVKlihg== X-Received: by 2002:a05:6512:612:b0:4f6:1c08:e9b0 with SMTP id b18-20020a056512061200b004f61c08e9b0mr7060634lfe.63.1687257134023; Tue, 20 Jun 2023 03:32:14 -0700 (PDT) Received: from [192.168.0.36] ([78.19.103.115]) by smtp.gmail.com with ESMTPSA id y7-20020a05600c364700b003f8fbe3bf7asm11333806wmq.32.2023.06.20.03.32.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Jun 2023 03:32:13 -0700 (PDT) Message-ID: <131df642-00ea-8317-bd09-9cc347a0d194@redhat.com> Date: Tue, 20 Jun 2023 11:32:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.1 To: David Marchand , Jerin Jacob , Luca Boccassi , "Xueming(Steven) Li" Cc: dev@dpdk.org References: <20230619204650.3348681-1-david.marchand@redhat.com> From: Kevin Traynor Subject: Re: [PATCH 1/2] test: add graph tests In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 20/06/2023 07:56, David Marchand wrote: > On Tue, Jun 20, 2023 at 8:50 AM Jerin Jacob wrote: >> >> On Tue, Jun 20, 2023 at 2:17 AM David Marchand >> wrote: >>> >>> We forgot to add graph unit tests to the CI testsuites. >>> >>> Signed-off-by: David Marchand >> >> Could we add Fixes: ? >> Either way, >> Acked-by: Jerin Jacob > > Indeed. > I don't think the graph unit tests and code changed much, so it should > be ok to backport down to 20.11 and enable these ut in the CI. > > Sounds ok to me to add "Fixes:" tag and backport. If they pass, great - if they don't, the graph maintainers would need to spend time updating the tests etc or we could just drop the patch.